Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 586002 - www-client/firefox with musl: stack overflow in brotli WriteRingBuffer
Summary: www-client/firefox with musl: stack overflow in brotli WriteRingBuffer
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: musl-porting
  Show dependency tree
 
Reported: 2016-06-15 09:14 UTC by tt_1
Modified: 2016-08-10 09:35 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch from upstream (firefox-47.0-fix-crash-in-brotli-WriteRingBuffer.patch,2.95 KB, patch)
2016-06-15 09:14 UTC, tt_1
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description tt_1 2016-06-15 09:14:05 UTC
Created attachment 437626 [details, diff]
patch from upstream

There seems to be a crash related to the allocate buffer on musl being too small. Upstream bug report is https://bugzilla.mozilla.org/show_bug.cgi?id=1274732 , the patch has been landed in the 49 branch. To me it seems reasonable to apply it to both the 47 branch as well as to the upcoming 48 branch.
Comment 1 tt_1 2016-06-27 21:10:06 UTC
Upstream backported the fix to the upcoming 48 branch, so the amount of work to be done for 47 is minimal. Are you willing to add the patch to the tarball or not?
Comment 2 Ian Stakenvicius (RETIRED) gentoo-dev 2016-06-28 18:45:13 UTC
I'll look at this once I get 48.0_beta3 to build.  There's still a couple of weeks before 47.0 will be dropped so I think it's worth pursuing yes.
Comment 3 tt_1 2016-07-10 14:35:51 UTC
I just checked 47.0.1, it is still affected. The attached upstrem patch heals the segfault, and can be applied without any itchy backporting. Please close this bug if you managed to push the patch to the overlay and have it in the ebuild. Thanks.
Comment 4 tt_1 2016-08-10 09:35:15 UTC
upstream fixed this in 48.0, the current esr branch is not affected.