Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 585556 - media-plugins/fdk-aac-0.1.4 fails to build with GCC 6: Narrowing conversion from unsigned int to long int
Summary: media-plugins/fdk-aac-0.1.4 fails to build with GCC 6: Narrowing conversion f...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: gcc-6
  Show dependency tree
 
Reported: 2016-06-10 21:31 UTC by Aric Belsito
Modified: 2016-09-14 18:59 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to enable building fdk-aac with GCC6 and no standard switch. (fdk-aac-0.1.4-gcc6.patch,28.32 KB, patch)
2016-06-13 18:37 UTC, Aric Belsito
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aric Belsito 2016-06-10 21:31:21 UTC
See the following bug:
https://github.com/mstorsjo/fdk-aac/issues/41

Fraunhofer has not yet attempted to fix the bug, but we can fix this by adding -std=c++98 until they make their code compatible with the C++14 standard.
Comment 1 Aric Belsito 2016-06-13 18:37:21 UTC
Created attachment 437418 [details, diff]
Patch to enable building fdk-aac with GCC6 and no standard switch.
Comment 2 David Seifert gentoo-dev 2016-09-14 12:59:10 UTC
(In reply to Aric Belsito from comment #1)
> Created attachment 437418 [details, diff] [details, diff]
> Patch to enable building fdk-aac with GCC6 and no standard switch.

I see that upstream just took the shortcut route and added -std=c++98, which sucks of course and is not in line with our policy on C++, which aims to be as -std= agnostic as possible for C++, in order to not upset dependant packages. Aric, I might still merge your patches, because I prefer your solution as it remains compatible with C++14.
Comment 3 David Seifert gentoo-dev 2016-09-14 18:59:35 UTC
@Aric, thanks for the patch, I believe this is the way we should fix C++98 -> C++14 bugs, by making packages -std=c++{98,14} agnostic.

commit f935b696c978db5b42158ec93896ca4bf3400bf2
Author: David Seifert <soap@gentoo.org>
Date:   Wed Sep 14 20:56:58 2016 +0200

    media-libs/fdk-aac: Allow for compiling with GCC 6
    
    Gentoo-bug: 585556
    * EAPI=6