Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 584524 - mail-filter/MailScanner-5.0.2 version bump
Summary: mail-filter/MailScanner-5.0.2 version bump
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Patrick Lauer
Depends on:
Reported: 2016-05-30 11:14 UTC by Philip Taffner
Modified: 2019-11-30 12:44 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

updated ebuild for 5.0.3-7 (MailScanner-,6.33 KB, text/plain)
2016-11-12 19:14 UTC, Michael Weiser
Updated MailScanner start script (initd.mailscanner,1.02 KB, text/plain)
2016-11-12 19:16 UTC, Michael Weiser
updated ebuild for MailScanner-5.0.3-7 (MailScanner-,7.53 KB, text/plain)
2016-11-13 19:23 UTC, Michael Weiser
updated start script for MailScanner-5.0.3-7 (initd.mailscanner,985 bytes, text/plain)
2016-11-13 19:26 UTC, Michael Weiser
patch for ms-check to get Gentoo-compliant (MailScanner-,1.61 KB, patch)
2016-11-13 19:28 UTC, Michael Weiser
Details | Diff
README.Gentoo documenting differences to stock behaviour (README.Gentoo,1.69 KB, text/plain)
2016-11-13 19:28 UTC, Michael Weiser
updated ebuild for v5.2.1-1 (MailScanner-,7.53 KB, text/plain)
2019-11-30 12:44 UTC, Michael Weiser

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Taffner 2016-05-30 11:14:02 UTC
Update ebuild to latest release.
Comment 1 Patrick Lauer gentoo-dev 2016-06-29 08:07:12 UTC
The whole config handling needs to be rewritten, some obvious changes are:

< SRC_URI="${PN}-install-${MY_PVR}.tar.gz"
> SRC_URI="${PN}-${MY_PVR}.nix.tar.gz"
< S="${WORKDIR}/${PN}-${MY_PVR}"
> S="${WORKDIR}/${PN}-${MY_PV}"
Comment 2 Michael Weiser 2016-11-12 19:14:15 UTC
Created attachment 453156 [details]
updated ebuild for 5.0.3-7

I have this updated ebuild running locally.

After looking into the /etc/MailScanner/conf.d functionality I decided to drop upgrading of the config file in pkg_postinst() and put my local settings into an /etc/MailScanner/conf.d/local.conf instead. No idea how this could be automated for upgrades from 4.x but it seems a much more elegant and painless way of handling local adjustments to me: etc-update will point out changes in MailScanner.conf and the user either merges to leav the old fragment in or updates their local.conf accordingly.

I'm not happy with how /usr/sbin/ms-update-bad-emails and /usr/sbin/ms-update-sa unconditionally call /usr/lib/MailScanner/init/ms-init restart. Because they're (potentially) part of the regular cron jobs they may cause MailScanner to start even though it's not actually supposed to run. For now it's not a problem because run_mailscanner defaults to 0 in /etc/conf.d/MailScanner effectively disabling ms-init.

Which opens another bag of cats: I think we should drop all the settings from conf.d/MailScanner that we don't need to avoid user confusion.
Comment 3 Michael Weiser 2016-11-12 19:16:44 UTC
Created attachment 453158 [details]
Updated MailScanner start script

This updated MailScanner start script uses start-stop-daemon's --retry option with "SIGTERM/30 SIGKILL/1". This way I don't seem to need the sleep $RESTART_DELAY on restarts any more and eliminated it together with it's now totally unused friend UPDATEMAXDELAY from /etc/conf.d/MailScanner.
Comment 4 Michael Weiser 2016-11-13 19:23:15 UTC
Created attachment 453222 [details]
updated ebuild for MailScanner-5.0.3-7

Did another pass, solving all my previous niggles to my satisfaction.
Comment 5 Michael Weiser 2016-11-13 19:26:39 UTC
Created attachment 453224 [details]
updated start script for MailScanner-5.0.3-7

- drop useless /var/lock/subsys/MailScanner
- use ms-peek to get path to PID file
- use automagically available settings from conf.d
- drop default-matching restart() and add reload() using SIGHUP
Comment 6 Michael Weiser 2016-11-13 19:28:21 UTC
Created attachment 453226 [details, diff]
patch for ms-check to get Gentoo-compliant

see top of patch for rationale
Comment 7 Michael Weiser 2016-11-13 19:28:55 UTC
Created attachment 453228 [details]
README.Gentoo documenting differences to stock behaviour
Comment 8 Michael Weiser 2019-11-30 12:44:20 UTC
Created attachment 597986 [details]
updated ebuild for v5.2.1-1

Attached is an updated ebuild for the current version.