Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 583614 - dev-libs/gmime ebuild does not support enabling smime support, required for net-mail/notmuch
Summary: dev-libs/gmime ebuild does not support enabling smime support, required for n...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Amadeusz Żołnowski (RETIRED)
URL:
Whiteboard:
Keywords: Inclusion
Depends on:
Blocks: 583678
  Show dependency tree
 
Reported: 2016-05-20 22:39 UTC by Jack
Modified: 2016-05-31 21:20 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
gmime-smime.patch (gmime-smime.patch,1.26 KB, patch)
2016-05-22 19:45 UTC, Amadeusz Żołnowski (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jack 2016-05-20 22:39:42 UTC
net-mail/notmuch-0.22 fails tests due to lack of smime support by dev-libs/gmime.  gmime's ./configure defaults to not enable smime.  

Adding smime to IUSE, and adding $(use_enable smime) to src_configure compiles gmime with smime support (using gpgme, which I suppose should be added as a dependency in this case) which then allows notmuch to pass the S/MIME test.
Comment 1 Amadeusz Żołnowski (RETIRED) gentoo-dev 2016-05-21 16:01:29 UTC
I think --enable-smime should be passed unconditionally as --enable-cryptography. It doesn't need extra dependencies.
Comment 2 Jack 2016-05-21 16:25:18 UTC
I would be happy with unconditional smime, as you suggest.

Sorry, I just didn't notice that gpgme is already a dependency.
Comment 3 Mart Raudsepp gentoo-dev 2016-05-22 17:58:26 UTC
Looks like gpgme dependency is unnecessary without --enable-smime, so maybe that part was done wrong in the past. Might read the configure.ac and #define's wrong though, getting late for me.
S/MIME support in gmime is experimental though, hence the default disabled upstream.
Maybe we should remove the dependency (if what I suspect is true), and then think about this experimental S/MIME thing behind use flag that adds gpgme dep back.
Comment 4 Amadeusz Żołnowski (RETIRED) gentoo-dev 2016-05-22 19:45:47 UTC
Created attachment 435000 [details, diff]
gmime-smime.patch

I have checked with net-mail/notmuch. Tests against gmime+smime pass. Functionality in UI is present now.
Comment 5 Amadeusz Żołnowski (RETIRED) gentoo-dev 2016-05-30 17:30:51 UTC
ping
Comment 6 Jack 2016-05-30 18:49:20 UTC
Looks good to me, but I do not think my ok is required.
Comment 7 Pacho Ramos gentoo-dev 2016-05-31 09:01:49 UTC
@aidecoe, feel free to go ahead... but I would revbump it (for that you will likely need to do two revbumps, one as a candidate to be stabilized soon and other for testing with the new gtk-sharp depend and as I am unsure when we will be able to stabilize newer gtk-sharp)
Comment 8 Amadeusz Żołnowski (RETIRED) gentoo-dev 2016-05-31 21:20:07 UTC
Thanks, Pacho! It is done. Jack, thanks for reporting!