Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 583542 - dev-util/electron-1.3.4: version bump
Summary: dev-util/electron-1.3.4: version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Elvis Pranskevichus
URL: http://electron.atom.io/releases/
Whiteboard:
Keywords:
Depends on:
Blocks: 593502
  Show dependency tree
 
Reported: 2016-05-20 06:37 UTC by PetaMem R&D
Modified: 2016-09-20 13:42 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description PetaMem R&D 2016-05-20 06:37:57 UTC
current version in portage: 0.36.12
available already 1.1.x - see http://electron.atom.io/releases/



Reproducible: Always
Comment 1 Perfect Gentleman 2016-07-10 11:43:49 UTC
1.2.6 is out
https://github.com/electron/electron/releases/tag/v1.2.6
Comment 2 Sorrow 2016-07-30 12:04:46 UTC
1.3.1 is here
https://github.com/electron/electron/releases/tag/v1.3.1
Comment 3 Dennis Schridde 2016-08-27 16:24:09 UTC
There was an effort by eternal-sorrow to get this done: https://github.com/eternal-sorrow/gentoo-local/issues/1

The part that is still missing there are two "build-fixes" patches, that need to be ported to the new version of electron.
Comment 4 Sorrow 2016-08-27 16:34:35 UTC
(In reply to Dennis Schridde from comment #3)
> There was an effort by eternal-sorrow to get this done:
> https://github.com/eternal-sorrow/gentoo-local/issues/1
> 
> The part that is still missing there are two "build-fixes" patches, that
> need to be ported to the new version of electron.

It's me.
Comment 5 Elvis Pranskevichus 2016-08-28 15:48:44 UTC
I actually have build patches and ebuild updates for 1.1 and 1.3, but there is a weird segfault I'm still tracking down.
Comment 6 Dennis Schridde 2016-08-28 15:58:03 UTC
(In reply to Elvis Pranskevichus from comment #5)
> I actually have build patches and ebuild updates for 1.1 and 1.3, but there
> is a weird segfault I'm still tracking down.

Is that available in an overlay somewhere? Maybe others could try to reproduce it and help you.
Comment 7 Elvis Pranskevichus 2016-08-28 16:00:47 UTC
(In reply to Dennis Schridde from comment #6)
> Is that available in an overlay somewhere? Maybe others could try to
> reproduce it and help you.

I'll push to the atom overlay soon.
Comment 8 Elvis Pranskevichus 2016-08-28 19:25:02 UTC
I pushed 0.37.8 and 1.3.3 to the atom overlay.  Again, those segfault early due to a strange compilation mismatch of node's process_object vtable (different offsets to class members).  That might be due to a header mismatch somewhere, possibly libuv, but I haven't figured it out yet.  Electron build is fiendishly complex.
Comment 9 Elvis Pranskevichus 2016-09-08 19:44:54 UTC
I figured out what was causing the crashes.  As I suspected, electron is patching libuv in interesting ways making it impossible to use the system version.

I pushed working ebuilds to the overlay.  The builds are now slotted with (Major.Minor), so it is possible to have multiple electron installs at the same time.  eselect-electron is also there.

Please test and let me know if this works, and I'll make a PR to push this into the tree.
Comment 10 Sorrow 2016-09-10 12:20:53 UTC
build with USE="-cups" failed on linkage step:
ld: cannot find -lcups
need to patch brightray.gyp
Comment 11 Elvis Pranskevichus 2016-09-13 13:43:13 UTC
> ld: cannot find -lcups

Thanks.  The fix is in the overlay.
Comment 12 Elvis Pranskevichus 2016-09-15 13:39:43 UTC
The PR is in: https://github.com/gentoo/gentoo/pull/2336/files
Comment 13 Andreas Berg 2016-09-17 05:22:08 UTC
electron-0.37.8 does not build here:

Updating projects from gyp files...
/bin/sh: node: command not found
gyp: Call to 'node ./tools/atom_source_root.js' returned exit status 127 while in electron.gyp.

Should it depend on nodejs?
Comment 14 Elvis Pranskevichus 2016-09-19 13:41:14 UTC
Yikes!  They decided that invoking node on a .js one liner is a good idea to determine the absolute path to the source directory.  Will fix shortly.  And no, a dependency on nodejs is not necessary.
Comment 15 Elvis Pranskevichus 2016-09-19 15:31:32 UTC
> electron-0.37.8 does not build here

I pushed the fixes to the overlay and updated the PR.  Thanks for catching this!
Comment 16 Elvis Pranskevichus 2016-09-20 13:42:19 UTC
commit c23fbb5334aa47af81d5dc79d8a340b299523b04
Author:     Elvis Pranskevichus <elvis@magic.io>
AuthorDate: Thu Sep 15 09:30:16 2016 -0400
Commit:     Yixun Lan <dlan@gentoo.org>
CommitDate: Tue Sep 20 14:12:22 2016 +0800

    dev-util/electron: 0.37, 1.3 version bump, slotted build
    
      * Add electron-0.37.8, electron-1.3.5.
      * Ebuilds have been slotted, it is now possible
        to have multiple versions of Electron installed.
      * Numerous build fixes.
      * PaX fixes (courtesy of @zaolin).
    
    Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=591324
    Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=583542
    
    Package-Manager: portage-2.2.28
    
    Signed-off-by: Yixun Lan <dlan@gentoo.org>

 dev-util/electron/Manifest                                                                                                |  14 +++-
 dev-util/electron/{electron-0.36.12-r3.ebuild => electron-0.36.12-r4.ebuild}                                              |  48 ++++++++----
 dev-util/electron/electron-0.37.8.ebuild                                                                                  | 749 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 dev-util/electron/electron-1.3.5.ebuild                                                                                   | 765 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 dev-util/electron/files/chromium-ffmpeg-license-r0.patch                                                                  |  44 +++++++++++
 dev-util/electron/files/chromium-last-commit-position-r0.patch                                                            |  26 +++++++
 dev-util/electron/files/chromium-linker-warnings-r0.patch                                                                 |  18 +++++
 dev-util/electron/files/chromium-lto-fixes-r1.patch                                                                       |  36 +++++++++
 dev-util/electron/files/chromium-pdfium-r0.patch                                                                          |  17 +++++
 dev-util/electron/files/chromium-shared-v8-r1.patch                                                                       |  15 ++++
 dev-util/electron/files/chromium-snapshot-toolchain-r1.patch                                                              |  23 ++++++
 dev-util/electron/files/chromium-system-ffmpeg-r2.patch                                                                   |  50 +++++++++++++
 dev-util/electron/files/chromium-system-icu-r0.patch                                                                      |  14 ++++
 dev-util/electron/files/chromium-system-jinja-r9.patch                                                                    |  71 ++++++++++++++++++
 dev-util/electron/files/chromium-system-zlib-r0.patch                                                                     |  19 +++++
 dev-util/electron/files/{brightray-gentoo-build-fixes-r1.patch => electron-0.36.12-vendor-brightray.patch}                |   0
 dev-util/electron/files/{libchromiumcontent-gentoo-build-fixes.patch => electron-0.36.12-vendor-libchromiumcontent.patch} |   0
 dev-util/electron/files/{node-gentoo-build-fixes.patch => electron-0.36.12-vendor-node.patch}                             |   0
 dev-util/electron/files/{electron-gentoo-build-fixes.patch => electron-0.36.12.patch}                                     |  43 +++++------
 dev-util/electron/files/electron-0.37.8-vendor-brightray.patch                                                            | 143 ++++++++++++++++++++++++++++++++++++
 dev-util/electron/files/electron-0.37.8-vendor-libchromiumcontent.patch                                                   |  71 ++++++++++++++++++
 dev-util/electron/files/electron-0.37.8-vendor-node.patch                                                                 | 105 ++++++++++++++++++++++++++
 dev-util/electron/files/electron-0.37.8.patch                                                                             | 391 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 dev-util/electron/files/electron-1.3.5-vendor-brightray.patch                                                             | 143 ++++++++++++++++++++++++++++++++++++
 dev-util/electron/files/electron-1.3.5-vendor-libchromiumcontent.patch                                                    |  78 ++++++++++++++++++++
 dev-util/electron/files/electron-1.3.5-vendor-node.patch                                                                  |  92 +++++++++++++++++++++++
 dev-util/electron/files/electron-1.3.5.patch                                                                              | 422 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 dev-util/electron/files/{node-external-snapshots.patch => electron-vendor-node-external-snapshots-r0.patch}               |  12 +--
 28 files changed, 3366 insertions(+), 43 deletions(-)