577312 – =media-libs/gstreamer-1.6.3: fails to build on uclibc because of bad declaration of strsignal()

Bug 577312 - =media-libs/gstreamer-1.6.3: fails to build on uclibc because of bad declaration of strsignal()

Summary: =media-libs/gstreamer-1.6.3: fails to build on uclibc because of bad declarat...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Library (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	GStreamer package maintainers

URL:	https://bugzilla.gnome.org/show_bug.c...
Whiteboard:
Keywords:

Duplicates (1):	578198 (view as bug list)
Depends on:
Blocks:	uclibc-porting
	Show dependency tree

Reported:	2016-03-13 15:08 UTC by Anthony Basile
Modified:	2016-05-11 00:27 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Anthony Basile gentoo-dev

2016-03-13 15:08:41 UTC

POSIX standards requires strsignal() to return a pointer to a char, not a const pointer to a char. [1]  On uClibc, and possibly other libc's, that do not HAVE_DECL_STRSIGNAL, libcompat.h declares const char *strsignal (int sig) which causes a type error.

This has been submitted upstream.  Its pretty trivial, so hopefully it will be acceptted soon.  If not, can we either add epatch_user() or just add it locally.  I'm pretty confident of its correctness.

Comment 1 Anthony Basile gentoo-dev

2016-03-21 17:07:58 UTC

gstreamer is bundling dev-libs/check and the problem is there.  i've got a pull request in to address this issue: https://github.com/libcheck/check/pull/24

Comment 2 Anthony Basile gentoo-dev

2016-03-22 22:37:57 UTC

(In reply to Anthony Basile from comment #1)
> gstreamer is bundling dev-libs/check and the problem is there.  i've got a
> pull request in to address this issue:
> https://github.com/libcheck/check/pull/24

This was accepted by libcheck.  gstreamer is going to import their fix.

Comment 3 Ben Kohler gentoo-dev

2016-03-24 17:54:35 UTC

*** Bug 578198 has been marked as a duplicate of this bug. ***

Comment 4 Anthony Basile gentoo-dev

2016-05-10 15:27:19 UTC

(In reply to Anthony Basile from comment #2)
> (In reply to Anthony Basile from comment #1)
> > gstreamer is bundling dev-libs/check and the problem is there.  i've got a
> > pull request in to address this issue:
> > https://github.com/libcheck/check/pull/24
> 
> This was accepted by libcheck.  gstreamer is going to import their fix.

@maintainers, its a tiny patch.  do you mind if i backport it?

Comment 5 SpanKY gentoo-dev

2016-05-10 20:34:00 UTC

if upstream has merged it, i'd say go for it

Comment 6 Anthony Basile gentoo-dev

2016-05-10 21:25:31 UTC

(In reply to SpanKY from comment #5)
> if upstream has merged it, i'd say go for it

yeah they did.

https://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=c9da8b0e7f53005ab125e48165dae39fbfee2352

Comment 7 Anthony Basile gentoo-dev

2016-05-10 23:31:37 UTC

(In reply to Anthony Basile from comment #6)
> (In reply to SpanKY from comment #5)
> > if upstream has merged it, i'd say go for it
> 
> yeah they did.
> 
> https://cgit.freedesktop.org/gstreamer/gstreamer/commit/
> ?id=c9da8b0e7f53005ab125e48165dae39fbfee2352

actually the gstreamer folks made a mistake.

Comment 8 Anthony Basile gentoo-dev

2016-05-11 00:27:41 UTC

(In reply to Anthony Basile from comment #7)
> (In reply to Anthony Basile from comment #6)
> > (In reply to SpanKY from comment #5)
> > > if upstream has merged it, i'd say go for it
> > 
> > yeah they did.
> > 
> > https://cgit.freedesktop.org/gstreamer/gstreamer/commit/
> > ?id=c9da8b0e7f53005ab125e48165dae39fbfee2352
> 
> actually the gstreamer folks made a mistake.

okay we figured it out.  they split the original commit into two.  i spliced them back together for the tree.