Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 575072 - media-video/vlc-2.2.1-r1 fails to build with ffmpeg-3
Summary: media-video/vlc-2.2.1-r1 fails to build with ffmpeg-3
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Nick Andrade
URL:
Whiteboard:
Keywords:
: 574798 (view as bug list)
Depends on:
Blocks: ffmpeg-3
  Show dependency tree
 
Reported: 2016-02-18 16:11 UTC by Toralf Förster
Modified: 2016-09-04 14:24 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-history.txt (emerge-history.txt,42 bytes, text/plain)
2016-02-18 16:11 UTC, Toralf Förster
Details
environment (environment,136.14 KB, text/plain)
2016-02-18 16:11 UTC, Toralf Förster
Details
media-video:vlc-2.2.1-r1:20160218-160359.log (media-video:vlc-2.2.1-r1:20160218-160359.log,270.82 KB, text/plain)
2016-02-18 16:11 UTC, Toralf Förster
Details
vlc-2.2.1-r1.ebuild (vlc-2.2.1-r1.ebuild,15.55 KB, text/plain)
2016-02-22 06:05 UTC, Nick Andrade
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2016-02-18 16:11:20 UTC
	cat ./revision.txt ; \
fi > revision.tmp
fatal: Not a git repository: '../.git/'
if diff revision.tmp ./revision.txt >/dev/null 2>&1; then \
	rm -f -- revision.tmp; \
else \


$ cat emerge-info.txt
  -----------------------------------------------------------------

  This is an unstable amd64 chroot image (named amd64-plasma-unstable_20160121-220753) at a hardened host acting as a tinderbox.

  -----------------------------------------------------------------

  make.conf: USE="mmx sse sse2 pax_kernel -cdinstall -oci8 bindist consolekit custom-cflags designer dnssec dot ecc -fpm ftp gles2 gnomecanvas gnuplot gnutls help icu inifile ipv6 isag jadetex javaxml llvm minizip mysqli nscd objc ogg opencv php -plasma png pulseaudio qt3support qt4 server ssh-askpass -ssse3 -system-jpeg system-libvpx truetype usb v4l2 vdpau xvfb xvmc xcb egl"

  -----------------------------------------------------------------
Portage 2.2.27 (python 2.7.11-final-0, default/linux/amd64/13.0/desktop/plasma, gcc-5.3.0, glibc-2.22-r2, 4.3.5-hardened-r2 x86_64)
=================================================================
System uname: Linux-4.3.5-hardened-r2-x86_64-Intel-R-_Core-TM-_i7-3770_CPU_@_3.40GHz-with-gentoo-2.2
KiB Mem:    16164680 total,   3955208 free
KiB Swap:   16777212 total,  16774832 free
Timestamp of repository gentoo: Thu, 18 Feb 2016 15:07:37 +0000
sh bash 4.3_p42-r2
ld GNU ld (Gentoo 2.25.1 p1.1) 2.25.1
ccache version 3.2.4 [disabled]
app-shells/bash:          4.3_p42-r2::gentoo
dev-java/java-config:     2.2.0::gentoo
dev-lang/perl:            5.22.1::gentoo
dev-lang/python:          2.7.11-r2::gentoo, 3.4.3-r7::gentoo, 3.5.1-r2::gentoo
dev-util/ccache:          3.2.4::gentoo
dev-util/cmake:           3.4.3::gentoo
dev-util/pkgconfig:       0.29::gentoo
sys-apps/baselayout:      2.2::gentoo
sys-apps/openrc:          0.20.5::gentoo
sys-apps/sandbox:         2.10-r1::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r1::gentoo
sys-devel/automake:       1.9.6-r4::gentoo, 1.10.3-r2::gentoo, 1.11.6-r2::gentoo, 1.12.6-r1::gentoo, 1.13.4-r1::gentoo, 1.14.1-r1::gentoo, 1.15-r2::gentoo
sys-devel/binutils:       2.25.1-r1::gentoo
sys-devel/gcc:            4.2.4-r1::gentoo, 4.9.3::gentoo, 5.3.0::gentoo
sys-devel/gcc-config:     1.8-r1::gentoo
sys-devel/libtool:        2.4.6-r2::gentoo
sys-devel/make:           4.1-r1::gentoo
sys-kernel/linux-headers: 4.4::gentoo (virtual/os-headers)
sys-libs/glibc:           2.22-r2::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.de.gentoo.org/gentoo-portage/
    priority: 1

local
    location: /usr/local/portage
    masters: gentoo
    priority: 2

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /etc/grs/systems.conf /etc/stunnel/stunnel.conf /usr/share/config /usr/share/easy-rsa /usr/share/gnupg/qualified.txt /usr/share/maven-bin-3.3/conf /var/lib/hsqldb /var/rancid/.cloginrc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/games/angband/gamedata/ /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=native -O2 -pipe"
DISTDIR="/var/tmp/distfiles"
EMERGE_DEFAULT_OPTS="--verbose-conflicts --deep --color=n --nospinner --tree --quiet-build --accept-properties=-interactive --accept-restrict=-fetch"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync network-sandbox news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://ftp.uni-erlangen.de/pub/mirrors/gentoo rsync://mirror.netcologne.de/gentoo/ ftp://sunsite.informatik.rwth-aachen.de/pub/Linux/gor.bytemark.co.uk/gentoo/ rsync://ftp.snt.utwente.nl/gentoo"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j1"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi alsa amd64 berkdb bindist bluetooth branding bzip2 cairo cdda cdr cli consolekit cracklib crypt cups custom-cflags cxx dbus declarative designer dnssec dot dri dts dvd dvdr ecc egl emboss encode exif fam firefox flac fortran ftp gdbm gif glamor gles2 gnomecanvas gnuplot gnutls gpm gtk help iconv icu inifile ipv6 isag jadetex javaxml jpeg kde kipi lcms ldap libnotify llvm mad minizip mmx mmxext mng modules mp3 mp4 mpeg multilib mysqli ncurses nls nptl nscd objc ogg opencv opengl openmp pam pango pax_kernel pcre pdf phonon php png policykit ppds pulseaudio qml qt3support qt4 qt5 readline sdl seccomp semantic-desktop server session spell sse sse2 ssh-askpass ssl startup-notification svg system-libvpx tcpd tiff truetype udev udisks unicode upower usb v4l2 vdpau vorbis widgets wxwidgets x264 xattr xcb xcomposite xinerama xml xscreensaver xv xvfb xvid xvmc zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en en_GB" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_4" RUBY_TARGETS="ruby20 ruby21" USERLAND="GNU" VIDEO_CARDS="intel i965" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 1 Toralf Förster gentoo-dev 2016-02-18 16:11:23 UTC
Created attachment 425838 [details]
emerge-history.txt
Comment 2 Toralf Förster gentoo-dev 2016-02-18 16:11:25 UTC
Created attachment 425840 [details]
environment
Comment 3 Toralf Förster gentoo-dev 2016-02-18 16:11:28 UTC
Created attachment 425842 [details]
media-video:vlc-2.2.1-r1:20160218-160359.log
Comment 4 Nick Andrade 2016-02-18 16:40:29 UTC
I just took a quick look at your posted files, and I believe the git error is a red herring. I think your real issue may be with ffmpeg; can you provide me with what version you're using of it in this environment?  The errors you're seeing appear to be what I saw when I was testing ffmpeg-3.0 (which isn't supported in VLC 2.2.x yet).
Comment 5 Nick Andrade 2016-02-19 04:57:54 UTC
I just upgraded ffmpeg up to 3.0, set MAKEOPTS to -j1, and duplicated your issue.  Looks like I need to put a block on ffmpeg > 2.9 for vlc-2.2.1-r1 and 2.2.2 (it crashes during configure for that version).  If you do need ffmpeg 3.0, I do know VLC-9999 works with that version.
Comment 6 Nick Andrade 2016-02-22 06:05:49 UTC
Created attachment 426168 [details]
vlc-2.2.1-r1.ebuild

Limiting the ebuild to ffmpeg < 3.0 for the moment.
Comment 7 Ian Delaney (RETIRED) gentoo-dev 2016-02-22 08:50:40 UTC
(In reply to Nick Andrade from comment #6)
> Created attachment 426168 [details]
> vlc-2.2.1-r1.ebuild
> 
> Limiting the ebuild to ffmpeg < 3.0 for the moment.

Can you repeat this in a unified diff please. Can't recall if I made mention before or not but a whole build means the changes are somewhere in an ebuild > 17 kb long
Also # Copyright 1999-2015
suggests you've not run repoman -f over it
Comment 8 Amy Liffey gentoo-dev 2016-02-22 09:17:48 UTC
author	        Amy Winston <amynka@gentoo.org>	2016-02-22 09:14:16 (GMT)
committer	Amy Winston <amynka@gentoo.org>	2016-02-22 09:14:16 (GMT)
commit	0e87912f16c7602c1baa0bfdab3faca2d1318c6b 

media-video/vlc: ffmpeg-3 blocked bug #575072
Comment 9 Ian Delaney (RETIRED) gentoo-dev 2016-02-25 12:25:20 UTC
I specifically held back on committing this and requested a  unified diff. What happened to it? Why was this suddenly committed and closed with the request being seemingly ignored and skipped
Comment 10 Alexis Ballier gentoo-dev 2016-02-25 14:40:24 UTC
(In reply to Amy Winston from comment #8)
> media-video/vlc: ffmpeg-3 blocked bug #575072

this is the wrong solution anyway

(In reply to Ian Delaney from comment #9)
> I specifically held back on committing this and requested a  unified diff.
> What happened to it? Why was this suddenly committed and closed with the
> request being seemingly ignored and skipped

please leave the bug open until this is *really* fixed

closing it means bug will appear as fixed in the tracker and i will unmask ffmpeg-3 even if it'd cause pain to vlc users...
Comment 11 Nick Andrade 2016-02-25 19:26:23 UTC
(In reply to Ian Delaney from comment #9)
> I specifically held back on committing this and requested a  unified diff.
> What happened to it? Why was this suddenly committed and closed with the
> request being seemingly ignored and skipped

I believe what happened was that Amy saw the bug, saw an ebuild uploaded by me (the proxy-maintainer), and she thought it was ready to be pushed to git and resolve the bug.  She prefers whole ebuilds as opposed to diffs.  I understand and appreciate what she did especially knowing that she was just trying to do the right thing. Personally, I think getting the updated ebuild that prevents failed builds from the current stable release of VLC in portage is the right thing to do although I agree the bug shouldn't have been closed yet.

(In reply to Alexis Ballier from comment #10)
> (In reply to Amy Winston from comment #8)
> > media-video/vlc: ffmpeg-3 blocked bug #575072
> 
> this is the wrong solution anyway

I agree.  This is an interim solution to prevent other Gentoo users from encountering the same bug Toralf ran into by unmasking ffmpeg 3.  Prior to this update, VLC-2.2.1-r1 allowed users to try to build it with ffmpeg-3.0, and would fail during the build process.  This update merely limits the current VLC stable version to ffmpeg < 3.0 (preventing that build) if they use the ffmepg USE flag.  My goal was just to prevent more eager users from experiencing this bug, but I'm fine with having this change reverted if this is not the correct approach.  As I'm sure you know, ffmpeg is a very popular library (a stor about it hitting 3.0 made the front page of Slashdot yesterday), so I do expect a lot of people will unmask it.

(In reply to Alexis Ballier from comment #10)
> (In reply to Ian Delaney from comment #9)
> > I specifically held back on committing this and requested a  unified diff.
> > What happened to it? Why was this suddenly committed and closed with the
> > request being seemingly ignored and skipped
> 
> please leave the bug open until this is *really* fixed
> 
> closing it means bug will appear as fixed in the tracker and i will unmask
> ffmpeg-3 even if it'd cause pain to vlc users...

Again, I'm totally fine with leaving this open until a VLC release supports ffmpeg 3.x, and I do believe it was closed prematurely by Amy whom was only trying to help.  Unfortunately with the API/ABI changes in ffmpeg, that may be a while.  As of two days ago, VLC-9999 builds with ffmpeg 3.0, but VLC-2.2.9999 does not so it may be a while until we can close.
Comment 12 Ian Delaney (RETIRED) gentoo-dev 2016-02-26 12:26:56 UTC
Nick,   sure.
The use of diff vs whole ebuild is traditional but with a simple solid rationale.  All long experienced devs want to peruse a unified diff which at a glance informs of the key changes from what was happening before. A whole ebuild is merely a whole ebuild and perusing it tells nothing.  While bowing to the prefs of devs might appears appeasing personal whim, it never was.

I honestly thought this was established with you around July last year. A goal here is consistency amongst devs and here this was absent.  A whole ebuild on the spot means a dev can make one on the spot however I get the impression the attempts here were more aimed at immediacy than usual scanning and testing.

aballier; I am disinclined to close any bug unless it is actually fixed, Nothing special about this one.
Comment 13 Nick Andrade 2016-02-27 17:45:15 UTC
(In reply to Ian Delaney from comment #12)
> Nick,   sure.
> The use of diff vs whole ebuild is traditional but with a simple solid
> rationale.  All long experienced devs want to peruse a unified diff which at
> a glance informs of the key changes from what was happening before. A whole
> ebuild is merely a whole ebuild and perusing it tells nothing.  While bowing
> to the prefs of devs might appears appeasing personal whim, it never was.
> 
> I honestly thought this was established with you around July last year. A
> goal here is consistency amongst devs and here this was absent.  A whole
> ebuild on the spot means a dev can make one on the spot however I get the
> impression the attempts here were more aimed at immediacy than usual
> scanning and testing.
> 
> aballier; I am disinclined to close any bug unless it is actually fixed,
> Nothing special about this one.

You're right, a diff would make more sense for this type of change, and if we're trying to move towards a standard of using diffs I am totally happy to support that going forward.  For any currently still open bugs where I've attached full ebuilds, I'll also provide a diff.  For new bugs, I'll stick to diffs unless it's something huge.  In either case, I'll explain what I did in the comments.
Comment 14 Alexis Ballier gentoo-dev 2016-09-02 09:19:16 UTC
commit 1e7e5cf5b4395cb2ff0207ca4749d11b95a6d4d5
Author: Alexis Ballier <aballier@gentoo.org>
Date:   Fri Sep 2 11:18:37 2016 +0200

    media-video/vlc: add patches to build with ffmpeg3, bug #574788
Comment 15 Arfrever Frehtes Taifersar Arahesis 2016-09-04 14:24:26 UTC
*** Bug 574798 has been marked as a duplicate of this bug. ***