Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 574790 - media-plugins/gst-plugins-libav-1.6.3 fails to build with ffmpeg-3.0
Summary: media-plugins/gst-plugins-libav-1.6.3 fails to build with ffmpeg-3.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: GStreamer package maintainers
URL: https://bugzilla.gnome.org/show_bug.c...
Whiteboard:
Keywords:
Depends on:
Blocks: ffmpeg-3
  Show dependency tree
 
Reported: 2016-02-15 14:02 UTC by Alexis Ballier
Modified: 2016-02-17 21:11 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Ballier gentoo-dev 2016-02-15 14:02:14 UTC
/var/tmp/portage/media-plugins/gst-plugins-libav-1.6.3/work/gst-libav-1.6.3/ext/libav/gstavcodecmap.h:135:55: warning: its scope is only this definition or declaration, which is probably not what you want
/var/tmp/portage/media-plugins/gst-plugins-libav-1.6.3/work/gst-libav-1.6.3/ext/libav/gstavcodecmap.c: In function 'gst_ffmpeg_video_set_pix_fmts':
/var/tmp/portage/media-plugins/gst-plugins-libav-1.6.3/work/gst-libav-1.6.3/ext/libav/gstavcodecmap.c:225:50: error: type of formal parameter 1 is incomplete
       format = gst_ffmpeg_pixfmt_to_videoformat (i);
                                                  ^
/var/tmp/portage/media-plugins/gst-plugins-libav-1.6.3/work/gst-libav-1.6.3/ext/libav/gstavcodecmap.c:241:48: error: type of formal parameter 1 is incomplete
     format = gst_ffmpeg_pixfmt_to_videoformat (*fmts);


(and a lot more)


Note: this one will probably require patching on our side as upstream usually adapts git master and require latest ffmpeg, which we can't really do since this would mean gst & ffmpeg have to be updated, unmasked & stablized at the same time.
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2016-02-16 14:06:51 UTC
FYI, gst-plugins-libav-1.7.1 also fails with ffmpeg-3.0
I have neither found a patch nor an upstream bug for this problem.
Comment 2 Alexis Ballier gentoo-dev 2016-02-16 14:11:47 UTC
https://cgit.freedesktop.org/gstreamer/gst-libav/log/

there are patches there that would definitely help, esp. since they updated their internal copy to 3.0
Comment 3 Alexis Ballier gentoo-dev 2016-02-16 16:27:54 UTC
okey, so upstream patches backport properly to 1.6.3 and shouldn't break compatibility with ffmpeg 2.8

mind if I apply them?

only one issue: they require an eautoreconf call; any advise there ? it is just standard eautoreconf or does it need special care because of gtk-doc or other gst/gnome specificity ?
Comment 4 Alexis Ballier gentoo-dev 2016-02-17 21:11:19 UTC
commit f85d12e25f136a5418416704b1e8a37d041b4437
Author: Alexis Ballier <aballier@gentoo.org>
Date:   Wed Feb 17 22:06:14 2016 +0100

    media-plugins/gst-plugins-libav: Fix build and runtime with ffmpeg 3.0. Bug #574790.
    
    Patches are all from upstream, except gst-plugins-libav-1.6.3-minr-compat.patch which is a small #ifdefery more by myself to preser
ve working options and passing tests with ffmpeg 2.8.



done (got the 'go' from eva on irc)