Bug 574782 – roverlay: "add-policy default" not applied when not configured explicitly

• Status: RESOLVED FIXED
• Product: Portage Development

[Description Benda Xu 2016-02-15 13:28:57 UTC]

When there is a revbump, an assertion fails as:

Traceback (most recent call last):
   .... ....
  File "/usr/lib64/python3.4/site-packages/roverlay/overlay/pkgdir/packagedir_base.py", line 394, in package_try_replace
    assert package_info.overlay_addition_override is addition_override
AssertionError

Where package_info.overlay_addition_override is "None" and addition_override is 0.

package_info.overlay_addition_override is supposed to be set to 0 in PackageAdditionControlDefaultAction.  But that action is not added in the shipped package_rules:

MATCH:
   or
      * repo_name ,= r-forge
      * repo_name ,= rstan
ACTION:
   pass
ELSE:
   rename category s/^(?P<repo>[^-/]+)([-/].*)?$/sci-\g<repo>/
END;

It is needed write "add-policy default" explicitly to circumvent this bug:

MATCH:
   or
      * repo_name ,= r-forge
      * repo_name ,= rstan
ACTION:
   add-policy default  
ELSE:
   add-policy default
   rename category s/^(?P<repo>[^-/]+)([-/].*)?$/sci-\g<repo>/
END;

I guess this is not an intended behavior.

Reproducible: Always

[Comment 1 André Erdmann 2016-02-18 16:38:00 UTC]

Fixed in git:

https://gitweb.gentoo.org/proj/R_overlay.git/commit/?id=25f6d2967ec621ecdcd65d2beab405a357e870e4

[Comment 2 Benda Xu 2016-02-19 05:31:14 UTC]

Thanks André. I pulled the newest version to the roverlay vm.