Bug 573150 – =app-backup/burp-1.4.40: add librsync-2.0.0 support

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description lubos.pavlicek 2016-01-27 18:18:56 UTC]

burp is compatible with librsync-1.0.0 from version 1.4.34, see http://burp.grke.org/changelog.html
librsync-2.0.0 is binary compatible with librsync-1.0.0, see http://librsync.sourcefrog.net/md_NEWS.html

But app-backup/burp-1.4.40-r1 requested dependency "<net-libs/librsync-2.0"

In librsync-2.0.0 is bug in rs_search_for_block function, see https://github.com/librsync/librsync/issues/50 - burp segfaults with official version librync-2.0.0. Patch for librsync-2.0.0 is available at https://github.com/librsync/librsync/pull/59

Burp 1.4.40 is working with librync-2.0.0 after applying this patch, I tested on amd64 and x86.

Please, change dependency in app-backup/burp-1.4.40 ebuild, possible patch (also included support for x86):


--- burp-1.4.40-r1.ebuild       2016-01-17 18:01:01.000000000 +0100
+++ burp-1.4.40-r2.ebuild       2016-01-27 18:51:47.651214437 +0100
@@ -13,14 +13,14 @@

 LICENSE="AGPL-3"
 SLOT="0"
-KEYWORDS="~amd64"
+KEYWORDS="~amd64 ~x86"
 IUSE="acl afs ipv6 nls tcpd xattr"

 DEPEND="
        dev-libs/openssl:0
        dev-libs/uthash
        sys-libs/libcap
-       <net-libs/librsync-2.0
+       net-libs/librsync
        sys-libs/ncurses:0=
        sys-libs/zlib
        acl? ( sys-apps/acl )

[Comment 1 Amadeusz Żołnowski (RETIRED) 2016-01-27 20:21:23 UTC]

Thanks for reporting!

Please report librsync bug separately.

[Comment 2 Alessandro Calorì 2016-01-31 10:52:21 UTC]

I'm the maintainer of librsync. It is better to use ~net-libs/librsync-0.9.7 as dependency since librsync-1.0.0 breaks API compatibility with previous version.

[Comment 3 Amadeusz Żołnowski (RETIRED) 2016-07-02 21:35:38 UTC]

I have unblocked dependency on older librsync in burp-1.4.40-r4. I have fixed librsync version on 0.9.7 (as suggest by Alessandro) for older versions and revisions.