Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 569986 - app-editors/scite does not respect CXX
Summary: app-editors/scite does not respect CXX
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ervin Peters
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 577882
  Show dependency tree
 
Reported: 2015-12-28 15:25 UTC by Agostino Sarubbo
Modified: 2016-05-05 08:17 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
updated scite-3.6.2-r1 ebuild (scite-3.6.2-r1.ebuild,2.23 KB, text/plain)
2016-05-03 10:21 UTC, Ervin Peters
Details
updated scite-3.6.2 ebuild with proposed changes (scite-3.6.2.ebuild,2.21 KB, text/plain)
2016-05-04 08:05 UTC, Ervin Peters
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2015-12-28 15:25:41 UTC
This is an auto-filled bug because this package does not respect CXX.

example:
g++ -pthread -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/pango-1.0 
-I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/freetype2  --std=c++0x -DNDEBUG  -Wall -pedantic -DGTK -DSCI_LEXER -I ../include -I ../src -I ../lexlib    -O2 -march=haswell -mtune=haswell 
-msse4.2 -fno-stack-protector -c ../lexlib/Accessor.cxx

Portage 2.2.20.1 (python 3.4.3-final-0, default/linux/amd64/13.0, gcc-4.9.3, glibc-2.21-r1, 3.2.69-hardened-r11-xxxx-std-ipv6-64 x86_64)
=================================================================
System uname: Linux-3.2.69-hardened-r11-xxxx-std-ipv6-64-x86_64-Intel-R-_Xeon-R-_CPU_E3-1245_V2_@_3.40GHz-with-gentoo-2.2
KiB Mem:    32857376 total,  25530320 free
KiB Swap:          0 total,         0 free
sh bash 4.3_p39
ld ld di GNU (Gentoo 2.25.1 p1.1) 2.25.1
distcc 3.2rc1 x86_64-pc-linux-gnu [disabled]
app-shells/bash:          4.3_p39::gentoo
dev-java/java-config:     2.2.0::gentoo
dev-lang/perl:            5.20.2::gentoo
dev-lang/python:          2.7.10::gentoo, 3.4.3::gentoo
dev-util/cmake:           2.8.12.2-r1::gentoo
sys-apps/baselayout:      2.2::gentoo
sys-apps/openrc:          0.17::gentoo
sys-apps/sandbox:         2.6-r1::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69::gentoo
sys-devel/automake:       1.11.6-r1::gentoo, 1.14.1::gentoo, 1.15::gentoo
sys-devel/binutils:       2.25.1-r1::gentoo
sys-devel/gcc:            4.9.3::gentoo
sys-devel/gcc-config:     1.7.3::gentoo
sys-devel/libtool:        2.4.6::gentoo
sys-devel/make:           4.1-r1::gentoo
sys-kernel/linux-headers: 3.18::gentoo (virtual/os-headers)
sys-libs/glibc:           2.21-r1::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -Wformat -Werror=format-security -g0 -O2"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /etc/stunnel/stunnel.conf /opt/openfire/resources/security/ /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/easy-rsa /usr/share/gnupg/qualified.txt /var/bind"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.4/ext-active/ /etc/php/apache2-php5.5/ext-active/ /etc/php/apache2-php5.6/ext-active/ /etc/php/cgi-php5.4/ext-active/ /etc/php/cgi-php5.5/ext-active/ /etc/php/cgi-php5.6/ext-active/ /etc/php/cli-php5.4/ext-active/ /etc/php/cli-php5.5/ext-active/ /etc/php/cli-php5.6/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=native -Wformat -Werror=format-security -g0 -O2"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--with-bdeps y --keep-going y -1"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs collision-protect config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms sign split-log strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="it_IT.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu"
MAKEOPTS="-j8"
PKGDIR="/root/.pkg"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
USE="X acl amd64 berkdb bzip2 cairo cli consolekit cracklib crypt cxx dbus dri fortran gdbm gudev hwdb iconv icu ipv6 jpeg minizip mmx mmxext modules multilib ncurses nls nptl ogg opengl openmp pam pax_kernel pcre png policykit python qt3support qt4 readline seccomp session sse sse2 ssl tcpd unicode vorbis xattr zlib" ABI_X86="64" CPU_FLAGS_X86="mmx mmxext sse sse2" ELIBC="glibc" KERNEL="linux" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="am fil zh af ca cs da de el es et gl hu nb nl pl pt ro ru sk sl sv uk bg cy en eo fo ga he id ku lt lv mk ms nn sw tn zu ja zh_TW en_GB pt_BR ko zh_CN ar en_CA fi kk oc sr tr fa wa nds as be bn bn_BD bn_IN en_US es_AR es_CL es_ES es_MX eu fy fy_NL ga_IE gu gu_IN hi hi_IN is ka kn ml mr nn_NO or pa pa_IN pt_PT rm si sq sv_SE ta ta_LK te th vi ast dz km my om sh ug uz ca@valencia sr@ijekavian sr@ijekavianlatin sr@latin csb hne mai se es_LA fr_CA zh_HK br la no es_CR et_EE sr_CS bo hsb hy mn sr@Latn lb ne bs tg uz@cyrillic xh be_BY brx ca_XV dgo en_ZA gd kok ks ky lo mni nr ns pap ps rw sa_IN sat sd ss st sw_TZ ti ts ve mt ia az me tl ak hy_AM lg nso son ur_PK it fr nb nb_NO hr nan ur tk cs_CZ da_DK de_1901 de_CH en_AU lt_LT pl_PL sa sk_SK th_TH ta_IN tt sco ha mi ven ar_SY el_GR ro_RO ru_RU sl_SI uk_UA vi_VN ar_SY te_IN de_DE es_VE fa_IR fr_FR hu_HU id_ID it_IT ja_JP ka_GE nl_NL sr_BA sr_RS ca_ES fi_FI he_IL jv ru_gold yi eu_ES byn crh gez haw so tig tt@iqtelif wal wo ca_valencia kmr_Latn sid sr_Latn bg_BG ko_KR" NGINX_MODULES_HTTP="access auth_basic autoindex browser charset empty_gif fastcgi geo gzip limit_conn limit_req map memcached proxy referer rewrite scgi split_clients ssi upstream_ip_hash userid uwsgi addition auth_pam cache_purge dav dav_ext degradation echo fancyindex flv geoip gunzip gzip_static headers_more image_filter lua metrics mp4 naxsi perl push push_stream random_index realip secure_link security slowfs_cache spdy stub_status sub upload_progress upstream_check xslt auth_request mogilefs sticky" NGINX_MODULES_MAIL="imap pop3 smtp" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_4" QEMU_USER_TARGETS="aarch64 alpha arm armeb cris i386 m68k microblaze microblazeel mips mips64 mips64el mipsel mipsn32 mipsn32el or32 ppc ppc64 ppc64abi32 s390x sh4 sh4eb sparc sparc32plus sparc64 unicore32 x86_64" RUBY_TARGETS="ruby20 ruby21" USERLAND="GNU"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 1 Ervin Peters 2016-03-20 20:46:19 UTC
Could someone explain that issue or give me some hints?

It seems to me that the makefile patches in src_prepare should be modified.

ervin
Comment 2 Ian Delaney (RETIRED) gentoo-dev 2016-03-22 08:47:03 UTC
here's a giant hint
 emake V=1 CC="$(tc-getCC)" LDFLAGS="$(raw-ldflags)" LD="$(tc-getLD)" -C xen ${myopt}

toolchain-funcs.eclass
Admittedly, the description does not respect CXX lacks any clear or obvious meaning to my reckoning.
Comment 3 Ervin Peters 2016-05-03 10:21:37 UTC
Created attachment 433072 [details]
updated scite-3.6.2-r1 ebuild

OA issues anc cosmetic things fix see also bug #581220
Comment 4 Ian Delaney (RETIRED) gentoo-dev 2016-05-04 01:57:54 UTC
Ervin:

You have been caught here with the D vs. ED issue. For the sake of consistency, as with the bumped 3.6.5, can you set D -> ED in src_install. It seems both would be valid.

You have also set the deps that take slotting to :*
x11-libs/cairo has no alternate slots.  SLOT="0"   set for all.
x11-libs/gdk-pixbuf takes only SLOT="2"
x11-libs/pango also is not slotted;     SLOT="0"   set for all.
Given no competition I can see no need for the addition of the ":*".
You appear to have blindly added it to any and all.

Also there in no need to revbump.  The change to "respect CXX"xxx amounts to a build issue and warrants no revbump.
Comment 5 Sam Jorna (wraeth) gentoo-dev 2016-05-04 02:37:03 UTC
In addition to Ian's comment 4, there is a dependency listed in DEPEND that does not need to be there due to being included in the @system set (specifically, sys-apps/sed). This is known as an "Implicit System Dependency" [0]. This should be removed. I missed this when I was reviewing bug 581220.

If you can fix this in the ebuild here, we will fix the other ebuilds accordingly when we commit this.

So in summary:

 - x11-libs/cairo does not need a SLOT operator
 - x11-libs/gdk-pixbuf does not need a SLOT operator
 - x11-libs/pango does not need a SLOT operator

 - x11-libs/gtk+ should have a "rebuild-on-change" operator (x11-libs/gtk+:2=)

 - sys-apps/sed should be removed from DEPEND

Thanks!
Comment 6 Sam Jorna (wraeth) gentoo-dev 2016-05-04 02:39:10 UTC
Sigh, always forgetting my references... :D

Implicit System Dependencies:

[0] https://devmanual.gentoo.org/general-concepts/dependencies/#implicit-system-dependency
Comment 7 Ervin Peters 2016-05-04 08:05:06 UTC
Created attachment 433190 [details]
updated scite-3.6.2 ebuild with proposed changes

Thanks for your advice. I changed it and it compiles fine. I do not yet really understand why all this details, e.g. why to recompile scite in case of an updated gtk+, but as long as it works it is ok.

As you might have recognized this ebuild should work for nearly all scite versions from 3.5.5 on.

ervin
Comment 8 Ian Delaney (RETIRED) gentoo-dev 2016-05-05 08:17:22 UTC
(In reply to Ervin Peters from comment #7)
\
> Thanks for your advice. I changed it and it compiles fine. I do not yet
> really understand why all this details, e.g. why to recompile scite in case
> of an updated gtk+, but as long as it works it is ok.
> 

Well you may not understand fully, just accept the deps of this package under the rules and flow of slotting make it complex.   These steps are making the ebuild consistent with the complex rules of ebuild writing.  There is much documentation available in gentoo which can further inform if you care to pursue.

> As you might have recognized this ebuild should work for nearly all scite
> versions from 3.5.5 on.
> 
> ervin

Thank you for your contribution.

commit 2690da7b461c7042a1cfbb033462a62f679611ca
Author: Ian Delaney <idella4@gentoo.org>
Date:   Thu May 5 14:39:14 2016 +0800

    app-editors/scite: fixes to vn. 3.6.2 sourced from gentoo bug
    
    - inherit toolchain-funcs eclass to ensure the build to 'respect CXX',
    - add slot operators to deps requiring them (glib, gtk+, lua)
    - removed dep sed from deps (set in @system)
    fixes the gentoo bug
    
    Gentoo-bug: #Bug 569986