Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 568874 - net-p2p/classified-ads calls qmake directly
Summary: net-p2p/classified-ads calls qmake directly
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ian Delaney (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qtbindir
  Show dependency tree
 
Reported: 2015-12-20 14:48 UTC by Michael Palimaka (kensington)
Modified: 2015-12-28 05:41 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Palimaka (kensington) gentoo-dev 2015-12-20 14:48:03 UTC 
qmake is called directly in src_test, but there's no guarantee to which version of Qt that will point. Please inherit qmake-utils and call $(qt4_get_bindir)/qmake instead.
Comment 1 Antti Järvinen 2015-12-20 15:25:30 UTC 
Good point, easy fix is underway..
Comment 2 Antti Järvinen 2015-12-20 20:55:41 UTC 
discussion and fix attempt at:
https://github.com/gentoo/gentoo/pull/500
Comment 3 Michael Palimaka (kensington) gentoo-dev 2015-12-27 19:09:40 UTC 
The changes were merged by Ian, so this is now fixed.
Comment 4 Ian Delaney (RETIRED) gentoo-dev 2015-12-28 05:41:47 UTC 
commit 537312b16550a72b3881d79377a670bc3b29e7e8
Author: Antti Jarvinen <antti.jarvinen@katiska.org>
Date:   Sat Dec 26 03:47:16 2015 +0200

    net-p2p/classified-ads: Bug 568874 - use correct qmake version
    
    Due to comments at https://github.com/gentoo/gentoo/pull/500
    simplified src_test somewhat. Tried out with sandbox and
    without, with failing test case and all-passing case:
    seems to work.
    

commit 6575f8afba024acbe3fec867d0368fab7ac53eb8
Author: Antti Jarvinen <antti.jarvinen@katiska.org>
Date:   Tue Dec 22 19:57:11 2015 +0200

    net-p2p/classified-ads: Fix bug 568874 - use correct qmake version
    
    Changes due to comments at https://github.com/gentoo/gentoo/pull/500