566480 – java-utils-2.eclass should not access INSOPTIONS, DESTTREE, INSDESTTREE

Bug 566480 - java-utils-2.eclass should not access INSOPTIONS, DESTTREE, INSDESTTREE

Summary: java-utils-2.eclass should not access INSOPTIONS, DESTTREE, INSDESTTREE

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	Normal QA (vote)
Assignee:	Java team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	566478 582966
	Show dependency tree

Reported:	2015-11-22 15:36 UTC by Ulrich Müller
Modified:	2016-05-14 09:55 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ulrich Müller gentoo-dev

2015-11-22 15:36:54 UTC

Please replace all assignments of INSOPTIONS by insopts() calls.

See tracker bug 566478 for an explanation and policy references.

Comment 1 Michał Górny archtester

2016-05-14 07:31:30 UTC

Let's extend this bug to DESTTREE and INSDESTTREE since all of them are most likely to be fixed together.

Comment 2 Michał Górny archtester

2016-05-14 09:55:12 UTC

commit 9f4fe74fbc922f3a1c0546116a777a227c5baa83
Author: Michał Górny <mgorny@gentoo.org>
Date:   Sat May 14 11:15:28 2016

    java-utils-2.eclass: DESTTREE querying -> /usr, #566480

commit 6b77d8b80c35f488052922ccf51925c4c56d9a37
Author: Michał Górny <mgorny@gentoo.org>
Date:   Sat May 14 11:14:31 2016

    java-utils-2.eclass: DESTTREE assignment -> into, #566480

commit 9a32b4351ddbd4ed1da939feddb8925ab18c1fb7
Author: Michał Górny <mgorny@gentoo.org>
Date:   Sat May 14 11:11:12 2016

    java-utils-2.eclass: Use insinto & insopts instead of vars, #566480
    
    Replace INSDESTTREE and INSOPTIONS internal variable references with
    correct calls to insinto & insopts, using a subshell to scope them.