Bug 563202 – Show EAPI in eshowkw

• Status: RESOLVED FIXED
• Product: Portage Development

[Description Justin Lecher (RETIRED) 2015-10-16 09:19:00 UTC]

Please add a column showing the EAPI to eshowkw

[Comment 1 Denis Romanchuk 2015-11-14 08:56:14 UTC]

Hello gentoo community, does anybody work on this task? I have draft working version of it, so I could test, clean up the code and put on review if you don't mind.

[Comment 2 Brian Dolbec (RETIRED) 2015-11-14 15:19:39 UTC]

That would be awesome, thank you

[Comment 3 Denis Romanchuk 2015-11-16 04:54:30 UTC]

Created attachment 417074 [details, diff]
Add eapi to the eshowkw

Actually this table isn't completely scalable. It's assumed that slot column will be last in the additional field, so that it can be filled with extra spaces in case slot length isn't of length one(you can find it by looking at -1 comment of author). I've added eapi to the first column of the additional field just because of that and when eapi 10 will come, the alignment will be broken :). To make it extensible in this way it requires changes to the logic of how table is drawn.

[Comment 4 Denis Romanchuk 2015-11-16 05:54:54 UTC]

Created attachment 417078 [details, diff]
Add eapi to the eshowkw2

Opps :)

[Comment 5 Justin Lecher (RETIRED) 2015-11-16 07:57:29 UTC]

(In reply to Denis Romanchuk from comment #4)
> Created attachment 417078 [details, diff] [details, diff]
> Add eapi to the eshowkw2
> 
> Opps :)

Works nicely!! Thanks. How about adding coloring of banned and deprecated EAPIs?

[Comment 6 Denis Romanchuk 2015-11-16 08:39:28 UTC]

Sure, will try to do this asap.

[Comment 7 Paul Varner (RETIRED) 2015-11-16 17:46:35 UTC]

Justin, if you are happy with the changes and are willing to do so, go ahead and commit them to the gentoolkit repository master branch

https://gitweb.gentoo.org/proj/gentoolkit.git/

[Comment 8 Denis Romanchuk 2015-11-17 09:17:10 UTC]

Created attachment 417186 [details, diff]
Add eapi to the eshowkw

[Comment 9 Justin Lecher (RETIRED) 2015-11-17 09:29:24 UTC]

(In reply to Denis Romanchuk from comment #8)
> Created attachment 417186 [details, diff] [details, diff]
> Add eapi to the eshowkw

Great work, Do you like to send a git format-patch so that I can record your author contribution in the git repo?

[Comment 10 Denis Romanchuk 2015-11-17 10:07:34 UTC]

Created attachment 417190 [details, diff]
Add eapi to the eshowkw patch

It would be great :)

[Comment 11 Justin Lecher (RETIRED) 2015-11-17 10:21:00 UTC]

commit 95b5655ae01c0185a9539d1921509277fa778102
Author: Denis Romanchuk <[e-mail]>
Date:   Mon Nov 16 06:01:21 2015 +0200
    
    Add eapi column to the eshowkw
    
    Signed-off-by: Justin Lecher <[e-mail]>

   https://gitweb.gentoo.org/proj/gentoolkit.git/commit/?id=95b5655ae01c0185a9539d1921509277fa778102

[Comment 12 Justin Lecher (RETIRED) 2015-11-17 10:21:46 UTC]

Created attachment 417194 [details]
example output

[Comment 13 Michael Orlitzky 2017-01-17 18:37:25 UTC]

Isn't this done, or are there still features missing?

[Comment 14 Paul Varner (RETIRED) 2017-01-18 20:42:47 UTC]

It was completed and released in gentoolkit-0.3.1