Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 56264 - ebuild: games-sports/bygfoot
Summary: ebuild: games-sports/bygfoot
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All All
: Normal enhancement
Assignee: Gentoo Games
URL: http://bygfoot.sourceforge.net
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-06 11:29 UTC by Laurent Duperval
Modified: 2005-06-08 13:41 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
bygfoot-1.4.0.ebuild proposal (bygfoot-1.4.0.ebuild,2.12 KB, text/plain)
2004-07-06 18:41 UTC, Duarte Loreto
Details
New ebuild version with dev requested fixes (bygfoot-1.4.0.ebuild,1.16 KB, text/plain)
2004-07-08 15:25 UTC, Duarte Loreto
Details
code patch needed for 1st time execution (per user) (1.4.0-support-files-path-gentoo.diff,395 bytes, patch)
2004-07-08 15:28 UTC, Duarte Loreto
Details | Diff
Official patch to fix issue where with clashing keys (patch-bygfoot-1.4.2-1-2-keys-bug,2.91 KB, patch)
2004-07-15 18:42 UTC, Duarte Loreto
Details | Diff
bygfoot-1.4.2 ebuild (upgraded ans new version is out) (bygfoot-1.4.2.ebuild,1.22 KB, text/plain)
2004-07-15 18:47 UTC, Duarte Loreto
Details
Ebuild for 1.5.1 (bygfoot-1.5.1.ebuild,1.22 KB, text/plain)
2004-08-07 08:05 UTC, Laurent Duperval
Details
The 1-2 keys patch (patch-bygfoot-1.5.1-1-2-keys-bug,2.50 KB, patch)
2004-08-07 08:06 UTC, Laurent Duperval
Details | Diff
ebuild for 1.4.3 release (bygfoot-1.4.3.ebuild,1.16 KB, text/plain)
2004-08-20 16:41 UTC, Duarte Loreto
Details
ebuild for 1.5.2 (bygfoot-1.5.2.ebuild,1.16 KB, application/octet-stream)
2004-08-20 19:21 UTC, Laurent Duperval
Details
bygfoot-1.6.1 ebuild proposal (bygfoot-1.6.1.ebuild,1.44 KB, text/plain)
2004-09-18 07:43 UTC, Duarte Loreto
Details
Ebuild for bygfoor 1.8.1 (bygfoot-1.8.1.ebuild,1.09 KB, text/plain)
2005-04-23 17:52 UTC, Laurent Duperval
Details
bygfoot-1.8.1.ebuild update after Chris's comments. (bygfoot-1.8.1.ebuild,941 bytes, text/plain)
2005-06-04 04:36 UTC, Priit Laes (IRC: plaes)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Duperval 2004-07-06 11:29:13 UTC
Yeah, Euro 2004 is over, but the Beautifule Game remains in our hearts and minds all times. Any football fans willing to make an ebuild for this game?

L
Comment 1 Duarte Loreto 2004-07-06 18:40:01 UTC
OK... I'm not a gentoo developer and I still have a lot to learn...

Here goes my attempt to make an ebuild from scratch. It checks for dependencies, compiles, installs.

It adds a .desktop file that is created inside the ebuild (the Devs might hate this... I trully think that every user app should create an entry...).

The .desktop has a parameter to start up the game that is needed because it doesn't seem to be able to find the support files. I'm not sure if I did something wrong on the compile or it really is like this.

Hope it helps someone... :)

Be Happy!
Duarte "HappyGuy" Loreto
Comment 2 Duarte Loreto 2004-07-06 18:41:36 UTC
Created attachment 34890 [details]
bygfoot-1.4.0.ebuild proposal
Comment 3 Mr. Bones. (RETIRED) gentoo-dev 2004-07-06 19:02:54 UTC
Comments:

Use the standard header
needs an IUSE
no need to install COPYING
use insinto, doins for the icon
use make_desktop_entry for the desktop entry (inherit eutils)

If the -d is required for the program to run a patch needs to be applied so
it defaults to that location.
Comment 4 Duarte Loreto 2004-07-08 15:24:28 UTC
Sorry for delay returning to this. My daytime job and having to mess with C code (that I understand only slightly as I'm a Java coder) made me take a while to do things better.
I also appologize for not reading ebuild documentation and making the previous errors. repoman full now only complains about missing Changelog and a xml file and the header. I can't understand why it complains on the header, though.

Attached are a new ebuild (replacing old attachment) and a diff (new attachment) that patches the source to look for support files also where gentoo places it besides the (already present) local dir and home dir. After 1st run the game copies the files to home dir, so the patch becomes useless, anyway.

Hope this is OK now :)
Comment 5 Duarte Loreto 2004-07-08 15:25:41 UTC
Created attachment 35027 [details]
New ebuild version with dev requested fixes
Comment 6 Duarte Loreto 2004-07-08 15:28:27 UTC
Created attachment 35028 [details, diff]
code patch needed for 1st time execution (per user)

Code patch to add to support_files search path the place where they really are
placed by gentoo games installation.
Withouth this patch, 1st bygfoot execution fails as the files are not found.
After 1st sucessfull execution, as the files are copied to ~/.bygfoot, there is
no longer a problem
Comment 7 Duarte Loreto 2004-07-15 18:42:38 UTC
Created attachment 35519 [details, diff]
Official patch to fix issue where with clashing keys

This fixes an issue that prevented introduction of values 1 and 2 into team
structure as this clashed with the usage of keys 1 and 2 for other
functionality. Other functionality can now be accessed with q and w, being 1
and 2 now introducible into team structure (i.e. 424 as 4 defence, 2 medium and
4 advance).
Official patch is available as tar.bz2 in sf.net but I don't know how to
download and use the patch so I added it into bygfoot/files and use it from
there on the ebuild
Comment 8 Duarte Loreto 2004-07-15 18:47:38 UTC
Created attachment 35520 [details]
bygfoot-1.4.2 ebuild (upgraded ans new version is out)

New ebuild as new version is out. Now uses two patches. The previous one that
allowed for a correct 1st execution and a new one, downloaded from the official
page (see attachment 35519 [details, diff]).
Sorry I took some days (7) to make this (and missed 1.4.1) but my job is taking
much more of my time than my wife would like... So even less time available for
computer...
Comment 9 Charles Goodwin 2004-08-03 08:48:22 UTC
Ping... can this go into portage yet.  Is there any reason it shouldn't?
Comment 10 Chris Gianelloni (RETIRED) gentoo-dev 2004-08-03 08:53:46 UTC
This is not a web forum.  There is no reason to ping, bump, TTT, or any other nonsense.  Bugs don't disappear...

Thanks...
Comment 11 Laurent Duperval 2004-08-07 08:05:27 UTC
Created attachment 36958 [details]
Ebuild for 1.5.1

This is for the latest development build.
Comment 12 Laurent Duperval 2004-08-07 08:06:10 UTC
Created attachment 36959 [details, diff]
The 1-2 keys patch
Comment 13 Laurent Duperval 2004-08-07 08:08:37 UTC
The 1st time execution patch is still needed, but the name of it has to be changed (either to a generic name, or using the 1.5.1 version number in it). I'm not adding it, since it's the same thing as the patch provided. Just make a copy and give it the proper name, or change the name in the ebuild. I'm not sure what best practices are.

This is a really cool game and I hope it gets added to Gentoo Games eventually.
Comment 14 Duarte Loreto 2004-08-20 16:41:25 UTC
Created attachment 37830 [details]
ebuild for 1.4.3 release
Comment 15 Duarte Loreto 2004-08-20 16:45:08 UTC
Ebuild for 1.4.3 added. This release includes the clashing keys patch, making it obsolete.
Note that the "The 1-2 keys patch" that is not marked as obsolete still applies to the 1.5.1 release. If an ebuild is provided to the 1.5.2 development release it will also make that patch obsolete.
Comment 16 Laurent Duperval 2004-08-20 19:21:04 UTC
Created attachment 37839 [details]
ebuild for 1.5.2

This still uses the 1.5.1 path patch. I only did basic testing. I played the
beginning of a game and it behaves correctly.
Comment 17 Duarte Loreto 2004-09-18 07:43:54 UTC
Created attachment 39856 [details]
bygfoot-1.6.1 ebuild proposal

Hello!

I don't know if it is wrth it to keep updating this... Anyway... A new stable
release has been made (1.6.0 was not quite stable ;)

The 1.4.0 patch for 1st time execution is still applicable. This was mainly an
ebuild bump from the 1.4.3 one.

Added a pkg_postinst() to warn people that are using these ebuilds that the
savegames from 1.4.x are not compatible with the 1.6.x releases so they will
have to start new games. It was a nicety just to say that I added value to the
previous ebuild. ;)
Comment 18 Claes Mogren 2005-02-01 06:46:38 UTC
Bygfoot 1.8.0 is released, if anyone is interested. :')
Comment 19 Mr. Bones. (RETIRED) gentoo-dev 2005-02-02 23:31:46 UTC
Someone want to update for 1.8.0?
Comment 20 Laurent Duperval 2005-02-03 06:05:02 UTC
I'm trying but it doesn't copy the pixmap images properly. My C is pretty rusty so I'm not sure why yet.

L
Comment 21 Laurent Duperval 2005-04-23 17:52:30 UTC
Created attachment 57064 [details]
Ebuild for bygfoor 1.8.1

I based it on the 1.6.3 ebuild. I didn't mess with many things. The patches
that were needed for first time execution are no longer needed. Directory names
had to be modified for it to work properly but now, it's all good. On my
machine, anyway... :-)

L
Comment 22 Chris Gianelloni (RETIRED) gentoo-dev 2005-05-04 18:51:24 UTC
Comments:

- Your src_compile does the same as the default when using games.eclass, so you don't need it
- Don't use cp -R, but rather insinto "${GAMES_DATADIR}/${PN}" ; doins -r
- You can add the README cp to the same line as the data
- Use doicon instead of insinto /usr/share/pixmaps ; doins
- Actually, use newicon and rename it to the name of the package
- Only specify the filename for the icon on make_desktop_entry, as it'll be in the right place
Comment 23 Priit Laes (IRC: plaes) 2005-06-04 04:12:56 UTC
Ebuild works fine, but when I try to use use "Start Bygfoot Online update", the
game crashes with:

amd@dma ~ $ LC_ALL="C" bygfoot

** (bygfoot:8407): WARNING **: error message: Failed to execute child process
"bygfoot-update-gui" (No such file or directory)

Seems like this executable is missing.
Comment 24 Priit Laes (IRC: plaes) 2005-06-04 04:36:38 UTC
Created attachment 60571 [details]
bygfoot-1.8.1.ebuild update after Chris's comments.

Cleaned up the ebuild, now it install's the bygfoot-updater thingy also.

The games pixmap doesn't get installed. Didn't have time to figure out right
syntax.

Have fun :D
Comment 25 Chris Gianelloni (RETIRED) gentoo-dev 2005-06-08 13:41:15 UTC
Added to portage