Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 558080 - media-libs/gst-plugins-good:0.10 fails to build with clang
Summary: media-libs/gst-plugins-good:0.10 fails to build with clang
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: GStreamer package maintainers
URL: http://svnweb.freebsd.org/ports/head/...
Whiteboard:
Keywords: Inclusion, PATCH
Depends on:
Blocks: systemwide-clang
  Show dependency tree
 
Reported: 2015-08-18 11:51 UTC by Julian Ospald
Modified: 2016-06-02 06:00 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
1439898534-install-media-libs_gst-plugins-good-0.10.31-r1:0.10::gentoo.out (1439898534-install-media-libs_gst-plugins-good-0.10.31-r1:0.10::gentoo.out,403.28 KB, text/plain)
2015-08-18 11:51 UTC, Julian Ospald
Details
cave-info.txt (cave-info.txt,23.21 KB, text/plain)
2015-08-18 11:52 UTC, Julian Ospald
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Ospald 2015-08-18 11:51:03 UTC
Created attachment 409350 [details]
1439898534-install-media-libs_gst-plugins-good-0.10.31-r1:0.10::gentoo.out

/var/tmp/paludis/media-libs-gst-plugins-good-0.10.31-r1/work/gst-plugins-good-0.10.31/gst/goom/mmx.c:132:5: error: clobbers must be last on the x87 stack
    emms ();
    ^
/var/tmp/paludis/media-libs-gst-plugins-good-0.10.31-r1/work/gst-plugins-good-0.10.31/gst/goom/mmx.h:723:38: note: expanded from macro 'emms'
#define emms() __asm__ __volatile__ ("emms"::: \
                                     ^
/var/tmp/paludis/media-libs-gst-plugins-good-0.10.31-r1/work/gst-plugins-good-0.10.31/gst/goom/mmx.c:282:3: error: clobbers must be last on the x87 stack
  emms ();
Comment 1 Julian Ospald 2015-08-18 11:52:25 UTC
Created attachment 409352 [details]
cave-info.txt
Comment 2 Mart Raudsepp gentoo-dev 2015-10-04 01:24:57 UTC
Does gst-plugins-good-1.4.5 work?
It is unlikely that any fix will happen to 0.10 - it is not maintained upstream and Gentoo goal is to get rid of all users of 0.10 slots, and have everything use the 1.0 slots instead. As such, we would need to wait the cleansing of 0.10, or a straightforward patch to fix it, possibly a cherry-pick from gstreamer git commits, but from interested parties - I'm only interested if :1.0 is affected.
If you have a clean patch, feel free to apply it yourself carefully.
Comment 3 Julian Ospald 2015-10-04 21:48:16 UTC
(In reply to Mart Raudsepp from comment #2)
> Does gst-plugins-good-1.4.5 work?

yes
Comment 4 Pacho Ramos gentoo-dev 2015-10-05 20:02:49 UTC
This is the freebsd patch for this, can you try it? If it works for your, feel free to go ahead and commit:
http://svnweb.freebsd.org/ports/head/multimedia/gstreamer-plugins-good/files/patch-gst_goom_mmx.h?revision=311892&view=markup
Comment 5 Julian Ospald 2015-10-05 22:23:11 UTC
(In reply to Pacho Ramos from comment #4)

yes, that patch works
Comment 6 Fabio Scaccabarozzi 2015-12-13 20:35:16 UTC
I have verified that the patch applies cleanly and works properly: gst-plugins-good-0.10.31-r1 compiles fine and passes tests both with clang-3.7.0 and gcc-4.9.3.
Comment 7 Austin English (RETIRED) gentoo-dev 2016-06-02 06:00:22 UTC
(In reply to Fabio Scaccabarozzi from comment #6)
> I have verified that the patch applies cleanly and works properly:
> gst-plugins-good-0.10.31-r1 compiles fine and passes tests both with
> clang-3.7.0 and gcc-4.9.3.

Works for me as well.


(In reply to Pacho Ramos from comment #4)
> This is the freebsd patch for this, can you try it? If it works for your,
> feel free to go ahead and commit:
> http://svnweb.freebsd.org/ports/head/multimedia/gstreamer-plugins-good/files/
> patch-gst_goom_mmx.h?revision=311892&view=markup

I don't know why Julian didn't commit this, but now that I can, I went ahead and did so:
https://github.com/gentoo/gentoo/commit/4231143b2a29252a293bdac1fcfb90d08dd3fb86