Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 555144 - =dev-java/fop-2.0: naming convention of binary causes many packages not to find it
Summary: =dev-java/fop-2.0: naming convention of binary causes many packages not to fi...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Java (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Java team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 554762 554796 554798
  Show dependency tree
 
Reported: 2015-07-17 08:02 UTC by Patrice Clement (RETIRED)
Modified: 2015-07-17 13:02 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrice Clement (RETIRED) gentoo-dev 2015-07-17 08:02:46 UTC
The naming convention we came up with in bug 553392 i.e. "fop-2" turns out not to be a good idea. Many packages relying on fop can't find the binary at compile/run time and hence, don't work.

Reproducible: Always
Comment 1 Patrice Clement (RETIRED) gentoo-dev 2015-07-17 08:10:05 UTC
The following patch would mend the problem:

--- fop-2.0.ebuild      2015-07-11 17:58:30.000000000 +0000
+++ fop-2.0-r1.ebuild   2015-07-17 09:07:12.686000000 +0000
@@ -18,11 +18,9 @@

 KEYWORDS="amd64 x86 ppc ppc64 ~amd64-linux ~x86-linux ~ppc-macos ~x86-macos ~sparc-solaris ~x86-solaris"
 LICENSE="Apache-2.0"
-SLOT="2"
+SLOT="0"
 IUSE=""

-MY_P="${PN}-${SLOT}"
-
 # Tests are broken even in 2.0
 RESTRICT="test"

@@ -108,8 +106,7 @@
                build/${PN}-sandbox.jar \
                build/${PN}-hyph.jar

-       # Doesn't support everything upstream launcher does...
-       java-pkg_dolauncher ${MY_P} --main org.apache.fop.cli.Main
+       java-pkg_dolauncher ${PN} --main org.apache.fop.cli.Main

        dodoc NOTICE README

fod doesn't need SLOTting anymore. It was set up back then when fop-1.x versions were still in the tree. We can do away with the SLOT now.
Comment 2 James Le Cuirot gentoo-dev 2015-07-17 09:39:38 UTC
I agree with this solution. app-misc/freemind will need adjusting as it depends explicitly on SLOT 2 but the other rdeps are not Java-based so the SLOT wasn't strictly required.
Comment 3 Patrice Clement (RETIRED) gentoo-dev 2015-07-17 13:02:04 UTC
+*fop-2.0-r1 (17 Jul 2015)
+
+  17 Jul 2015; Patrice Clement <monsieurp@gentoo.org> +fop-2.0-r1.ebuild:
+  Set SLOT back to 0. Create launcher using PN instead of PN-SLOT. Fix bug
+  555144.
+

+*freemind-1.0.1-r2 (17 Jul 2015)
+
+  17 Jul 2015; Patrice Clement <monsieurp@gentoo.org> +freemind-1.0.1-r2.ebuild:
+  Adjust fop SLOT. Fix bug 555144.
+

Thanks Chewi for peer-reviewing the patch.