all iptables builds fails to be builded unless a proper patch is applied to gentoo-dev-sources Reproducible: Always Steps to Reproduce: emerge iptables Actual Results: ... gcc -O3 -march=athlon-tbird -mcpu=athlon-tbird -pipe -fomit-frame-pointer -fno-stack-protector -Iinclude -Wall -Wunused -I/usr/src/linux/include -DIPTABLES_VERSION=\"1.2.9\" -fPIC -o extensions/libipt_recent_sh.o -c extensions/libipt_recent.c In file included from include/libiptc/libiptc.h:6, from include/iptables.h:5, from extensions/libipt_recent.c:8: /usr/src/linux/include/linux/netfilter_ipv4/ip_tables.h:255: warning: no semicolon at end of struct or union /usr/src/linux/include/linux/netfilter_ipv4/ip_tables.h:255: error: syntax error before '*' token /usr/src/linux/include/linux/netfilter_ipv4/ip_tables.h:259: error: syntax error before '}' token /usr/src/linux/include/linux/netfilter_ipv4/ip_tables.h:339: warning: type defaults to `int' in declaration of `DECLARE_MUTEX' /usr/src/linux/include/linux/netfilter_ipv4/ip_tables.h:339: warning: parameter names (without types) in function declaration /usr/src/linux/include/linux/netfilter_ipv4/ip_tables.h:339: warning: `DECLARE_MUTEX' declared `static' but never defined make: *** [extensions/libipt_recent_sh.o] Error 1 ...
Created attachment 34385 [details, diff] patch which solves iptables build problem
Yes, but this isn't the final version of the patch that eventually made it into Linus's tree, right? Care to post that patch?
Created attachment 34391 [details, diff] another patch which seems to be accepted in mainstream There you go. I assume you are reffering to the patch posted in message http://marc.theaimsgroup.com/?l=linux-kernel&m=108757933919370&w=2. In reply http://marc.theaimsgroup.com/?l=linux-kernel&m=108767177813516&w=2 seems to be accepted by kernel maintainers.
patch added to 2.6.7-r7 release
