The daemon component need a service file. Quick google found one here: https://github.com/ArchAssault-Project/archassault/blob/master/packages/fwknop/fwknopd.service Not sure if there exists a proper alias to use in order to coordinate between the different firewall services available (e.g. iptables, shorewall, firewalld, etc,) Or for that matter if there even needs to be any coordination. Reproducible: Always
Thanks for the report! I already have the fwknopd systemd unit in my overlay. I was just waiting for a new fwknop version to come out to proceed everything in one go. There are some adjustments pending for the initscript as well. I will update this bug with the needed info soon.
Coacher, any idea on a time line for the next release?
(In reply to Ian Delaney from comment #2) > Coacher, any idea on a time line for the next release? Initially changelog mentioned May. Right now it is 2.6.7-pre1 so probably soon, but no concrete dates.
Created attachment 407114 [details] fwknopd.service Here we go.
Created attachment 407116 [details] fwknopd.init Also OpenRC initscript needs some love. @proxy-maint, please, update it as well.
Created attachment 407118 [details, diff] fwknopd.init.diff A diff of the required fwknopd.init changes.
fwknop-2.6.6.ebuild requires a one-line patch as well: --- a/var/portage/net-firewall/fwknop/fwknop-2.6.6.ebuild +++ b/net-firewall/fwknop/fwknop-2.6.6-r9999.ebuild @@ -1,6 +1,6 @@ # Copyright 1999-2015 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 -# $Header: /var/cvsroot/gentoo-x86/net-firewall/fwknop/fwknop-2.6.6.ebuild,v 1.2 2015/05/01 04:45:42 idella4 Exp $ +# $Header: $ EAPI=5 @@ -90,6 +90,7 @@ src_install() { if use server; then newinitd "${FILESDIR}/fwknopd.init" fwknopd newconfd "${FILESDIR}/fwknopd.confd" fwknopd + systemd_dounit "${FILESDIR}/fwknopd.service" systemd_newtmpfilesd "${FILESDIR}/fwknopd.tmpfiles.conf" fwknopd.conf fi
I've also submitted our systemd unit file and tmpfiles.d configuration upstream so it can be reused by others. See https://github.com/mrash/fwknop/pull/164.
(In reply to Coacher from comment #8) > I've also submitted our systemd unit file and tmpfiles.d configuration > upstream so it can be reused by others. > > See https://github.com/mrash/fwknop/pull/164. Wow, it got merged in less than 5 minutes. @proxy-maint, I think we shall wait for 2.6.7 release and if it is delayed for more than 1-2 weeks we proceed and add these files I've attached to the tree. What do you think?
I think we still need a time line for the next release. Anything over a week or 2 I am inclined to add the init scripts to the current version. It was your idea to await a next release.
Let's do as you suggest and make 2015-07-19 + 2 weeks a timeout date to add / utilise your 3 attached files.
(In reply to Ian Delaney from comment #11) > Let's do as you suggest and make 2015-07-19 + 2 weeks a timeout date to add > / utilise your 3 attached files. Looks good to me. Agreed. I just don't want to add files and then remove them as soon as 2.6.7 rolls out.
Having no clue to a future release makes for non management. Not acceptable. Adding the files makes decisive and makes a fix in preference to waiting for who knows what.
Created attachment 407870 [details] fwknopd.confd A minor comment update for clarity. Diff: --- a/net-firewall/fwknop/files/fwknopd.confd +++ b/net-firewall/fwknop/files/fwknopd.confd @@ -1,14 +1,14 @@ # /etc/conf.d/fwknopd: config file for /etc/init.d/fwknopd -# Path to the fwknopd config files +# Path to the fwknopd config directory (needs to be an absolute path). FWKNOPD_CONFDIR="/etc/fwknop" -# Options to pass to fwknopd daemon. +# Additional options to pass to fwknopd. # Refer to the fwknopd(8) manpage for more information. -FWKNOPD_OPTS="" +#FWKNOPD_OPTS="" # Pid file to use (needs to be an absolute path).
Created attachment 407872 [details, diff] fwknopd-2.6.6.ebuild.diff
*fwknop-2.6.6-r1 (29 Jul 2015) 29 Jul 2015; Ian Delaney <idella4@gentoo.org> +files/fwknopd.service, +fwknop-2.6.6-r1.ebuild, -fwknop-2.6.6.ebuild, files/fwknopd.confd, files/fwknopd.init: revbump; new script files added to equip for systemd, other script files edited from patches via bug #554690, remove defunct fwknop-2.6.6.ebuild to avoid any mixing of updated scripts
Everything looks good. Closing.
