Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 552780 - x11-libs/libXdmcp automagic dependency on dev-libs/libbsd
Summary: x11-libs/libXdmcp automagic dependency on dev-libs/libbsd
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 559062
  Show dependency tree
 
Reported: 2015-06-21 20:46 UTC by Justin Lecher (RETIRED)
Modified: 2015-12-24 16:12 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Lecher (RETIRED) gentoo-dev 2015-06-21 20:46:17 UTC 
After system cleaning

!!! existing preserved libs:
>>> package: dev-libs/libbsd-0.7.0
 *  - /usr/lib64/libbsd.so.0
 *  - /usr/lib64/libbsd.so.0.7.0
 *      used by /usr/lib64/libXdmcp.so.6.0.0 (x11-libs/libXdmcp-1.1.2)
Comment 1 Anthony Basile gentoo-dev 2015-12-24 14:00:26 UTC 
(In reply to Justin Lecher from comment #0)
> After system cleaning
> 
> !!! existing preserved libs:
> >>> package: dev-libs/libbsd-0.7.0
>  *  - /usr/lib64/libbsd.so.0
>  *  - /usr/lib64/libbsd.so.0.7.0
>  *      used by /usr/lib64/libXdmcp.so.6.0.0 (x11-libs/libXdmcp-1.1.2)

Yep.  I just hit this.  From the ChangeLog.

commit 66514a4af7eaa47e8718434356d7efce95e570cf
Author: Matthieu Herrb <matthieu.herrb@laas.fr>
Date:   Sun Aug 4 10:42:57 2013 +0200

    Use arc4random when available to produce the XDM-AUTHENTICATION1 key
    
    arc4random() and associated functions can be found in libbsd on
    GNU/Linux systems.
    
    Signed-off-by: Matthieu Herrb <matthieu.herrb@laas.fr>
    Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>


So I hit the opposite of an automagic dep, my system (using binpkgs only) didn't pull in libbsd.  From the configure.ac

# Checks for library functions.
AC_CHECK_LIB([bsd], [arc4random_buf])
AC_CHECK_FUNCS([srand48 lrand48 arc4random_buf])


which looks like an unconditional {R,}DEPEND on dev-libs/libbsd.  Can we add this to x11-libs/libXdmcp-1.1.2 which is being stabilized right now as of bug #559062.
Comment 2 Anthony Basile gentoo-dev 2015-12-24 14:04:22 UTC 
My suggestion follows.  Note libbsd is not slotted or subslotted, but just in case it is in the future, we should add :=

diff --git a/x11-libs/libXdmcp/libXdmcp-1.1.2.ebuild b/x11-libs/libXdmcp/libXdmcp-1.1.2.ebuild
index 3d3ef5b..75804ff 100644
--- a/x11-libs/libXdmcp/libXdmcp-1.1.2.ebuild
+++ b/x11-libs/libXdmcp/libXdmcp-1.1.2.ebuild
@@ -13,7 +13,8 @@ DESCRIPTION="X.Org X Display Manager Control Protocol library"
 KEYWORDS="~alpha amd64 arm ~arm64 ~hppa ~ia64 ~mips ppc ~ppc64 ~s390 ~sh ~sparc x86 ~ppc-aix ~amd64-fbsd ~x86-fbsd ~x64-freebsd ~x86-freebsd ~ia64-hpux ~x86-interix ~amd64-linux ~arm-linux ~x86-linux ~ppc-macos ~x64-macos ~x86-macos ~sparc-solaris ~sparc64-solaris ~x64-solaris ~x86-solaris ~x86-winnt"
 IUSE=""
 
-RDEPEND="x11-proto/xproto"
+RDEPEND="x11-proto/xproto
+       dev-libs/libbsd:="
 DEPEND="${RDEPEND}"
 
 pkg_setup() {
Comment 3 Manuel Rüger (RETIRED) gentoo-dev 2015-12-24 16:12:02 UTC 
commit 5e7152d0c55567a78234e625e01a15ce71824b50
Author: Manuel Rüger <mrueg@gentoo.org>
Date:   Thu Dec 24 17:11:24 2015 +0100

    x11-libs/libXdmcp: Add missing dependency on dev-libs/libbsd
    
    Thanks to Anthony Basile
    
    Gentoo-Bug: #552780
    
    Package-Manager: portage-2.2.26