Bug 552332 – java-pkg-2.eclass: java-pkg-2_supports-test() makes use of in-line python code to parse xml

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Patrice Clement 2015-06-16 21:20:46 UTC]

# @FUNCTION: java-pkg-2_supports-test
# @INTERNAL                    
# @DESCRIPTION:                
# test whether a build.xml has a test target.
                               
java-pkg-2_supports-test() {                                                                                                      
    python << EOF              
from xml.dom.minidom import parse
import sys                     
dom = parse("${1}")            
for elem in dom.getElementsByTagName('target'):
    if elem.getAttribute('name') == 'test':
            sys.exit(0)        
sys.exit(1)                    
EOF                            
    return $?                  
} 

As per bug 479838 and explained by mgorny, this shouldn't be allowed.

Reproducible: Always

[Comment 1 James Le Cuirot 2015-06-16 22:24:11 UTC]

Created attachment 405254 [details, diff]
java-pkg-2_supports-test.patch

How about this? Please ack and I'll get it merged.

[Comment 2 Patrice Clement 2015-06-17 05:01:08 UTC]

LGTM. Go ahead.

[Comment 3 James Le Cuirot 2015-06-17 09:48:25 UTC]

Merged.