Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 551626 - =sys-app/sysvinit-2.88-r7 fails to compile on armv7a-hardened-musl
Summary: =sys-app/sysvinit-2.88-r7 fails to compile on armv7a-hardened-musl
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo musl team
URL:
Whiteboard:
Keywords:
Depends on: 580958
Blocks: musl-porting
  Show dependency tree
 
Reported: 2015-06-09 23:01 UTC by Michael Jones
Modified: 2019-06-02 22:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Relevant part from upstream patch (sysvinit-2.88-musl.patch,266 bytes, patch)
2016-04-23 18:44 UTC, Felix Janda
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Jones 2015-06-09 23:01:37 UTC
This bug should be made a blocker of : https://bugs.gentoo.org/show_bug.cgi?id=430702

And assigned to blueness@gentoo.org

ymir sys-apps # zcat sysvinit-2.88-r7/temp/build.log.gz 
 * Package:    sys-apps/sysvinit-2.88-r7
 * Repository: gentoo
 * Maintainer: base-system@gentoo.org
 * USE:        arm elibc_musl kernel_linux userland_GNU
 * FEATURES:   preserve-libs sandbox userpriv usersandbox
>>> Unpacking source...
>>> Unpacking sysvinit-2.88dsf.tar.bz2 to /var/tmp/portage/sys-apps/sysvinit-2.88-r7/work
>>> Source unpacked in /var/tmp/portage/sys-apps/sysvinit-2.88-r7/work
>>> Preparing source in /var/tmp/portage/sys-apps/sysvinit-2.88-r7/work/sysvinit-2.88dsf ...
 * Applying sysvinit-2.86-kexec.patch ...
 [ ok ]
 * Applying sysvinit-2.86-shutdown-single.patch ...
 [ ok ]
 * Applying sysvinit-2.88-makefile.patch ...
 [ ok ]
 * Applying sysvinit-2.88-selinux.patch ...
 [ ok ]
 * Applying sysvinit-2.88-shutdown-h.patch ...
 [ ok ]
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/sys-apps/sysvinit-2.88-r7/work/sysvinit-2.88dsf ...
>>> Source configured.
>>> Compiling source in /var/tmp/portage/sys-apps/sysvinit-2.88-r7/work/sysvinit-2.88dsf ...
make -j10 -C src 
make: Entering directory '/var/tmp/portage/sys-apps/sysvinit-2.88-r7/work/sysvinit-2.88dsf/src'
armv7a-hardfloat-linux-musleabi-gcc -O2 -pipe -march=armv7-a -mfpu=vfpv3-d16 -mfloat-abi=hard -W -Wall -D_GNU_SOURCE  -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE   -c -o init.o init.c
armv7a-hardfloat-linux-musleabi-gcc -O2 -pipe -march=armv7-a -mfpu=vfpv3-d16 -mfloat-abi=hard -W -Wall -D_GNU_SOURCE  -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DINIT_MAIN -c -o init_utmp.o utmp.c
armv7a-hardfloat-linux-musleabi-gcc -O2 -pipe -march=armv7-a -mfpu=vfpv3-d16 -mfloat-abi=hard -W -Wall -D_GNU_SOURCE  -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE  -c -o halt.o halt.c
armv7a-hardfloat-linux-musleabi-gcc -O2 -pipe -march=armv7-a -mfpu=vfpv3-d16 -mfloat-abi=hard -W -Wall -D_GNU_SOURCE  -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE  -c -o ifdown.o ifdown.c
armv7a-hardfloat-linux-musleabi-gcc -O2 -pipe -march=armv7-a -mfpu=vfpv3-d16 -mfloat-abi=hard -W -Wall -D_GNU_SOURCE  -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE  -c -o hddown.o hddown.c
armv7a-hardfloat-linux-musleabi-gcc -O2 -pipe -march=armv7-a -mfpu=vfpv3-d16 -mfloat-abi=hard -W -Wall -D_GNU_SOURCE  -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE  -c -o utmp.o utmp.c
armv7a-hardfloat-linux-musleabi-gcc -O2 -pipe -march=armv7-a -mfpu=vfpv3-d16 -mfloat-abi=hard -W -Wall -D_GNU_SOURCE  -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE  -c -o shutdown.o shutdown.c
armv7a-hardfloat-linux-musleabi-gcc -O2 -pipe -march=armv7-a -mfpu=vfpv3-d16 -mfloat-abi=hard -W -Wall -D_GNU_SOURCE  -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE  -c -o dowall.o dowall.c
armv7a-hardfloat-linux-musleabi-gcc -O2 -pipe -march=armv7-a -mfpu=vfpv3-d16 -mfloat-abi=hard -W -Wall -D_GNU_SOURCE  -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE  -c -o runlevel.o runlevel.c
armv7a-hardfloat-linux-musleabi-gcc -O2 -pipe -march=armv7-a -mfpu=vfpv3-d16 -mfloat-abi=hard -W -Wall -D_GNU_SOURCE  -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -Wl,-O1 -Wl,--as-needed  killall5.c   -o killall5
runlevel.c: In function ‘main’:
runlevel.c:36:17: warning: statement with no effect [-Wunused-value]
runlevel.c:31:8: warning: unused parameter ‘argv’ [-Wunused-parameter]
In file included from ifdown.c:33:0:
/usr/include/sys/errno.h:1:2: warning: #warning redirecting incorrect #include <sys/errno.h> to <errno.h> [-Wcpp]
utmp.c: In function ‘write_wtmp’:
utmp.c:66:17: warning: unused variable ‘tv’ [-Wunused-variable]
utmp.c: In function ‘write_utmp’:
utmp.c:158:17: warning: unused variable ‘tv’ [-Wunused-variable]
utmp.c: In function ‘write_wtmp’:
utmp.c:66:17: warning: unused variable ‘tv’ [-Wunused-variable]
utmp.c: In function ‘write_utmp’:
utmp.c:158:17: warning: unused variable ‘tv’ [-Wunused-variable]
init.c: In function ‘console_stty’:
init.c:762:24: error: ‘CINTR’ undeclared (first use in this function)
init.c:762:24: note: each undeclared identifier is reported only once for each function it appears in
init.c:763:24: error: ‘CQUIT’ undeclared (first use in this function)
init.c:764:24: error: ‘CERASE’ undeclared (first use in this function)
init.c:765:24: error: ‘CKILL’ undeclared (first use in this function)
init.c:766:23: error: ‘CEOF’ undeclared (first use in this function)shutdown.c: In function ‘main’:
init.c:770:24: error: ‘CSTART’ undeclared (first use in this function)
init.c:771:24: error: ‘CSTOP’ undeclared (first use in this function)
shutdown.c:485:10: warning: variable ‘realuid’ set but not used [-Wunused-but-set-variable]
init.c:772:24: error: ‘CSUSP’ undeclared (first use in this function)

init.c:774:24: error: ‘CREPRINT’ undeclared (first use in this function)
init.c:775:24: error: ‘CDISCARD’ undeclared (first use in this function)
init.c:776:24: error: ‘CWERASE’ undeclared (first use in this function)
init.c:777:24: error: ‘CLNEXT’ undeclared (first use in this function)
armv7a-hardfloat-linux-musleabi-gcc -O2 -pipe -march=armv7-a -mfpu=vfpv3-d16 -mfloat-abi=hard -W -Wall -D_GNU_SOURCE  -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -Wl,-O1 -Wl,--as-needed  fstab-decode.c   -o fstab-decode
<builtin>: recipe for target 'init.o' failed
make: *** [init.o] Error 1
make: *** Waiting for unfinished jobs....
make: Leaving directory '/var/tmp/portage/sys-apps/sysvinit-2.88-r7/work/sysvinit-2.88dsf/src'
 * ERROR: sys-apps/sysvinit-2.88-r7::gentoo failed (compile phase):
 *   emake failed
 * 
 * If you need support, post the output of `emerge --info '=sys-apps/sysvinit-2.88-r7::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=sys-apps/sysvinit-2.88-r7::gentoo'`.
 * The complete build log is located at '/var/tmp/portage/sys-apps/sysvinit-2.88-r7/temp/build.log.gz'.
 * The ebuild environment file is located at '/var/tmp/portage/sys-apps/sysvinit-2.88-r7/temp/environment'.
 * Working directory: '/var/tmp/portage/sys-apps/sysvinit-2.88-r7/work/sysvinit-2.88dsf'
 * S: '/var/tmp/portage/sys-apps/sysvinit-2.88-r7/work/sysvinit-2.88dsf'


Reproducible: Always
Comment 1 Anthony Basile gentoo-dev 2015-06-10 10:40:03 UTC
The following should be checked and upstreamed

https://gitweb.gentoo.org/proj/hardened-dev.git/tree/sys-apps/sysvinit/files/sysvinit-2.88-musl.patch?h=musl
Comment 2 Felix Janda 2015-06-15 18:47:10 UTC
Fixed in upstream svn:

http://svn.savannah.nongnu.org/viewvc?view=rev&root=sysvinit&revision=135
Comment 3 Felix Janda 2016-04-23 18:44:05 UTC
Created attachment 431726 [details, diff]
Relevant part from upstream patch
Comment 4 Anthony Basile gentoo-dev 2016-05-14 13:51:06 UTC
(In reply to Felix Janda from comment #3)
> Created attachment 431726 [details, diff] [details, diff]
> Relevant part from upstream patch

this is fixed in 2.88-r9 which I hope to have stabilized soon.
Comment 5 Felix Janda 2016-07-26 06:14:39 UTC
Indeed, sys-apps/sysvinit-2.88-r9 works and is now stable on all musl relevant archs. So this bug can be closed.
Comment 6 Joshua Kinard gentoo-dev 2019-06-02 22:45:07 UTC
Closing per Comment #5.