551154 – gnome2.eclass: 'nonfatal elibtoolize' is meaningless

Bug 551154 - gnome2.eclass: 'nonfatal elibtoolize' is meaningless

Summary: gnome2.eclass: 'nonfatal elibtoolize' is meaningless

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Linux Gnome Desktop Team

URL:
Whiteboard:
Keywords:	Inclusion

Depends on:
Blocks:	bad-nonfatal
	Show dependency tree

Reported:	2015-06-04 08:54 UTC by Michał Górny
Modified:	2015-07-09 15:42 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2015-06-04 08:54:50 UTC

gnome2_src_prepare() {
#[...]
    # Run libtoolize
    # Everything is fatal EAPI 4 onwards
    nonfatal elibtoolize ${ELTCONF}
}

This snippet is meaningless since elibtoolize calls 'die', and 'die' does not respect 'nonfatal' (except for a Portage bug that was fixed already AFAIR).

Comment 1 Pacho Ramos gentoo-dev

2015-07-09 09:59:41 UTC

Feel free to fix it if you have time (I cannot commit it just now)

Comment 2 Michał Górny archtester

2015-07-09 15:42:53 UTC

+  09 Jul 2015; Michał Górny <mgorny@gentoo.org> gnome2.eclass:
+  Remove meaningless nonfatal from elibtoolize call, bug #551154.