Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 55087 - xorg-x11-6.7.0-r1 fails on 0120_all_4.3.99-parallel-make-v2.patch
Summary: xorg-x11-6.7.0-r1 fails on 0120_all_4.3.99-parallel-make-v2.patch
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
: 55692 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-06-24 14:57 UTC by Karl Trygve Kalleberg (RETIRED)
Modified: 2004-09-14 10:21 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
0120_all_4.3.99-parallel-make-v2.patch-7864.out (0120_all_4.3.99-parallel-make-v2.patch-7864.out,29.42 KB, text/plain)
2004-06-24 14:57 UTC, Karl Trygve Kalleberg (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Trygve Kalleberg (RETIRED) gentoo-dev 2004-06-24 14:57:04 UTC
Fails to unpack, complaining about the 0120_all_4.3.99-parallel-make-v2.patch
Comment 1 Karl Trygve Kalleberg (RETIRED) gentoo-dev 2004-06-24 14:57:40 UTC
Created attachment 34089 [details]
0120_all_4.3.99-parallel-make-v2.patch-7864.out

Output from failed patch.
Comment 2 Donnie Berkholz (RETIRED) gentoo-dev 2004-06-24 19:05:51 UTC
patch_exclude() is apparently failing. Can you attach the complete output of unpacking? It should list the patches it excludes. A similar problem hit spanky a while back, so I'll CC him.

The ebuild line, which is completely unconditional:
patch_exclude 0120*parallel-make

The function:
patch_exclude() {
	# Exclude patches matching a pattern if they exist
	for PATCH_GROUP in ${@}
	do
		# Repress errors for non-matching patterns, they're ugly
		for PATCH in $(ls ${PATCHDIR}/${PATCH_GROUP}* 2> /dev/null)
		do
			if [ -a "${PATCH}" ]
			then
				ebegin "  `basename ${PATCH}`"
					mv -f ${PATCH} ${EXCLUDED}
				eend 0
			fi
		done
	done
}
Comment 3 SpanKY gentoo-dev 2004-06-24 19:17:38 UTC
did you `emerge xorg-x11` or `ebuild xorg-x11 clean unpack` ?
Comment 4 Karl Trygve Kalleberg (RETIRED) gentoo-dev 2004-06-28 01:13:12 UTC
I did ebuild clean unpack, as emerge initially refuses to install xorg-x11 as
it conflicts with xfree, I also need to apply some site-local patches at
installation time, which is prevented by emerge as it just rushes through.

But I guess this means pkg_setup is not run, which is a severe problem. 

Why must these vars be set in pkg_setup(), why can't they be set in a helper
function that gets called on-demand in src_unpack, etc?

(one could also argue that ebuild <func> should always call pkg-setup, but
that's also a potential problem).
Comment 5 Karl Trygve Kalleberg (RETIRED) gentoo-dev 2004-06-28 01:25:55 UTC
I am just being stupid:

ebuild clean setup unpack compile install
Comment 6 Donnie Berkholz (RETIRED) gentoo-dev 2004-09-14 10:21:06 UTC
*** Bug 55692 has been marked as a duplicate of this bug. ***