Created attachment 402440 [details] patched ebuild The patch from upstream https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65801 should be applied to gcc-5.1.0, as well. (This break chromium) The patch is attached.
Created attachment 402442 [details, diff] gcc patch
Created attachment 402444 [details] corrected ebuild for gcc
It's upstream so I guess we can add it, but these errors should really be fixed in the package that causes them, not worked around with a compiler flag.
Created attachment 402834 [details, diff] patch for gcc-5.1.0 This patch is the most recent (accepted) version from upstream (backported to 5.1.0)
(In reply to Ryan Hill from comment #3) > It's upstream so I guess we can add it, but these errors should really be > fixed in the package that causes them, not worked around with a compiler > flag. I'm not sure I understand correctly. This is clearly a GCC problem, not a package issue. Please add this patch, otherwise Chromium will not build (see bug 548306).
It's a package bug. The code violates the C++-11 standard and should be fixed. Allowing -Wno-narrowing to suppress the error is papering over the problem.
(In reply to Ryan Hill from comment #6) > It's a package bug. The code violates the C++-11 standard and should be > fixed. Allowing -Wno-narrowing to suppress the error is papering over the > problem. Thanks for your comment and adding the reference. While the code in Chromium might be suboptimal, the real bug is that GCC ignores -Wno-narrowing. I think Chromium used -std=c++11 before as well, but now regresses with GCC 5.1. In fact, I wonder why an error instead of a warning is emitted. The question is how to continue in Gentoo. Either we wait for a new GCC version (which might take some time), or make a gcc-5.1.0-r1 containing this bugfix.
There's no question. This will get added when we do a new patchset. I'll see if I can do it this weekend.
this is fixed w/gcc-5.2 which is in the tree now
