Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 548324 - sys-fs/udftools-1.0.0b-r9 fails to compile with gcc-5.1
Summary: sys-fs/udftools-1.0.0b-r9 fails to compile with gcc-5.1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GCC Porting (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: gcc-5
  Show dependency tree
 
Reported: 2015-05-01 10:47 UTC by Martin Väth
Modified: 2015-05-12 05:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (sys-fs:udftools-1.0.0b-r9:20150504-084904.log,39.64 KB, text/plain)
2015-05-04 09:08 UTC, Martin Väth
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Väth 2015-05-01 10:47:16 UTC
sys-fs/udftools-1.0.0b-r9 fails to compile with gcc-5
Probably the most simple fix is to add -std=gnu90 to the CFLAGS
Comment 1 Ryan Hill (RETIRED) gentoo-dev 2015-05-02 23:17:57 UTC
All your bugs need build logs.
Comment 2 Martin Väth 2015-05-03 21:22:47 UTC
The build failure is in the linking phase when one gets

undefined reference to `query_iuvdiu'
(and several more undefined references).

Which is clear since there is

include/libudffs.h:inline struct impUseVolDescImpUse *query_iuvdiu([...]);
libudffs/desc.c:inline struct impUseVolDescImpUse *query_iuvdiu([...])

which is valid for C90, but for newer C dialects this will inline the function and not export it.
Comment 3 SpanKY gentoo-dev 2015-05-04 02:43:47 UTC
(In reply to Martin Väth from comment #2)

as Ryan said, please post build logs as attachments for all your reports
Comment 4 Martin Väth 2015-05-04 08:06:53 UTC
Why?

I do agreee that logs are useful if the problem or its cause are unclear or not (yet) identified. But this is not the case here: I posted explanations and recompiled several times with various settings to be sure that the problems are reproducible and that my suggested fix solves them.

I am glad to share my findings, but if I should spend additional time (and BTW also considerable disk space of bugzilla), I really need a logical reason to do so.
Comment 5 SpanKY gentoo-dev 2015-05-04 08:33:26 UTC
(In reply to Martin Väth from comment #4)

because it makes our lives easier to triage, coordinate multiple failures across packages, and for other people hitting the same failure to find when searching (either via bugzilla or via google).  bugzilla storage is not a concern.
Comment 6 Martin Väth 2015-05-04 09:08:48 UTC
Created attachment 402594 [details]
build log
Comment 7 SpanKY gentoo-dev 2015-05-12 05:00:27 UTC
should be all set now in the tree; thanks for the report!

Commit message: Force older C standard to fix building w/gcc-5
http://sources.gentoo.org/sys-fs/udftools/udftools-1.0.0b-r9.ebuild?r1=1.8&r2=1.9