Bug 548320 – dev-vcs/rcs-5.9.3 fails to compile with gcc-5.1

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Martin Väth 2015-05-01 10:42:31 UTC]

dev-vcs/rcs-5.9.3 fails to compile with gcc-5
One gets the same errors as in bug 542302
Probably the most simple fix is to add -std=gnu99 to CFLAGS

[Comment 1 Ryan Hill (RETIRED) 2015-05-02 23:16:21 UTC]

Need a build log.

[Comment 2 Martin Väth 2015-05-03 21:11:18 UTC]

As mentioned, you get practically the same log as in bug 542302

While in the mentioned bug, the problem was caused by explicitly adding -std=gnu11 to the CFLAGS, when using gcc-5, this happens implicitly because of the changed defaults.

[Comment 3 Ryan Hill (RETIRED) 2015-05-03 22:10:56 UTC]

That's great, attach the log.

[Comment 4 Martin Väth 2015-05-04 06:58:30 UTC]

Why?

[Comment 5 Martin Väth 2015-05-04 09:11:24 UTC]

Created attachment 402596 [details]
build log

[Comment 6 Ian Delaney (RETIRED) 2015-05-20 01:14:59 UTC]

This appears a gcc 5.1 issues and I don't wrok gcc all that much, RHill does

[Comment 7 Martin Väth 2015-05-20 06:52:40 UTC]

(In reply to Ian Delaney from comment #6)
> This appears a gcc 5.1 issues

Well, it is simply explained:
Since gcc-5, the default C dialect is gnu11 (an extension of c11).

Obviously, dev-vcs/rcs is written in the gnu99 (an extension of c99) dialect.

So, either the syntax is updated to the new standard (which might be quite cumbersome - I am not an expert in details about the C standard and did not try to check), or one instruct gcc-5 with the mentioned compiler switch to accept the previous default dialect. (In previous gcc versions, this switch is presumably a NOOP).

[Comment 8 Bernd Buschinski 2015-07-21 10:43:45 UTC]

also fails with dev-vcs/rcs-5.9.4 (not in tree or cvs or whatever)

append-flags -std=gnu99 helps (just for the record)

[Comment 9 Ian Delaney (RETIRED) 2015-07-25 07:16:44 UTC]

  25 Jul 2015; Ian Delaney <[e-mail]> rcs-5.9.3.ebuild:
  set -std=gnu99 into CFLAGS, thanks to fix by Bernd Buschinski in bug #548320

Set to test-request despite that coming under status RESOLVED. CC entries ensure interested parties can runtest and addd comment.

[Comment 10 Martin Väth 2015-07-25 07:27:56 UTC]

(In reply to Ian Delaney from comment #9)
>  thanks to fix by Bernd Buschinski

This fix is from me (see the original report; comment #0).
Normally I would not mind, but after I was forced here to post so much redundant data and explanations just to get this fix through, I do not want to see that it is now contributed to somebody else.

[Comment 11 Ian Delaney (RETIRED) 2015-07-27 07:05:58 UTC]

ChangeLog corrected

  25 Jul 2015; Ian Delaney <[e-mail]> rcs-5.9.3.ebuild:
  set -std=gnu99 into CFLAGS, thanks to fix by Martin Väth, Comment 0,
  in bug #548320

Sorry for misreading