548314 – app-arch/tarsync-0.2.1-r1 does not compile with gcc-5.1

Bug 548314 - app-arch/tarsync-0.2.1-r1 does not compile with gcc-5.1

Summary: app-arch/tarsync-0.2.1-r1 does not compile with gcc-5.1

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] GCC Porting (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	gcc-5
	Show dependency tree

Reported:	2015-05-01 10:32 UTC by Martin Väth
Modified:	2015-05-26 23:44 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
build log (app-arch:tarsync-0.2.1-r1:20150504-095938.log,12.27 KB, text/plain) 2015-05-04 10:02 UTC, Martin Väth	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Martin Väth 2015-05-01 10:32:34 UTC

app-arch/tarsync-0.2.1-r1 does not compile with gcc-5
Probably the most simple fix is to add -std=gnu90 to the CFLAGS

Comment 1 Ryan Hill (RETIRED) gentoo-dev

2015-05-02 23:15:08 UTC

Need a build log.

Comment 2 Martin Väth 2015-05-03 21:01:40 UTC

The build finishes with linking error: undefined reference to `match_excludes'

Which is clear, since we have:

/tarsync/excludes.h:inline int match_excludes([...]);
./tarsync/excludes.c:match_excludes([...])

In C90, the code is OK, but in newer C dialects, the match_excludes will be inlined and not exported.

Comment 3 Martin Väth 2015-05-04 10:02:44 UTC

Created attachment 402610 [details]
build log

Comment 4 Matthias Maier gentoo-dev

2015-05-26 23:44:18 UTC

I have removed the offending inline keywords such that the symbols get exported.


  26 May 2015; Matthias Maier <tamiko@gentoo.org>
  +files/tarsync-0.2.1-gcc5.patch, tarsync-0.2.1-r1.ebuild:
  fix compilation with gcc-5.1, bug #548314