Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 545682 - sys-apps/ucspi-ssl-0.94 - hppa2.0-unknown-linux-gnu-gcc: error: unrecognized command line option ‘-m64’
Summary: sys-apps/ucspi-ssl-0.94 - hppa2.0-unknown-linux-gnu-gcc: error: unrecognized ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: HPPA Linux
: Normal normal (vote)
Assignee: Alex Efros
URL:
Whiteboard:
Keywords:
: 546992 (view as bug list)
Depends on:
Blocks: 516868
  Show dependency tree
 
Reported: 2015-04-06 06:52 UTC by Jeroen Roovers (RETIRED)
Modified: 2015-04-20 05:39 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
sys-apps:ucspi-ssl-0.94:20150405-061328.log.xz (20150405-061328.log.xz,4.40 KB, application/x-xz)
2015-04-06 06:53 UTC, Jeroen Roovers (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeroen Roovers (RETIRED) gentoo-dev 2015-04-06 06:52:39 UTC
src/conf-ld:hppa2.0-unknown-linux-gnu-gcc  -m64 -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -Wl,--no-keep-memory
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2015-04-06 06:53:22 UTC
Created attachment 400648 [details]
sys-apps:ucspi-ssl-0.94:20150405-061328.log.xz
Comment 2 Alex Efros 2015-04-06 08:12:47 UTC
Well, I don't have access to HPPA, but as far as I see only file mentioning -m64 is conf-ld, which is created by qmail_set_cc() from qmail.eclass. So, looks like this should be fixed by maintainer of qmail.eclass.

I've checked mail-mta/netqmail-1.06-r2.ebuild - looks like it support hppa and use same qmail_set_cc() without extra patching, so I wonder is it really compiles right now on hppa, and if yes then what's the difference?
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2015-04-17 05:10:36 UTC
(In reply to Alex Efros from comment #2)
> Well, I don't have access to HPPA, but as far as I see only file mentioning
> -m64 is conf-ld, which is created by qmail_set_cc() from qmail.eclass. So,
> looks like this should be fixed by maintainer of qmail.eclass.

After src_unpack():

~/portage/sys-apps/ucspi-ssl-0.94/work/host/superscript.com/net/ucspi-ssl-0.94 # grep -r -- -m64
src/conf-ld:gcc -s -m64

qmail.eclass isn't doing this.
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2015-04-17 05:50:56 UTC
Index: ucspi-ssl-0.94.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/sys-apps/ucspi-ssl/ucspi-ssl-0.94.ebuild,v
retrieving revision 1.7
diff -u -p -r1.7 ucspi-ssl-0.94.ebuild
--- ucspi-ssl-0.94.ebuild       14 Apr 2015 12:32:10 -0000      1.7
+++ ucspi-ssl-0.94.ebuild       17 Apr 2015 05:50:47 -0000
@@ -24,7 +24,10 @@ S="${WORKDIR}"/host/superscript.com/net/
 src_prepare() {
        ht_fix_all
        sed -i -e 's:HOME/command:/usr/bin:' sslcat.sh sslconnect.sh https\@.sh
-       sed -i -e 's:auto:gcc:' conf-cc conf-ld
+       local compile_script
+       for compile_script in conf-cc conf-ld; do
+               echo gcc -Wall > ${compile_script} || die
+       done

        qmail_set_cc
Comment 5 Alex Efros 2015-04-17 06:18:27 UTC
(In reply to Jeroen Roovers from comment #3)
> qmail.eclass isn't doing this.

Yeah, you right. I've noticed qmail.eclass will overwrite conf-ld, but didn't investigated how it generate new value for it - I just suppose it take it from env variables suitable for current arch, but looks like it instead partially use existing contents of that file, thus leaving -m64 inplace.

Fixed ebuild is attached to bug 516868 (https://bugs.gentoo.org/attachment.cgi?id=401428).
Comment 6 Ian Delaney (RETIRED) gentoo-dev 2015-04-20 01:20:11 UTC
feedback to maintainer;

1. DESCRIPTION="Command-line tools for building SSL client-server applications."
You added a period, only to break gentoo protocol which states no use of a period in a DESCRIPTION. Believe it or not.
2. DEPEND=">=dev-libs/openssl-0.9.6g"
I see no wisdom in dropping the := in
">=dev-libs/openssl-0.9.6g:="
therefore it is retained.
3. You supplied an entire ebuild in an attachment in a separate (but related) bug. Following the flow of events and preparing the final commit was made (at least) twice as tedious.
4. While supplying a whole ebuild is sane, in cases like this where edits of an ebuild amount to a few lines, use of a diff -u is the norm.  The unified diff patch can be imported and a clean update achieved in seconds.
5. KEYWORDS="~amd64 ~x86 ~alpha ~arm ~hppa ~ia64 ~m68k ~ppc ~ppc64 ~s390 ~sh ~sparc ~x86-fbsd"
in gentoo style is a mess. Simply keep to alphabetical order.
6. The rule to revbump isn't met here. This is a build failure. The final built state and installed state will be the same.  Any advantage here is in distinguishing the attempts to build the fail, but the fail and the build are in common.

Other than that it was a good effort.

  20 Apr 2015; Ian Delaney <idella4@gentoo.org> ucspi-ssl-0.94-r1.ebuild:
  drop use of patch, add sed stmnt from patch supplied by maintainer in
  attachment of Bug #516868 wrt bug #545682

*ucspi-ssl-0.94-r1 (19 Apr 2015)
Comment 7 Jeroen Roovers (RETIRED) gentoo-dev 2015-04-20 05:39:12 UTC
*** Bug 546992 has been marked as a duplicate of this bug. ***