Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 544402 - media-video/mpv-9999: remove joystick, lirc and mpg123 USE flags and deps
Summary: media-video/mpv-9999: remove joystick, lirc and mpg123 USE flags and deps
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Ben de Groot (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-25 00:39 UTC by Nikos Chantziaras
Modified: 2015-03-29 00:38 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch against current mpv-9999.ebuild (mpv-9999.patch,1.39 KB, patch)
2015-03-25 00:39 UTC, Nikos Chantziaras
Details | Diff
updated live ebuild (mpv-9999.ebuild,6.56 KB, text/plain)
2015-03-27 20:31 UTC, Nikoli
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nikos Chantziaras 2015-03-25 00:39:55 UTC
Created attachment 399690 [details, diff]
Patch against current mpv-9999.ebuild

Upstream removed support for lirc, joysticks and libmpg123:

https://github.com/mpv-player/mpv/commit/9b5a7241e88f8147a391f1bb79ce01593a02d443
https://github.com/mpv-player/mpv/commit/1e659a9f0f3a3836912c66ab75b5af38e632ef12
https://github.com/mpv-player/mpv/commit/d5318e5e095f3ef831b5251b554ce790da3c40c7


As a result, the emerge aborts with unrecognized configure options.

Patch is attached.
Comment 1 Nikoli 2015-03-27 20:31:51 UTC
Created attachment 399900 [details]
updated live ebuild

Thank you for report.
Comment 2 Ben de Groot (RETIRED) gentoo-dev 2015-03-28 01:54:27 UTC
(In reply to Nikoli from comment #1)
> Created attachment 399900 [details]
> updated live ebuild

The diff with the ebuild already in the tree is much more useful. It makes reviewing much easier.

And do not re-assign bugs away from the maintainer who can actually commit.

Also, there is a now outdated mpv-9999 ebuild in the multimedia overlay. We should be maintaining this in one location only. In my opinion live ebuilds belong in overlays, so I'm considering to move the updated ebuild there.

+  28 Mar 2015; Ben de Groot <yngwin@gentoo.org> -mpv-0.8.0.ebuild,
+  -mpv-0.8.2.ebuild, mpv-0.7.3.ebuild, mpv-0.8.3.ebuild, mpv-9999.ebuild:
+  Update live ebuild to sync with upstream changes, as reported by Nikos
+  Chantziaras in bug #544402. Normalize useflags. Do not default enable mpg123,
+  as upstream recommends libavcodec. Remove older 0.8.x ebuilds.
Comment 3 Nikoli 2015-03-28 08:36:45 UTC
> The diff with the ebuild already in the tree is much more useful. It makes reviewing much easier.

Ebuild is simpler for end users, devs can look diff via vcs before committing. Some users asked me for working mpv live ebuild in irc.

> And do not re-assign bugs away from the maintainer who can actually commit.

This was done by mistake: bug tracker did not exactly what i expected.

> In my opinion live ebuilds belong in overlays, so I'm considering to move the updated ebuild there.

Better to remove mpv from overlay entirely: it seems a lot people use live ebuild from tree.
Comment 4 Perfect Gentleman 2015-03-28 08:47:07 UTC
also update waf to 1.8.7
Comment 5 Nikoli 2015-03-28 08:47:26 UTC
Ben, also why you did this 'Normalize useflags' change? I told you in irc, that '-' in IUSE are for indicating which features should be normally kept disabled. It was visible well via eix and reading ebuild. If you think this way of indicating is not optimal, then it can be replaced by pkg_setup messages like 'use foo && ewarn "Do not use foo"', but removing list of suggested for disabling USE flags is wrong.
Comment 6 Ben de Groot (RETIRED) gentoo-dev 2015-03-29 00:12:23 UTC
(In reply to Nikoli from comment #3)
> > The diff with the ebuild already in the tree is much more useful. It makes reviewing much easier.
> 
> Ebuild is simpler for end users, devs can look diff via vcs before
> committing. Some users asked me for working mpv live ebuild in irc.

Okay, that's a valid reason. Tho it would be better to keep an up-to-date live ebuild in the overlay. Both Nikos and you could have updated that one, and other users would get the updated live ebuild even easier.

> > In my opinion live ebuilds belong in overlays, so I'm considering to move the updated ebuild there.
> 
> Better to remove mpv from overlay entirely: it seems a lot people use live
> ebuild from tree.

We have an active upstream with regular releases. We maintain those versions in the gentoo repo. I don't think we have a pressing need for a live ebuild here. It is experimental stuff that is more suited for an overlay.

Also, since non-dev contributors such as Nikos and yourself have commit access to the overlay, it makes the workflow easier. You guys can commit straight to the overlay, and that way users have quick access to the latest updates. And I can simply merge stuff from the overlay (after review) into the main gentoo repo.

Note that I am moving the multimedia overlay to github. At the moment I am pushing to both github and gitorious. I need to update the layman configuration, but after that the gitorious repo will be deprecated.
Comment 7 Ben de Groot (RETIRED) gentoo-dev 2015-03-29 00:14:01 UTC
(In reply to Perfect Gentleman from comment #4)
> also update waf to 1.8.7

I checked for that, but upstream is still using 1.8.4. 
See https://github.com/mpv-player/mpv/blob/master/bootstrap.py
Comment 8 Ben de Groot (RETIRED) gentoo-dev 2015-03-29 00:18:02 UTC
(In reply to Nikoli from comment #5)
> Ben, also why you did this 'Normalize useflags' change? I told you in irc,
> that '-' in IUSE are for indicating which features should be normally kept
> disabled. It was visible well via eix and reading ebuild. If you think this
> way of indicating is not optimal, then it can be replaced by pkg_setup
> messages like 'use foo && ewarn "Do not use foo"', but removing list of
> suggested for disabling USE flags is wrong.

In IUSE we only use + for useflags that we enable by default. All others are not enabled by default (at ebuild level). Using - has no effect.

If you want to signal to users that certain useflags are discouraged or sub-optimal, then it is much better and clearer to put an explicit message about that in the useflag description in metadata.xml. To do it in IUSE is totally not obvious and not standard practice.
Comment 9 Nikos Chantziaras 2015-03-29 00:38:52 UTC
Oops, I didn't actually notice that we had mpv in the multimedia overlay.