Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 543954 - dev-util/mingw64-runtime-4.0.1 - version bump
Summary: dev-util/mingw64-runtime-4.0.1 - version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 548200
  Show dependency tree
 
Reported: 2015-03-20 20:09 UTC by Alon Bar-Lev (RETIRED)
Modified: 2015-05-05 11:40 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mingw64-runtime-4.0.0.ebuild.diff (mingw64-runtime-4.0.0.ebuild.diff,1.91 KB, patch)
2015-03-21 10:20 UTC, Alon Bar-Lev (RETIRED)
Details | Diff
mingw64-runtime-4.0.1.ebuild.diff (mingw64-runtime-4.0.1.ebuild.diff,2.66 KB, patch)
2015-05-04 19:26 UTC, Alon Bar-Lev (RETIRED)
Details | Diff
mingw64-runtime-4.0.1-winpthreads.patch (mingw64-runtime-4.0.1-winpthreads.patch,3.06 KB, patch)
2015-05-04 19:26 UTC, Alon Bar-Lev (RETIRED)
Details | Diff
mingw64-runtime-4.0.1-build.patch (mingw64-runtime-4.0.1-build.patch,2.83 KB, patch)
2015-05-04 19:26 UTC, Alon Bar-Lev (RETIRED)
Details | Diff
mingw64-runtime-4.0.1-build.patch (mingw64-runtime-4.0.1-build.patch,2.91 KB, patch)
2015-05-05 07:07 UTC, Alon Bar-Lev (RETIRED)
Details | Diff
mingw64-runtime-4.0.1-winpthreads.patch (mingw64-runtime-4.0.1-winpthreads.patch,3.07 KB, patch)
2015-05-05 07:07 UTC, Alon Bar-Lev (RETIRED)
Details | Diff
mingw64-runtime-4.0.1.ebuild.multi.diff (file_543954.txt,19 bytes, patch)
2015-05-05 07:09 UTC, Alon Bar-Lev (RETIRED)
Details | Diff
mingw64-runtime-4.0.1.ebuild.multi.diff (mingw64-runtime-4.0.1.ebuild.multi.diff,2.55 KB, patch)
2015-05-05 07:09 UTC, Alon Bar-Lev (RETIRED)
Details | Diff
mingw64-runtime-4.0.1.ebuild.diff (mingw64-runtime-4.0.1.ebuild.diff,2.40 KB, patch)
2015-05-05 07:10 UTC, Alon Bar-Lev (RETIRED)
Details | Diff
mingw64-runtime-4.0.1.ebuild.diff (mingw64-runtime-4.0.1.ebuild.diff,2.40 KB, patch)
2015-05-05 07:30 UTC, Alon Bar-Lev (RETIRED)
Details | Diff
mingw64-runtime-4.0.1.ebuild.diff (mingw64-runtime-4.0.1.ebuild.diff,2.41 KB, patch)
2015-05-05 08:42 UTC, Alon Bar-Lev (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alon Bar-Lev (RETIRED) gentoo-dev 2015-03-20 20:09:55 UTC
Just rename latest and it works, bug suffers from same issue as the 2.x->3.x upgrade, see bug#486832. Include files of sysroot are injected before these in libc, causing build to fail.

Workaround is to clean/build.

I reported this once again to upstream, I hope they will address this issue.

Please tell me if you want to add it anyway.
Comment 1 Alon Bar-Lev (RETIRED) gentoo-dev 2015-03-21 10:20:10 UTC
Created attachment 399354 [details, diff]
mingw64-runtime-4.0.0.ebuild.diff

They solved it in 4.0, for some extent. Please review.
Comment 2 SpanKY gentoo-dev 2015-03-21 11:09:12 UTC
what is with all the multilib logic ?  we don't support multilib installs with cross-xxx packages.
Comment 3 Alon Bar-Lev (RETIRED) gentoo-dev 2015-03-21 18:17:31 UTC
(In reply to SpanKY from comment #2)
> what is with all the multilib logic ?  we don't support multilib installs
> with cross-xxx packages.

it is multibuild not multilib :)

I used this eclass to build the header in separate builddir, I can do this manually instead if you think this eclass is not helpful.
Comment 4 SpanKY gentoo-dev 2015-03-21 19:50:43 UTC
(In reply to Alon Bar-Lev from comment #3)

any time i see use of "copy sources" funcs, i look for a different route

i'm not seeing why you need it here at all though
Comment 5 Alon Bar-Lev (RETIRED) gentoo-dev 2015-03-21 19:54:49 UTC
(In reply to SpanKY from comment #4)
> (In reply to Alon Bar-Lev from comment #3)
> 
> any time i see use of "copy sources" funcs, i look for a different route
> 
> i'm not seeing why you need it here at all though

if we build the library what we actually need to do is:

1. build and install the headers into temporary location.
2. build the library with header of (1).

this enables upgrade sequence to actually work, as the library use the sysroot include by default.

so I used the multibuild eclass to copy the sources into alternate location, and configure/build at that location to deploy the header in temporary location.

this way the src_configure can configure the two sources with different settings, while the src_compile to build.
Comment 6 Alon Bar-Lev (RETIRED) gentoo-dev 2015-03-25 06:00:25 UTC
4.0.1 is out, same build.
Comment 7 Alon Bar-Lev (RETIRED) gentoo-dev 2015-05-04 17:23:49 UTC
Hi vapier,
Can we add it, or you want me to get rid of the multi-build eclass usage?
Comment 8 Alon Bar-Lev (RETIRED) gentoo-dev 2015-05-04 19:26:02 UTC
Created attachment 402652 [details, diff]
mingw64-runtime-4.0.1.ebuild.diff
Comment 9 Alon Bar-Lev (RETIRED) gentoo-dev 2015-05-04 19:26:33 UTC
Created attachment 402654 [details, diff]
mingw64-runtime-4.0.1-winpthreads.patch
Comment 10 Alon Bar-Lev (RETIRED) gentoo-dev 2015-05-04 19:26:55 UTC
Created attachment 402656 [details, diff]
mingw64-runtime-4.0.1-build.patch
Comment 11 SpanKY gentoo-dev 2015-05-05 06:46:08 UTC
sorry, i'm still not groking the need for the multibuild stuff.  if we did the bump w/out that, i'd certainly LGTM it quickly ;).

the winpthreads patches look fine (assuming you're shepherding them upstream since you're good about that).
Comment 12 Alon Bar-Lev (RETIRED) gentoo-dev 2015-05-05 07:07:26 UTC
Created attachment 402676 [details, diff]
mingw64-runtime-4.0.1-build.patch
Comment 13 Alon Bar-Lev (RETIRED) gentoo-dev 2015-05-05 07:07:53 UTC
Created attachment 402678 [details, diff]
mingw64-runtime-4.0.1-winpthreads.patch
Comment 14 Alon Bar-Lev (RETIRED) gentoo-dev 2015-05-05 07:09:07 UTC
Created attachment 402680 [details, diff]
mingw64-runtime-4.0.1.ebuild.multi.diff
Comment 15 Alon Bar-Lev (RETIRED) gentoo-dev 2015-05-05 07:09:59 UTC
Created attachment 402682 [details, diff]
mingw64-runtime-4.0.1.ebuild.multi.diff

multi build version
Comment 16 Alon Bar-Lev (RETIRED) gentoo-dev 2015-05-05 07:10:38 UTC
Created attachment 402684 [details, diff]
mingw64-runtime-4.0.1.ebuild.diff

None multi build version
Comment 17 Alon Bar-Lev (RETIRED) gentoo-dev 2015-05-05 07:12:01 UTC
(In reply to SpanKY from comment #11)
> sorry, i'm still not groking the need for the multibuild stuff.  if we did
> the bump w/out that, i'd certainly LGTM it quickly ;).

I've attached both versions with multi-build and without.

> the winpthreads patches look fine (assuming you're shepherding them upstream
> since you're good about that).

sure, already sent, will work to merge this functionality one way or the other.
Comment 18 SpanKY gentoo-dev 2015-05-05 07:26:39 UTC
Comment on attachment 402684 [details, diff]
mingw64-runtime-4.0.1.ebuild.diff

>+MULTIBUILD_VARIANTS=( headers )

left over ? :)

>+crt_with() {
>+	just_headers && echo --without-$1 || echo --with-$1
>+}
>+crt_use_enable() {
>+	just_headers && echo --without-$2 || use_enable $*
>+}
>+crt_use_with() {
>+	just_headers && echo --without-$2 || use_with $*
>+}

use "$@" instead of $*

>+	if ! just_headers; then
>+		mkdir "${T}/headers"
>+		pushd "${T}/headers"

use $WORKDIR instead of $T

send pushd/popd output to >/dev/null

>+		$(crt_use_with libraries libraries winpthreads,libmangle) \

should we even make this an option ?  or just always enable them ?
Comment 19 Alon Bar-Lev (RETIRED) gentoo-dev 2015-05-05 07:30:07 UTC
Created attachment 402686 [details, diff]
mingw64-runtime-4.0.1.ebuild.diff
Comment 20 Alon Bar-Lev (RETIRED) gentoo-dev 2015-05-05 07:31:48 UTC
(In reply to SpanKY from comment #18)
> >+		$(crt_use_with libraries libraries winpthreads,libmangle) \
> 
> should we even make this an option ?  or just always enable them ?

I thought of avoiding issues in most configurations by compiling less.

But real reason is that at phase1 gcc I am unsure we will be able to build all libraries, so we can disable this at bootstrap then enable and rebuild.
Comment 21 Alon Bar-Lev (RETIRED) gentoo-dev 2015-05-05 08:42:11 UTC
Created attachment 402702 [details, diff]
mingw64-runtime-4.0.1.ebuild.diff

sorry, forgot the $@, it should be ok now.
Comment 22 SpanKY gentoo-dev 2015-05-05 10:10:37 UTC
(In reply to Alon Bar-Lev from comment #21)

looks ok ... lets start here and iterate on top (i.e. feel free to commit)
Comment 23 Alon Bar-Lev (RETIRED) gentoo-dev 2015-05-05 11:40:27 UTC
OK, thanks.