Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 536530 - www-client/firefox USE=gstreamer should depend on media-plugins/gst-plugins-mad for MP3 support
Summary: www-client/firefox USE=gstreamer should depend on media-plugins/gst-plugins-m...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-13 20:45 UTC by Marc Joliet
Modified: 2015-07-17 18:30 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Joliet 2015-01-13 20:45:49 UTC
MP3 support in Firefox stopped working for me a few versions ago (I don't remember which, exactly), and when it still did not work after upgrading to 35.0, I decided to investigate again.  Eventually I thought that maybe MP3 support was not provided by any of the installed gstreamer plug-ins (I expected gst-plugins-libav to provide it), and installed gst-plugins-mad.  And, well, MP3 playback started working again.

So I wonder whether Firefox with USE=gstreamer should depend on gst-plugins-mad?  Or at least print a post-installation message warning about lack of MP3 support?

Reproducible: Always

Steps to Reproduce:
1. emerge firefox with USE=gstreamer
2. try to play an MP3 at, e.g., soundcloud, or run the test suite at http://www.areweplayingyet.org/
Actual Results:  
Playback of MP3s fails.

Expected Results:  
Playback of MP3s succeeds.

% emerge --info firefox
Portage 2.2.14 (python 3.3.5-final-0, default/linux/amd64/13.0/no-emul-linux-x86/desktop, gcc-4.8.3, glibc-2.19-r1, 3.17.8-gentoo x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-3.17.8-gentoo-x86_64-Intel-R-_Core-TM-_i3_CPU_M_350_@_2.27GHz-with-gentoo-2.2
KiB Mem:     5894404 total,    345024 free
KiB Swap:    8388604 total,   8388408 free
Timestamp of tree: Tue, 13 Jan 2015 14:45:01 +0000
ld GNU ld (Gentoo 2.24 p1.4) 2.24
app-shells/bash:          4.2_p53
dev-java/java-config:     2.2.0
dev-lang/perl:            5.18.2-r2
dev-lang/python:          2.7.9-r1, 3.3.5-r1, 3.4.1
dev-util/cmake:           2.8.12.2-r1
dev-util/pkgconfig:       0.28-r1
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.12.4
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.11.6-r1, 1.13.4
sys-devel/binutils:       2.24-r3
sys-devel/gcc:            4.8.3
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4.2-r1
sys-devel/make:           4.0-r1
sys-kernel/linux-headers: 3.16 (virtual/os-headers)
sys-libs/glibc:           2.19-r1
Repositories: gentoo science proaudio mjoliet
Installed sets: @audio-base, @desktop-apps, @desktop-base, @desktop-misc, @devel-audio, @devel-base, @devel-c_cpp, @devel-doc, @devel-python, @latex, @local-arthur, @matlab, @science, @sys-base, @sys-utils, @work-demonstrator
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -march=native -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -march=native -pipe"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--with-bdeps=y --quiet-build=y --nospinner --keep-going"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="ftp://de-mirror.org/gentoo/ ftp://ftp.wh2.tu-dresden.de/pub/mirrors/gentoo ftp://mirror.netcologne.de/gentoo/"
LANG="de_DE.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-s -j3"
PKGDIR="/usr/portage/packages"
PORTAGE_COMPRESS="xz"
PORTAGE_COMPRESS_FLAGS="-9"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/science /var/lib/layman/pro-audio /usr/local/portage/marcec"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="3dnow 3dnowext X a52 aac acl acpi alsa amd64 avahi berkdb branding bzip2 cairo caps cdda cdinstall cdr cjk cli consolekit cracklib crypt css cups cxx dbus dga djvu dri dssi dts dvd dvdr emboss encode exif fbcon ffmpeg fftw firefox fish-completion flac fortran ftp fuse gdbm gif glamor gmp gnuplot gnutls gtk iconv idn imlib inotify ipv6 jack jackmidi jpeg jpeg2k kipi ladspa lapack lash latex lcms libnotify libsamplerate logrotate lzma mad mmx mmxext mng modplug modules mp3 mp4 mpeg multilib musepack musicbrainz ncurses nls nptl offensive ogg openexr opengl openmp opus osc pam pango pcre pdf plotutils png policykit ppds pulseaudio qt3support qt4 quicktime rar readline rtsp samba sasl session sid slang smp sndfile speex spell sse sse2 sse3 sse4 ssl ssse3 startup-notification svg taglib tcpd theora threads tiff timidity truetype udev udisks unicode upower usb v4l vaapi vdpau vim-syntax vorbis vpx webkit wma x264 xattr xcb xcomposite xface xft xml xmp xpm xscreensaver xv xvid zeroconf zlib zsh-completion" ABI_X86="64" ALSA_CARDS="hda-intel usb-audio" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en_US en en_GB de" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3" RUBY_TARGETS="ruby19 ruby20" USERLAND="GNU" VIDEO_CARDS="intel" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON

=================================================================
                        Package Settings
=================================================================

www-client/firefox-35.0 was built with the following:
USE="dbus gmp-autoupdate gstreamer jit minimal pulseaudio startup-notification system-cairo system-icu system-jpeg system-libvpx -bindist -custom-cflags -custom-optimization -debug -hardened (-pgo) (-selinux) -system-sqlite -test -wifi" ABI_X86="64" LINGUAS="de en_GB -af -ar -as -ast -be -bg -bn_BD -bn_IN -br -bs -ca -cs -cy -da -el -en_ZA -eo -es_AR -es_CL -es_ES -es_MX -et -eu -fa -fi -fr -fy_NL -ga_IE -gd -gl -gu_IN -he -hi_IN -hr -hu -hy_AM -id -is -it -ja -kk -km -kn -ko -lt -lv -mai -mk -ml -mr -nb_NO -nl -nn_NO -or -pa_IN -pl -pt_BR -pt_PT -rm -ro -ru -si -sk -sl -son -sq -sr -sv_SE -ta -te -th -tr -uk -vi -xh -zh_CN -zh_TW"
CFLAGS="-march=native -pipe -mno-avx"
CXXFLAGS="-march=native -pipe -mno-avx"
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2015-01-14 06:57:54 UTC
It already depends on media-plugins/gst-plugins-meta:

[ebuild  NS    ] media-plugins/gst-plugins-meta-1.0-r2:1.0 [0.10-r9:0.10] USE="X a52 aac alsa flac jack lame ogg opus theora vorbis wavpack x264 -cdda -dts -dv -dvb -dvd -ffmpeg -http -libass -libvisual -mms -mp3 -mpeg -oss (-pulseaudio) -taglib -v4l -vcd -vpx" ABI_X86="32 (64) (-x32)" 0 KiB

So if you set USE=mp3 globally or set it specifically for media-plugins/gst-plugins-meta, then you should already have had MP3 support.

Oddly enough, www-client/firefox-35.0 decides to be different and cherry-picks some gst-plugins-* packages to depend on instead of the meta-package.
Comment 2 Marc Joliet 2015-01-14 07:47:14 UTC
(In reply to Jeroen Roovers from comment #1)
> It already depends on media-plugins/gst-plugins-meta:
> 
> [ebuild  NS    ] media-plugins/gst-plugins-meta-1.0-r2:1.0 [0.10-r9:0.10]
> USE="X a52 aac alsa flac jack lame ogg opus theora vorbis wavpack x264 -cdda
> -dts -dv -dvb -dvd -ffmpeg -http -libass -libvisual -mms -mp3 -mpeg -oss
> (-pulseaudio) -taglib -v4l -vcd -vpx" ABI_X86="32 (64) (-x32)" 0 KiB
> 
> So if you set USE=mp3 globally or set it specifically for
> media-plugins/gst-plugins-meta, then you should already have had MP3 support.
> 
> Oddly enough, www-client/firefox-35.0 decides to be different and
> cherry-picks some gst-plugins-* packages to depend on instead of the
> meta-package.

Sorry, I should have been more clear: I was, in fact, referring to the Firefox 35.0 ebuild.  The dependencies were changed because of bug #515198, where one of the proposals actually had a dependency on gst-plugins-mad; the implication (in my head at least) being that said dependency change broke previously working MP3 support.  And now that I look at that bug again, I notice that it is *not* closed.  Oops.  Should I comment there instead?
Comment 3 Ian Stakenvicius (RETIRED) gentoo-dev 2015-07-17 17:07:30 UTC
Multimedia group asked us to depend on specific packages rather than the -meta, since apparently the -meta is only meant for inclusion in @world by end-users, or something.

The subset listed at this point is minimal, but I will add gst-plugins-mad to the list as well.  I won't be revbumping ebuilds though so this change won't -really- take effect userbase-wide until firefox-38.2 or firefox-40.
Comment 4 Ian Stakenvicius (RETIRED) gentoo-dev 2015-07-17 18:30:36 UTC
Gst-plugins-libav as of version 1.4.5 advertizes its mp3 decoding now, so there is no need for a gst-plugins-mad package to be installed.  Since 1.4.5 is current stable I bumped the dependency minvers for mozilla-38 and mozilla-39.