Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 535704 - app-text/evince: add a USE that allows disabling build of browser plugin
Summary: app-text/evince: add a USE that allows disabling build of browser plugin
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-05 20:00 UTC by Austin S. Hemmelgarn
Modified: 2015-06-10 11:01 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
New ebuild. (file_535704.txt,3.11 KB, text/plain)
2015-01-05 20:00 UTC, Austin S. Hemmelgarn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Austin S. Hemmelgarn 2015-01-05 20:00:20 UTC
Created attachment 393266 [details]
New ebuild.

On some systems, it makes no sense whatsoever to build a browser plugin.  Chrome in particular totally ignores system NPAPI plugins these days.  The attached ebuild adds the 'nsplugin' USE flag to allow control of whether or not to build the plugin.  It is default enabled to preserve current behavior.
Comment 1 Pacho Ramos gentoo-dev 2015-01-06 14:54:09 UTC
I am not sure we should have a USE flag to end up installing one less file :/ (as it doesn't change anything, for example, when thinking in adding more dependencies or similar). If people don't want to install the plugins, maybe they should rely on INSTALL_MASK for that. 

But I don't have a strong opinion on this, lets see what other team members think
Comment 2 Austin S. Hemmelgarn 2015-01-06 15:14:38 UTC
(In reply to Pacho Ramos from comment #1)
> I am not sure we should have a USE flag to end up installing one less file
> :/ (as it doesn't change anything, for example, when thinking in adding more
> dependencies or similar). If people don't want to install the plugins, maybe
> they should rely on INSTALL_MASK for that. 
> 
> But I don't have a strong opinion on this, lets see what other team members
> think

My thought is less about the installed file than the fact that disabling it reduces the build time.  It's not a huge reduction in build time, but is still enough to be significant for less powerful systems like the Raspberry Pi or BeagleBoard.  Further, having a use flag to control this is more consistent with other packages in portage.
Comment 3 cazzantonio 2015-03-17 23:01:53 UTC
I confirm that this but is presnt also in amd64 stable. It can be disabled in firefox (that can also open pdf files independently, while the evince plugin overwrites this behaviour), however it is annoying and a use flag to disable the plugin would be welcomed
Comment 4 Alexandre Rostovtsev (RETIRED) gentoo-dev 2015-03-18 15:36:00 UTC
IMHO browser plugins should always be controlled by a USE flag (unless the whole package is primarily intended as a browser plugin). Unnecessary plugins are a potential security hole and a potential source of crashes for the browser, which for most people is the single most important desktop application.
Comment 5 Gilles Dartiguelongue (RETIRED) gentoo-dev 2015-03-19 08:01:54 UTC
Then you can add totem and gnome-shell to your list.
Comment 6 Alexandre Rostovtsev (RETIRED) gentoo-dev 2015-03-22 19:47:30 UTC
(In reply to Gilles Dartiguelongue from comment #5)
> Then you can add totem and gnome-shell to your list.

Well, totem has finally stopped installing browser plugins in 3.14, and gnome-shell is a special case (the plugin can be activated only for one hard-coded domain).

+*evince-3.14.2-r1 (22 Mar 2015)
+
+  22 Mar 2015; Alexandre Rostovtsev <tetromino@gentoo.org>
+  +evince-3.14.2-r1.ebuild:
+  Make browser plugin optional (bug #535704, thanks to Austin S. Hemmelgarn).