534570 – app-emulation/xen-4.5.0_rc4 USE=efi - Failed Patch: xen-4.4-efi.patch !

Bug 534570 - app-emulation/xen-4.5.0_rc4 USE=efi - Failed Patch: xen-4.4-efi.patch !

Summary: app-emulation/xen-4.5.0_rc4 USE=efi - Failed Patch: xen-4.4-efi.patch !

Status:	RESOLVED TEST-REQUEST

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Xen Devs

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:

Reported:	2015-01-04 05:26 UTC by Daniel Mannarino
Modified:	2015-01-24 05:09 UTC (History)
CC List:	4 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Updated xen efi patch (xen-4.5-efi.patch,1.89 KB, patch) 2015-01-04 05:26 UTC, Daniel Mannarino	Details \| Diff
Xen ebuild adjusted for bumped efi patch (xen-4.5.0_rc4.ebuild,4.24 KB, text/plain) 2015-01-04 05:27 UTC, Daniel Mannarino	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Daniel Mannarino 2015-01-04 05:26:24 UTC

Created attachment 393130 [details, diff]
Updated xen efi patch

Xen 4.5.0RC4 fails to build because the patch in app-emulation/xen/xen-4.4-efi.patch does not cleanly apply. It appears that some paths have changed in xen/Makefile. I've attached a revised patch that allows xen-4.5.0RC4 to build.

Comment 1 Daniel Mannarino 2015-01-04 05:27:59 UTC

Created attachment 393132 [details]
Xen ebuild adjusted for bumped efi patch

Comment 2 Yixun Lan archtester

2015-01-04 06:58:40 UTC

thanks for testing, will fix this while the final 4.5.0 official released

Comment 3 Jeroen Roovers (RETIRED) gentoo-dev

2015-01-04 09:49:51 UTC

This is why conditional patching is bad.

Comment 4 Tomáš Mózes 2015-01-22 06:44:41 UTC

Applies for 4.5.0.

Comment 5 Tomáš Mózes 2015-01-22 06:53:33 UTC

With Daniel's patch xen 4.5.0 works with efi.

Comment 6 Robert Sebastian Gerus 2015-01-23 06:50:39 UTC

xen-4.5.0 still fails with USE="efi" - AFAICS on sources.gentoo.org, the patch wasn't updated.

Comment 7 Ian Delaney (RETIRED) gentoo-dev

2015-01-23 08:42:50 UTC

(In reply to Robert Sebastian Gerus from comment #6)
> xen-4.5.0 still fails with USE="efi" - AFAICS on sources.gentoo.org, the
> patch wasn't updated.

and everyone, including jer, see Comment 2.
Cut the man some slack.  He will fix it

Comment 8 Ian Delaney (RETIRED) gentoo-dev

2015-01-24 05:09:05 UTC

or I will. From memory I had to manually remake the efi patch for previous bumps.  Sometimes they apply to a bumped sometimes they don't.

  24 Jan 2015; Ian Delaney <idella4@gentoo.org> +files/xen-4.5-efi.patch,
  xen-4.5.0.ebuild:
  add patch to update for IUSE efi, prepared by D. Mannarino from bug #534570,
  fixes said bug

I'm not sure what is meant by conditional patching being under a cloud here. I would NOT want this patch applied without IUSE efi even if it worked anyway.  The problem wasn't being conditional, it was that the Makefile code was changed enough for the patch from the prior version to no longer apply.

Leaving open for any further cross testing and can be confirmed post further testing