Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 534092 - app-admin/webmin-1.730 version bump
Summary: app-admin/webmin-1.730 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: PhobosK
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2014-12-31 11:43 UTC by PhobosK
Modified: 2015-01-05 03:23 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
The new ebuild for webmin-1.720 (diff to 1.690) (webmin-1.720.ebuild.patch,1.35 KB, patch)
2014-12-31 11:43 UTC, PhobosK
Details | Diff
The new gentoo-setup script for the webmin-1.720 ebuild (gentoo-setup.patch,2.18 KB, patch)
2014-12-31 11:47 UTC, PhobosK
Details | Diff
The new ebuild for webmin-1.730 (diff to 1.690) (webmin-1.730.ebuild.patch,1.35 KB, patch)
2015-01-02 10:08 UTC, PhobosK
Details | Diff
The new gentoo-setup script for the webmin-1.730 ebuild (gentoo-setup.patch,2.66 KB, patch)
2015-01-02 10:09 UTC, PhobosK
Details | Diff
The new gentoo-setup script for the webmin-1.730 ebuild (fixed) (gentoo-setup.patch,2.70 KB, patch)
2015-01-02 10:33 UTC, PhobosK
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description PhobosK 2014-12-31 11:43:45 UTC
Created attachment 392762 [details, diff]
The new ebuild for webmin-1.720 (diff to 1.690)

There is a new upstream version of webmin -> 1.720

There are a couple of new features (and new Perl deps), but most important are the tightening/fixing of some security issues.

This security tightening needs some small extra changes in the installation and configure/reconfigure routines. 

So a new ebuild and a new setup script are needed for this version.

I have tested the webmin-1.720.ebuild and the gentoo-setup script and they work OK on amd64 and x86.

Please update the portage tree and remove any webmin versions prior to this one...

Thanks
Comment 1 PhobosK 2014-12-31 11:47:50 UTC
Created attachment 392764 [details, diff]
The new gentoo-setup script for the webmin-1.720 ebuild
Comment 2 Frank Krömmelbein 2015-01-01 22:57:54 UTC
Version 1.730 is now available for download.
Comment 3 PhobosK 2015-01-01 23:04:40 UTC
(In reply to Frank Krömmelbein from comment #2)
> Version 1.730 is now available for download.

ATM 1.730 is marked as a development version. The official latest one is still 1.720
Comment 4 Frank Krömmelbein 2015-01-02 08:51:15 UTC
(In reply to PhobosK from comment #3)
> (In reply to Frank Krömmelbein from comment #2)
> > Version 1.730 is now available for download.
> 
> ATM 1.730 is marked as a development version.

NO.

> The official latest one is
> still 1.720

NO.
It only lacked the announcement on the Website;-)

But it is there now:

Webmin 1.730 and Usermin 1.640 released
This update includes security fixes to produce against malicious links in the Read Mail module, a new API for theme authors, German and Catalan translation updates, numerous code cleanups, bug fixes and minor improvements. You can get it from the Webmin downloads page, or from our YUM or APT repositories.
January 1, 2015
Comment 5 PhobosK 2015-01-02 10:08:40 UTC
Created attachment 392934 [details, diff]
The new ebuild for webmin-1.730 (diff to 1.690)
Comment 6 PhobosK 2015-01-02 10:09:19 UTC
Created attachment 392936 [details, diff]
The new gentoo-setup script for the webmin-1.730 ebuild
Comment 7 PhobosK 2015-01-02 10:14:46 UTC
Ok...

Thanks @Frank Krömmelbein.

Changes are applied properly....

For the proxy-committer:
Meanwhile a new 1.730 version of webmin is out, so I've added the changes. The only change compared to 1.720 version is that the blue-theme is deprecated in favor of the gray-theme, so that is done in the gentoo-setup script....

All other changes in the gentoo-setup script are described in my first description of this bug report...

Thanks
Comment 8 PhobosK 2015-01-02 10:33:24 UTC
Created attachment 392940 [details, diff]
The new gentoo-setup script for the webmin-1.730 ebuild (fixed)

A small fix to replace the deprecated theme directly instead of adding the new theme at the end of both config files (and thus duplicating entries)
Comment 9 Yixun Lan archtester gentoo-dev 2015-01-05 02:23:03 UTC
(In reply to PhobosK from comment #8)
> Created attachment 392940 [details, diff] [details, diff]
> The new gentoo-setup script for the webmin-1.730 ebuild (fixed)
> 
> A small fix to replace the deprecated theme directly instead of adding the
> new theme at the end of both config files (and thus duplicating entries)

I assume the change of gentoo-setup script can also apply to version 1.690, correct? otherwise we need to create gentoo-setup-r1
Comment 10 PhobosK 2015-01-05 02:47:48 UTC
(In reply to Yixun Lan from comment #9)
> (In reply to PhobosK from comment #8)
> > Created attachment 392940 [details, diff] [details, diff] [details, diff]
> > The new gentoo-setup script for the webmin-1.730 ebuild (fixed)
> > 
> > A small fix to replace the deprecated theme directly instead of adding the
> > new theme at the end of both config files (and thus duplicating entries)
> 
> I assume the change of gentoo-setup script can also apply to version 1.690,
> correct? otherwise we need to create gentoo-setup-r1

Yes the changes can safely be applied to 1.690 too, but the problem is that the new 1.730 fixes some potential cross-site scripting issues, tightens security etc, so any versions prior to it, better be removed from portage...

See also bug 511624 comment 25 and bug 511624 comment 26
Comment 11 Yixun Lan archtester gentoo-dev 2015-01-05 03:23:48 UTC
+*webmin-1.730 (05 Jan 2015)
+
+  05 Jan 2015; Yixun Lan <dlan@gentoo.org> -webmin-1.690.ebuild,
+  +webmin-1.730.ebuild, files/gentoo-setup:
+  drop old due to security issue, bug 511624; bump new, bug 534092, thanks
+  PhobosK

Ok, I've dropped old, thanks for maintaining this ebuild