Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 532698 - app-emulation/libguestfs-1.28.3 USE=ocaml should depend on >=dev-lang/ocaml-4 - File "output_qemu.ml", line 81, characters 4-14: Error: Unbound value List.iteri
Summary: app-emulation/libguestfs-1.28.3 USE=ocaml should depend on >=dev-lang/ocaml-4...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Andreis Vinogradovs ( slepnoga )
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-16 13:29 UTC by Fabian Ohler
Modified: 2014-12-19 04:44 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
buildlogetc.tar.bz2 (buildlogetc.tar.bz2,37.43 KB, application/x-bzip-compressed-tar)
2014-12-16 13:29 UTC, Fabian Ohler
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Ohler 2014-12-16 13:29:48 UTC
Created attachment 391812 [details]
buildlogetc.tar.bz2

Hi, the latest libguestfs ebuild doesn't work for me when using the ocaml use flag.
The new updated code seems to use features introduced in ocaml 4 such as List.iteri and List.mapi.
Yet, the ebuild only specifies ocaml (without a version) as a dependency.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2014-12-17 06:44:04 UTC
Comment on attachment 391812 [details]
buildlogetc.tar.bz2

Please attach separate text files next time.
Comment 2 Richard Jones 2014-12-17 14:39:45 UTC
Actually I think it's better to fix this upstream.  I
have pushed this patch which removes the dependency on
OCaml >= 4.00.

https://github.com/libguestfs/libguestfs/commit/d375b7818a506e011b5f61c9a42c801180636201
Comment 3 Fabian Ohler 2014-12-18 00:17:41 UTC
(In reply to Richard Jones from comment #2)
> Actually I think it's better to fix this upstream.  I
> have pushed this patch which removes the dependency on
> OCaml >= 4.00.
> 
> https://github.com/libguestfs/libguestfs/commit/
> d375b7818a506e011b5f61c9a42c801180636201

Seems like a good idea, the file output_libvirt.ml in the same directory contains a reference to List.mapi which should then also be replaced by mapi.
By manually editing the two files, the build succeeded for me - Thanks!
Comment 4 Richard Jones 2014-12-18 08:31:46 UTC
I've made that second change upstream too:

https://github.com/libguestfs/libguestfs/commit/47d909808aa8cd285f46cab5ea08c7971f8f2f85
Comment 5 Richard Jones 2014-12-18 20:44:04 UTC
FYI libguestfs 1.28.5 contains both of these patches.

http://libguestfs.org/download/1.28-stable/
Comment 6 Yixun Lan archtester gentoo-dev 2014-12-19 04:44:39 UTC
+*libguestfs-1.28.5 (19 Dec 2014)
+
+  19 Dec 2014; Yixun Lan <dlan@gentoo.org> +libguestfs-1.28.5.ebuild:
+  version bump, solved ocaml dep, bug 532698, thanks Richard Jones
+