Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 531332 - app-portage/portage-utils: qlop -s, git support
Summary: app-portage/portage-utils: qlop -s, git support
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Third-Party Tools (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage Utils Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-01 13:11 UTC by Michał Górny
Modified: 2016-03-27 14:28 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
0001-qlop-s-support-git-sync-messages.patch (0001-qlop-s-support-git-sync-messages.patch,1.93 KB, patch)
2014-12-01 13:11 UTC, Michał Górny
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-12-01 13:11:20 UTC
Created attachment 390712 [details, diff]
0001-qlop-s-support-git-sync-messages.patch

The new version of Portage is going to have git syncing support which uses a bit different output like:

1234567890: >>> Git pull successful: /path
1234567890: >>> Git clone successful

I'm attaching a patch to handle that output along with rsync output in 'qlop -s'.
Comment 1 Albert W. Hopkins 2015-02-16 19:46:47 UTC
+1 on this as "qlop -s" doesn't work with the latest portage at all.
Comment 2 Derk W te Bokkel 2015-02-17 17:47:26 UTC
other tools also hit with this .. Bug #540050 for genlop
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2015-02-17 18:01:06 UTC
(In reply to Albert W. Hopkins from comment #1)
> +1 on this as "qlop -s" doesn't work with the latest portage at all.

That's a different issue. File a new bug report.
Comment 4 SpanKY gentoo-dev 2015-02-20 22:22:49 UTC
Comment on attachment 390712 [details, diff]
0001-qlop-s-support-git-sync-messages.patch

>-		if (strncmp(buf+12, "=== Sync completed with", 23) != 0)
>+		if (strncmp(buf+12, "=== Sync completed with", 23) != 0
>+				&& strncmp(buf+12, ">>> Git pull successful:", 24) != 0
>+				&& strncmp(buf+12, ">>> Git clone successful", 24) != 0)

line the code up with the (

 if (....
     && ...)

is this specific to git ?  what about other vcs's ?

>+		if ((p = strstr(q, "with")) != NULL)
>+		{

brace style is all wrong.  no one writes this -- please cuddle them.
Comment 5 SpanKY gentoo-dev 2016-03-27 14:28:14 UTC
i think this works now with the current sync format:
1431764402:  === sync
1431764402: >>> Syncing repository 'gentoo' into '/usr/portage'...
1431764460: === Sync completed for gentoo

portage uses that regardless of the sync module.  i don't think we really need to add support for the old sync formats.