Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 530560 - dev-python/pyftpdlib-1.3.0: tests fail with python 3.4
Summary: dev-python/pyftpdlib-1.3.0: tests fail with python 3.4
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on: 503094
Blocks: python-3.4
  Show dependency tree
 
Reported: 2014-11-25 10:15 UTC by Pacho Ramos
Modified: 2015-05-28 01:52 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (pyftpdlib-1.3.0:20141125-101340.log,36.13 KB, text/plain)
2014-11-25 10:15 UTC, Pacho Ramos
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2014-11-25 10:15:45 UTC
Created attachment 390246 [details]
build.log

.
Comment 1 Ian Delaney (RETIRED) gentoo-dev 2014-12-12 09:58:46 UTC
~/cvsPortage/gentoo-x86/dev-python/pyftpdlib $ grep test_on_incomplete_file_sent /mnt/gen2/TmpDir/portage/dev-python/pyftpdlib-1.3.0/temp//build.log 


----------------------------------------------------------------------
Ran 152 tests in 2.474s

OK
/usr/lib64/python2.7/atexit.py:24: RuntimeWarning: sendfile() not available - tests have been skipped
  func(*targs, **kargs)
>>> Completed testing dev-python/pyftpdlib-1.3.0


~/cvsPortage/gentoo-x86/dev-python/pyftpdlib $ grep test_on_incomplete_file_sent /mnt/gen2/TmpDir/portage/dev-python/pyftpdlib-1.3.0/temp//build.log 
test_on_incomplete_file_sent (__main__.TestCallbacks) ... ok
test_on_incomplete_file_sent (__main__.TestCallbacks) ... ok
test_on_incomplete_file_sent (__main__.TestCallbacks) ... ok

Did not replicate
Comment 2 Pacho Ramos gentoo-dev 2014-12-12 10:15:25 UTC
I am still hitting the problem... are you sure your tests are being run against python-3.4? From that snipped looks like they are run for python-2.7 (PYTHON_COMPAT is still only listing up to python 3.3 support, you will need to manually edit it ;))
Comment 3 Ian Delaney (RETIRED) gentoo-dev 2014-12-13 08:30:59 UTC
~/cvsPortage/gentoo-x86/dev-python/pyftpdlib $ PYTHON_TARGETS=python3_4 ebuild pyftpdlib-1.3.0.ebuild clean test

test_stou_rest (__main__.TestFtpStoreDataNoSendfile) ... ok

----------------------------------------------------------------------
Ran 171 tests in 2.772s

OK
>>> Completed testing dev-python/pyftpdlib-1.3.0

It ran 10 more tests in pyftpdlib-1.3.0 under py3.4 and all passed. 
All things are not equal.  You will need someone somewhere to replicate
Comment 4 Ian Delaney (RETIRED) gentoo-dev 2014-12-13 09:25:03 UTC
On attempting to add py3.4 support to this package, it failed on alpha required in a revdep.  Following the trail leads back to a bug filed one of our higher profile devs back in March which is effectively singly holding back a list of requests under keywording and stabliling.  While I pulled the finger from the dyke, the flood need now dissipate before this qualifies to have py3.4 added.
Comment 5 Pacho Ramos gentoo-dev 2015-05-12 17:30:50 UTC
If this is only a tests issue (due to missing dependencies), I would anyway add python3_4 support (and probably restrict tests or skip them for that arches... or even try to drop the keywords for that arches in this package if it doesn't end up needing to drop a ton of keywords in reverse deps :|)
Comment 6 Ian Delaney (RETIRED) gentoo-dev 2015-05-24 10:29:15 UTC
(In reply to Pacho Ramos from comment #5)
> If this is only a tests issue (due to missing dependencies), I would anyway
> add python3_4 support (and probably restrict tests or skip them for that
> arches...

I don't know how to skip them for alpha without masking IUSE test for alpha which it appears has been done by non alpha members in the past. Not something I have ever done.

> or even try to drop the keywords for that arches in this package
> if it doesn't end up needing to drop a ton of keywords in reverse deps :|)

Well according to equery d -a, this pyftpdlib has one revdep; dev-vcs/bzr which is in the <herd>bazaar</herd>. I for one am not touching a package of that herd.

  13 Apr 2015; Agostino Sarubbo <ago@gentoo.org> pyftpdlib-1.3.0.ebuild:
  Stable for alpha, wrt bug #540290

alpha has already been made stable. While this is still blocked by Bug 503094, repoman full reports error on dev-python/pyopenss for stable alpha and ~sparc. I see no point in deciding and committing since;
1. pyopenssl-0.14.ebuild has only been <Keyworded on alpha, bug 503094> and not yet made stable.
2. sparc is still outstanding for both.

Since the alpha team need address 1., it follows they could also be asked to mask IUSE test for this package.
Restricting tests is a radical solution since they are a problem in only one arch.
Comment 7 Pacho Ramos gentoo-dev 2015-05-27 21:36:25 UTC
What is the concrete dependency you need to add here to make tests work? (to let me to try to start with the keywording play for it)

Thanks
Comment 8 Mike Gilbert gentoo-dev 2015-05-28 00:21:47 UTC
(In reply to Pacho Ramos from comment #7)
> What is the concrete dependency you need to add here to make tests work? (to
> let me to try to start with the keywording play for it)

There is no such dependency; that test simply doesn't work on python3.4.

The dependency to which Ian is referring is dev-python/pyopenssl, which is behind the ssl use flag. It is not an issue that has anything to do with the testsuite.
Comment 9 Mike Gilbert gentoo-dev 2015-05-28 00:27:06 UTC
(In reply to Mike Gilbert from comment #8)
> There is no such dependency; that test simply doesn't work on python3.4.

Correction: the test fails when both python3.3 and python3.4 are enabled; it passes when only python3.4 is enabled.

It is likely that some of the test data is being overwritten during the test process.
Comment 10 Mike Gilbert gentoo-dev 2015-05-28 00:32:19 UTC
(In reply to Mike Gilbert from comment #9)

Further correction: I am able to sporadically reproduce the failure with only one python implementation in PYTHON_TARGETS.

I think the failure may depend on the order in which the individual tests are run, which appears to be somewhat random.
Comment 11 Mike Gilbert gentoo-dev 2015-05-28 00:34:47 UTC
(In reply to Mike Gilbert from comment #10)
> I think the failure may depend on the order in which the individual tests
> are run, which appears to be somewhat random.

Scratch that. I'm not sure why it works sometimes.
Comment 12 Mike Gilbert gentoo-dev 2015-05-28 01:52:38 UTC
The issue seems to be resolved in pyftpdlib-1.4.0.

+*pyftpdlib-1.4.0 (28 May 2015)
+
+  28 May 2015; Mike Gilbert <floppym@gentoo.org> +pyftpdlib-1.4.0.ebuild:
+  Version bump. Drop sparc keyword pending bug 503094.