Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 529582 - media-libs/urt: please review prefix changes
Summary: media-libs/urt: please review prefix changes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Graphics Project
URL:
Whiteboard:
Keywords: Inclusion
Depends on:
Blocks: prefix-gx86
  Show dependency tree
 
Reported: 2014-11-16 22:31 UTC by Christoph Junghans (RETIRED)
Modified: 2014-12-05 22:25 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Junghans (RETIRED) gentoo-dev 2014-11-16 22:31:15 UTC 
One extra patch for solaris:
<http://rsync8.prefix.bitzolder.nl/hg/prefix-tree/file/e3ea9c8b9a87/media-libs/urt/files/urt-3.1b-solaris.patch>
Comment 1 SpanKY gentoo-dev 2014-11-17 02:33:28 UTC 
feel free to commit, albeit with a proper patch header

http://dev.gentoo.org/~vapier/clean-patches
Comment 2 Christoph Junghans (RETIRED) gentoo-dev 2014-11-17 02:40:41 UTC 
@prefix: could somebody with a solaris system come up with a good header and historical information for that patch?
Comment 3 SpanKY gentoo-dev 2014-11-17 05:48:35 UTC 
it might be as simple as "the file uses 'errno' or EAGAIN", so explicitly requiring errno.h makes sense (rather than relying on an implicit include)

author info would be nice though
Comment 4 Fabian Groffen gentoo-dev 2014-11-17 12:17:38 UTC 
I added a patch header:

usage of errno requires errno.h

Fabian Groffen <grobian@gentoo.org>

--- get/getx11/x11_stuff.c
+++ get/getx11/x11_stuff.c
@@ -42,6 +42,7 @@
Comment 5 Christoph Junghans (RETIRED) gentoo-dev 2014-12-05 22:25:10 UTC 
+  05 Dec 2014; Christoph Junghans <ottxor@gentoo.org>
+  +files/urt-3.1b-solaris.patch, urt-3.1b-r1.ebuild:
+  added prefix support (bug #529582)
+