Bug 528374 – app-emacs/csharp-mode-0.7.0-r1: fails to build

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Diego Elio Pettenò (RETIRED) 2014-11-05 19:35:27 UTC]

https://tinderboxlogs.s3.amazonaws.com/tbamd64.excelsior.flameeyes.eu/app-emacs%3Acsharp-mode-0.7.0-r1%3A20141102-214640.html

Portage 2.2.14_rc1 (python 2.7.8-final-0, default/linux/amd64/13.0, gcc-4.9.1-asneeded, glibc-2.20, 3.15.5-hardened-r2 x86_64)
=================================================================
System uname: Linux-3.15.5-hardened-r2-x86_64-AMD_Opteron-TM-_Processor_6272-with-gentoo-2.2
KiB Mem:    65962672 total,  16391156 free
KiB Swap:          0 total,         0 free
Timestamp of tree: Unknown
ld ld di GNU (Gentoo 2.24 p1.4) 2.24
distcc 3.1 x86_64-pc-linux-gnu [disabled]
ccache version 3.1.9 [disabled]
app-shells/bash:          4.2_p53
dev-java/java-config:     2.2.0
dev-lang/perl:            5.18.2-r2
dev-lang/python:          2.7.8, 3.2.5-r6, 3.3.5-r1, 3.4.1
dev-util/ccache:          3.1.9
dev-util/cmake:           2.8.12.2-r2
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.13.1
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.4_p6-r1, 1.9.6-r3, 1.10.3, 1.11.6, 1.12.6, 1.13.2, 1.14.1
sys-devel/binutils:       2.24-r3
sys-devel/gcc:            4.6.4, 4.7.4, 4.8.3, 4.9.1
sys-devel/gcc-config:     1.8
sys-devel/libtool:        2.4.2-r1
sys-devel/make:           4.1
sys-kernel/linux-headers: 3.17 (virtual/os-headers)
sys-libs/glibc:           2.20
Repositories: gentoo
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -ggdb -march=native -ftracer -frecord-gcc-switches"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /etc/entropy /opt/openjms/config /usr/share/bufrtables /usr/share/config /usr/share/easy-rsa /usr/share/gnupg/qualified.txt /usr/share/maven-bin-3.0/conf /usr/share/themes/oxygen-gtk/gtk-2.0 /var/bind /var/lib/hsqldb /var/lib/neatx/home /var/spool/torque /var/yp/Makefile"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/games/angband/edit/ /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe -ggdb -march=native -ftracer -frecord-gcc-switches"
DISTDIR="/var/cache/portage/distfiles"
FCFLAGS="-O2 -pipe -ggdb -march=native -frecord-gcc-switches"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fail-clean fixlafiles merge-sync news parallel-fetch protect-owned sandbox sfperms strict test test-fail-continue unknown-features-warn unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -pipe -ggdb -march=native -frecord-gcc-switches"
GENTOO_MIRRORS="http://ftp.ucsb.edu/pub/mirrors/linux/gentoo/ http://gentoo.mirrors.hoobly.com/ http://gentoo.llarian.net/"
LANG="en_US.utf8"
LC_ALL="C"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j24"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/tmp"
PORTDIR="/var/cache/tinderbox/tree"
PORTDIR_OVERLAY=""
SYNC="rsync://excelsior.flameeyes.eu/gentoo-portage"
USE="3dnow 3dnowex acl amd64 berkdb blas bzip2 cli cracklib crypt cxx doc dri emacs ffmpeg fortran freetype iconv icu intl introspection ipv6 lapack mmx modules multilib ncurses nls nptl openmp pam pax_kernel pcre pdf plasma qt3support readline semantic-desktop session snmp sse sse2 sse3 sse4 ssl ssse3 tcmalloc tcpd truetype udev unicode vhosts xft zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3" RUBY_TARGETS="ruby19" USERLAND="GNU" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON

[Comment 1 Ulrich Müller 2014-11-05 20:51:05 UTC]

Newest HOMEPAGE seems to be at <https://code.google.com/p/csharpmode/>. Unfortunately, version 0.8.6 (which announces itself as 0.8.5) doesn't build with Emacs 24.4 either. No visible upstream activity since 2011.

# Ulrich Müller <[e-mail]> (5 Nov 2014)
# Does not build with Emacs 24.4.
# Last visible upstream activity in 2011.
# Masked for removal in 30 days, bug #528374.
app-emacs/csharp-mode

[Comment 2 Andrew Miller 2014-11-19 00:36:17 UTC]

Created attachment 389662 [details, diff]
csharp-mode.el require cl

Hi,

Please don't delete csharp-mode, AFAIK there are no alternatives and it can be fixed with a one-line patch.

Note this patch is only for emacs 24.4. The cl package has been deprecated, and may disappear in future versions of emacs.

But upstream is aware of the issue (see https://lists.gnu.org/archive/html/bug-gnu-emacs/2014-10/msg01175.html) and it should be fixed in emacs 24.5; we won't need the patch anymore.

[Comment 3 Ulrich Müller 2014-11-19 08:57:33 UTC]

Created attachment 389714 [details, diff]
csharp-mode-0.7.0-emacs-24.4.patch

@Andrew: Does attached patch (including a version check for emacs-24.4) fix the problem for you?

[Comment 4 Andrew Miller 2014-11-19 16:29:12 UTC]

(In reply to Ulrich Müller from comment #3)

Yes. It compiles and runs fine; code is indented and syntax is highlighted correctly.

Should I file a separate bug report for a version bump? Version 0.8.6 adds some nice features.

[Comment 5 Ulrich Müller 2014-11-19 18:22:55 UTC]

(In reply to Andrew Miller from comment #4)
> Yes. It compiles and runs fine; code is indented and syntax is highlighted
> correctly.

Fixed in CVS and mask removed.

> Should I file a separate bug report for a version bump? Version 0.8.6 adds
> some nice features.

Byte-compilation fails for it though, even if I apply the cl patch. I've tested versions 0.8.6, 0.8.2, and 0.7.5, with no success.

[Comment 6 Andrew Miller 2014-11-19 19:04:20 UTC]

Created attachment 389788 [details, diff]
csharp-mode-0.8.6-emacs-24.4.patch

(In reply to Ulrich Müller from comment #5)

> Fixed in CVS and mask removed.

Cheers.

> > Should I file a separate bug report for a version bump? Version 0.8.6 adds
> > some nice features.
> 
> Byte-compilation fails for it though, even if I apply the cl patch. I've
> tested versions 0.8.6, 0.8.2, and 0.7.5, with no success.

I got it working with this patch, taken from comment #3 at https://code.google.com/p/csharpmode/issues/detail?id=1.

I'm not sure whether we should use eval-and-compile or eval-when-compile, I have to read the elisp docs.

[Comment 7 Andrew Miller 2014-11-19 19:08:42 UTC]

Also, maybe it should be split into two patches, since it fixes different issues?

[Comment 8 Ulrich Müller 2014-11-19 19:31:26 UTC]

(In reply to Andrew Miller from comment #6)
> Created attachment 389788 [details, diff] [details, diff]
> csharp-mode-0.8.6-emacs-24.4.patch

> I got it working with this patch, taken from comment #3 at
> https://code.google.com/p/csharpmode/issues/detail?id=1.
> 
> I'm not sure whether we should use eval-and-compile or eval-when-compile,
> I have to read the elisp docs.

Rule of thumb is that it should be eval-and-compile if you enclose existing code with it, and eval-when-compile if you add something new to make it compile. :)


(In reply to Andrew Miller from comment #7)
> Also, maybe it should be split into two patches, since it fixes different
> issues?

Should be separate patches for separate issues (so we can drop them separately, if only one of the issues gets fixed in the next upstream version).

But can you file a new bug for the version bump please, so I won't forget about the issue? I still get several warnings when byte-compiling, and I have to investigate if we can safely ignore them.