Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 527746 - dev-java/oracle-jdk-bin should only use RDEPEND for SELinux policy package dependency
Summary: dev-java/oracle-jdk-bin should only use RDEPEND for SELinux policy package de...
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Java team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 527698
  Show dependency tree
 
Reported: 2014-11-01 10:26 UTC by Sven Vermeulen (RETIRED)
Modified: 2014-11-02 08:22 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Vermeulen (RETIRED) gentoo-dev 2014-11-01 10:26:36 UTC
Please remove the "selinux? ( sec-policy/selinux-* )" dependency in the DEPEND variable (not RDEPEND). Take this into account with your next package bump - if after 6 months there have been no need for other package upgrades, we will be bumping the package(s) ourselves with just this change.

For more information, see our tracker Bug #527698 [1]. The requested change will be posted as a separate comment/patch. Note that if the package also depends on libselinux, libselinux itself should still remain in DEPEND and RDEPEND.

[1] https://bugs.gentoo.org/show_bug.cgi?id=527698


Reproducible: Always
Comment 1 Sven Vermeulen (RETIRED) gentoo-dev 2014-11-01 10:26:46 UTC
Index: oracle-jdk-bin-1.7.0.71.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/dev-java/oracle-jdk-bin/oracle-jdk-bin-1.7.0.71.ebuild,v
retrieving revision 1.1
diff -u -B -r1.1 oracle-jdk-bin-1.7.0.71.ebuild
--- oracle-jdk-bin-1.7.0.71.ebuild      1 Nov 2014 07:09:35 -0000       1.1
+++ oracle-jdk-bin-1.7.0.71.ebuild      1 Nov 2014 10:25:54 -0000
@@ -66,9 +66,7 @@
 RESTRICT="fetch strip"
 QA_PREBUILT="*"
 
-COMMON_DEP="
-       selinux? ( sec-policy/selinux-java )"
-RDEPEND="${COMMON_DEP}
+RDEPEND="
        X? ( !aqua? (
                x11-libs/libX11
                x11-libs/libXext
@@ -76,13 +74,14 @@
                x11-libs/libXrender
                x11-libs/libXtst
        ) )
+       selinux? ( sec-policy/selinux-java )
        alsa? ( media-libs/alsa-lib )
        doc? ( dev-java/java-sdk-docs:1.7 )
        fontconfig? ( media-libs/fontconfig )
        !prefix? ( sys-libs/glibc )"
 # scanelf won't create a PaX header, so depend on paxctl to avoid fallback
 # marking. #427642
-DEPEND="${COMMON_DEP}
+DEPEND="
        jce? ( app-arch/unzip )
        examples? ( kernel_linux? ( app-arch/unzip ) )
        pax_kernel? ( sys-apps/paxctl )"
Index: oracle-jdk-bin-1.8.0.25.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/dev-java/oracle-jdk-bin/oracle-jdk-bin-1.8.0.25.ebuild,v
retrieving revision 1.1
diff -u -B -r1.1 oracle-jdk-bin-1.8.0.25.ebuild
--- oracle-jdk-bin-1.8.0.25.ebuild      21 Oct 2014 12:35:39 -0000      1.1
+++ oracle-jdk-bin-1.8.0.25.ebuild      1 Nov 2014 10:25:54 -0000
@@ -66,9 +66,7 @@
 RESTRICT="fetch strip"
 QA_PREBUILT="*"
 
-COMMON_DEP="
-       selinux? ( sec-policy/selinux-java )"
-RDEPEND="${COMMON_DEP}
+RDEPEND="
        X? ( !aqua? (
                x11-libs/libX11:0
                x11-libs/libXext:0
@@ -79,10 +77,11 @@
        alsa? ( media-libs/alsa-lib:0 )
        doc? ( dev-java/java-sdk-docs:${SLOT} )
        fontconfig? ( media-libs/fontconfig:1.0 )
+       selinux? ( sec-policy/selinux-java )
        !prefix? ( sys-libs/glibc:* )"
 # A PaX header isn't created by scanelf, so depend on paxctl to avoid fallback
 # marking. See bug #427642.
-DEPEND="${COMMON_DEP}
+DEPEND="
        jce? ( app-arch/unzip:0 )
        examples? ( kernel_linux? ( app-arch/unzip:0 ) )
        pax_kernel? ( sys-apps/paxctl:0 )"
Comment 2 Sven Vermeulen (RETIRED) gentoo-dev 2014-11-02 08:22:51 UTC
After checking with a few colleague developers it seems that this change does not need a revision bump after all. As such, I will make the necessary changes to the packages myself.

My apologies for the noise.