Created attachment 387366 [details] build.log creating /home/tmp/portage/dev-python/pypax-0.8.6/work/elfix-0.8.6/scripts-python3_3/temp.linux-x86_64-3.3 clang -O2 -march=core2 -mtune=core2 -msse4.1 -msse4.2 -pipe -fPIC -DPTPAX=1 -DXTPAX=1 -DNEED_PAX_DECLS=1 -I/usr/include/python3.3 -c paxmodule.c -o /home/tmp/portage/dev-python/pypax-0.8.6/work/elfix-0.8.6/scripts-python3_3/temp.linux-x86_64-3.3/paxmodule.o paxmodule.c:104:3: error: non-void function 'PyInit_pax' should return a value [-Wreturn-type] return; ^ 1 error generated. error: command 'clang' failed with exit status 1
Created attachment 387368 [details] emerge --info
can you confirm that this happens with 0.9.0? if not we may just be able to remove the older version
(In reply to Matthew Thode ( prometheanfire ) from comment #2) > can you confirm that this happens with 0.9.0? if not we may just be able to > remove the older version It still fails with 0.9.0: paxmodule.c:104:3: error: non-void function 'PyInit_pax' should return a value [-Wreturn-type] return; ^ 1 error generated.
jer, wrong maintainer btw :P
(In reply to Juan Simón from comment #3) > (In reply to Matthew Thode ( prometheanfire ) from comment #2) > > can you confirm that this happens with 0.9.0? if not we may just be able to > > remove the older version > > It still fails with 0.9.0: > > paxmodule.c:104:3: error: non-void function 'PyInit_pax' should return a > value [-Wreturn-type] > return; > ^ > 1 error generated. Sorry, I'm not really supporting clang right now. I'd like to but I don't have time. If you have a patch, reopen and I'll add it.
Created attachment 392798 [details, diff] Add ifdef for python3 non-void init return value Sorry for joining late, I am attaching the patch that fixes the issue. The patch adds an ifdef, returning the correct value for both versions of python: - void for python 2.x - NULL for python 3.x I'm no python expert, I've taken the information from this article ("Module Initialization" section): http://python3porting.com/cextensions.html Given the little length of the code, I've implemented the first solution (#ifdefs), which follows the coding style already in use.
(In reply to Fabio Scaccabarozzi from comment #6) > Created attachment 392798 [details, diff] [details, diff] > Add ifdef for python3 non-void init return value > > Sorry for joining late, I am attaching the patch that fixes the issue. > > The patch adds an ifdef, returning the correct value for both versions of > python: - void for python 2.x > - NULL for python 3.x > > I'm no python expert, I've taken the information from this article ("Module > Initialization" section): > http://python3porting.com/cextensions.html > Given the little length of the code, I've implemented the first solution > (#ifdefs), which follows the coding style already in use. commit 9c5d66ed746deaf51033b322022b9070e0984011 Author: Fabio Scaccabarozzi <fsvm88@gmail.com> Date: Sun Jan 4 10:23:41 2015 -0500 scripts/paxmodule.c: fix build with clang clang complains of a return with no NULL. X-Gentoo-Bug: 526832 X-Gentoo-Bug-URL: https://bugs.gentoo.org/526832 Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
