Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 526570 - games-simulation/openttd-1.4.4: version bump
Summary: games-simulation/openttd-1.4.4: version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: Normal enhancement with 3 votes (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-23 09:17 UTC by DrSlony
Modified: 2015-01-10 11:02 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fix compile patch (makecompile.diff,696 bytes, patch)
2015-01-03 09:29 UTC, Bernd Buschinski
Details | Diff
openttd-1.4.4-cflags.patch (openttd-1.4.4-cflags.patch,1.00 KB, patch)
2015-01-07 21:32 UTC, Lars Wendler (Polynomial-C) (RETIRED)
Details | Diff
openttd-freetype254.patch (openttd-freetype254.patch,1.67 KB, patch)
2015-01-07 21:33 UTC, Lars Wendler (Polynomial-C) (RETIRED)
Details | Diff
openttd-1.4.4.ebuild.diff (openttd-1.4.4.ebuild.diff,387 bytes, patch)
2015-01-07 21:36 UTC, Lars Wendler (Polynomial-C) (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description DrSlony 2014-10-23 09:17:12 UTC
Request for games-simulation/openttd-1.4.4 ebuild.

Reproducible: Always
Comment 1 DrSlony 2014-11-03 12:07:01 UTC
Bump
Comment 2 Roy Wellington 2014-11-16 19:48:01 UTC
It's Sunday and I wanted to play, so I copied the 1.4.2 ebuild and tweaked it for 1.4.4. You can find a copy of it in my personal overlay here:

  https://github.com/thanatos/gentoo-overlay/tree/master/games-simulation/openttd

I've not tested it beyond: 1. it builds and 2. the title screen loads up for me. :-)

A note to the maintainer, if you decide to put this into portage: the 1.4.2 ebuild cut out some sections from config.lib, I presume because they added stuff to CFLAGS, and we wanted to give priority to the user's portage/make.conf CFLAGS instead. I've kept as much of that as possible, but the line with "-fomit-frame-pointer" got moved around. The new patch still removes the -O2, but leaves the "-fomit-frame-pointer" flag in; feel free to edit that if needed/wanted. (If you just compare the first hunk by eye in the 1.4.2 patch and my 1.4.4 patch, you'll see it…)
Comment 3 Leif Biberg Kristensen 2014-12-12 00:33:47 UTC
(In reply to Roy Wellington from comment #2)
> It's Sunday and I wanted to play, so I copied the 1.4.2 ebuild and tweaked
> it for 1.4.4. You can find a copy of it in my personal overlay here:
> 
>  
> https://github.com/thanatos/gentoo-overlay/tree/master/games-simulation/
> openttd
> 
> I've not tested it beyond: 1. it builds and 2. the title screen loads up for
> me. :-)

Roy, thank you very much for your work. I copied your ebuild and cflags patch to my own private overlay, and then made my own manifest. The package compiled flawlessly, and I'm now in my 12th in-game year without any issues.

See also the thread http://forums.gentoo.org/viewtopic-t-940514.html on gentoo forums.
Comment 4 Bernd Buschinski 2015-01-03 09:29:22 UTC
Created attachment 393052 [details, diff]
fix compile patch

Compiling (with gcc 4.9.2) failed for me, but this tiny patch fixes it.

It fails like...

openttd-1.4.4/src/fontcache.cpp: In member function 'virtual const Sprite* FreeTypeFontCache::GetGlyph(GlyphID)':
openttd-1.4.4/src/fontcache.cpp:532:66: error: no matching function for call to 'max(int, unsigned int)'
  int width  = max(1, slot->bitmap.width + (this->fs == FS_NORMAL));
                                                                  ^
openttd-1.4.4/src/fontcache.cpp:532:66: note: candidate is:
In file included from /home/buscher/QT/openttd-1.4.4/src/fontcache.cpp:16:0:
openttd-1.4.4/src/core/math_func.hpp:38:17: note: template<class T> T max(T, T)
 static inline T max(const T a, const T b)
Comment 5 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2015-01-07 21:32:24 UTC
Created attachment 393440 [details, diff]
openttd-1.4.4-cflags.patch

Reworked cflags patch
Comment 6 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2015-01-07 21:33:16 UTC
Created attachment 393442 [details, diff]
openttd-freetype254.patch

Official upstream patch to fix compilation with =freetype-2.5.4
Comment 7 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2015-01-07 21:36:36 UTC
Created attachment 393444 [details, diff]
openttd-1.4.4.ebuild.diff

Changes I did to make the ebuild work.
Comment 8 DrSlony 2015-01-09 22:04:33 UTC
Lars Wendler's files work, the result is a working OpenTTD 1.4.4 on amd64. The first time I ran it a new sound slider kept appearing and disappearing in the kmixer (KDE sound mixer) many times per second, resulting in some garbled sound (maybe it was the music, as I heard some non-music sound like train bells clearly), but all subsequent times I ran it the sound played fine.
Comment 9 Mr. Bones. (RETIRED) gentoo-dev 2015-01-10 09:22:46 UTC
1.4.4 in portage.  thanks for the patches.
Comment 10 DrSlony 2015-01-10 11:02:33 UTC
Thank you!