There is a amavisd-new-courier.patch file in the source package included. If you want to use amavisd-new as courier-filter, you need to apply this patch before installing. This won't hurt even if you doen't use amavisd-new with courier. It will only add some additional features. Eventually, this is something for a local useflag or a test if courier is installed will probably a usable solution. Reproducible: Always Steps to Reproduce: 1. The emerge doesn't apply the patch anytime. 2. 3. Actual Results: Feature is missing. Expected Results: It should include the additional features for the courier-filter.
Created attachment 32214 [details] amavisd-new-20030616_p9.ebuild modified for patching. This is my proposal to solve this problem.
maybe there should be USE flags to turn on and off patches.. ?
Please correct the ebuild of amavisd-new to aply the courier patch if courier is installed !
amavisd-new-20040701 is missing a courier patch :/ I can see some at sourceforge for 20040701-rc*; I'll see if I can nobble one together that patches cleanly against amavisd-new-20040701.
Ignore my previous comment ;) I forgot to check /var/tmp/portage/amavisd-new-20040701/work/amavisd-new-20040701 -- patch present and working!
How do you guys use this patch? Do you use the automatic or the manual start/stop method? What have you found the pros and cons to be? Also, does this patch change the behavior of non-courier mail systems?
To apply the patch do the following: ** Note I am using ~x86 version (amavisd-new-20040707) ** 1. emerge amavisd-new, let it finish completely 1. emerge amavisd-new, ctrl+c after it has finished unpacking the source 2. cd /var/tmp/portage/amavisd-new-20040701/work/amavisd-new-20040701 3. patch < amavisd-new-courier.patch 4. cp amavisd /usr/sbin/ 5. cp amavisd.conf /etc/ Job done.
Also, no, it doesn't affect non-courier systems, it just adds extra options for courier. It may use different defaults then the normal conf though.
Sorry for all these comments. Isn't it possible to edit a bug? Please note it should be steps 1 to 6 above (not two 1's).
I think I will just apply this patch universally in the ebuild then. Can anyone think of why not?
I can't think of any reasons not too. I seriously wonder why amavis didn't do this anyway. Making Courier users patch for extra support seems so very strange, and the usual rigmoral of editing the conf to choose your chosen mta/scanners has to be done anyway. I would patch as default, or add a courier USE flag.
Will the ebuild with applying the patch make it into portage?
I have applied the patch maually, and had to change the home dir of amavis to /var/amavis instead of /var/lib/amavis. Also I changed the /var/amavis to group mail and make ich writeable by group so courier can write to this dir when amavis is called by courier. I f amavis is called by courier I cannot use /etc/init.d/courier restart, because amavis needs a few secs to terminate an clean up things. Maybe a check coud be don in the courier start script if amavis is terminated (pid file?) I vote for a courier use flag for the amavisd-new ebuild.
Where did you have to change the the amavisd-new homedir? The group-writeable issue is significant. Thank you for reporting this. I'll try to come up with a universal solution, otherwise, I'll implement a USE flag.
I'm not 100% sure anymore, but IIRC the home dir of user amavis pointed to /var/lib/amavis, so I had to edit /etc/passwd I just have checked the amavisd-new ebuild which creates the user, this seems to be ok. Hmmm.
Is this still an issue with amavisd-new 2.2.0 from bug #64462?
The Problem is also with amavisd-new 2.2.0 the same, only the Patch has a new name.
Daniel updated bug #64462 with initial courier support. Please test and report back on the bug.
Closing, please reopen if needed.
