Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 522152 - games-action/rune-1.07-r2: unnecessary dependency on app-emulation/emul-linux-x86-compat
Summary: games-action/rune-1.07-r2: unnecessary dependency on app-emulation/emul-linux...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords: QAbaddep, QAcanfix
Depends on:
Blocks: 466750
  Show dependency tree
 
Reported: 2014-09-04 17:24 UTC by Ulrich Müller
Modified: 2014-09-07 09:16 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2014-09-04 17:24:29 UTC
According to scanelf, none of the binaries in the distfile links against anything in app-emulation/emul-linux-x86-compat, so this can be removed from RDEPEND.

Preferably, the remaining dependencies should be updated for multilib, namely:

RDEPEND="virtual/opengl
    dev-util/xdelta:0
    || (
        (
            >=media-libs/libsdl-1.2.15-r4[abi_x86_32(-)]
            >=x11-libs/libX11-1.6.2[abi_x86_32(-)]
            >=x11-libs/libXext-1.3.2[abi_x86_32(-)]
        )
        amd64? (
            app-emulation/emul-linux-x86-sdl[-abi_x86_32(-)]
            app-emulation/emul-linux-x86-xlibs[-abi_x86_32(-)]
        )
    )"
Comment 1 Julian Ospald 2014-09-04 18:41:20 UTC
same as in the other bug... libsdl dep is probably not correct that way and needs USE flags
Comment 2 Ulrich Müller gentoo-dev 2014-09-04 19:17:25 UTC
(In reply to Julian Ospald (hasufell) from comment #1)
> same as in the other bug... libsdl dep is probably not correct that way and
> needs USE flags

I went from the current dependency in the ebuild, which is >=media-libs/libsdl-1.2.9-r1 on x86 without any USE dependencies. If you have the CD and can test what is needed at runtime, then we can of course improve on this.

The main goal of this bug is to get rid of the emul-linux-x86-compat dependency, though.
Comment 3 Julian Ospald 2014-09-04 19:31:43 UTC
(In reply to Ulrich Müller from comment #2)
> (In reply to Julian Ospald (hasufell) from comment #1)
> > same as in the other bug... libsdl dep is probably not correct that way and
> > needs USE flags
> 
> I went from the current dependency in the ebuild, which is
> >=media-libs/libsdl-1.2.9-r1 on x86 without any USE dependencies. If you
> have the CD and can test what is needed at runtime, then we can of course
> improve on this.
> 
> The main goal of this bug is to get rid of the emul-linux-x86-compat
> dependency, though.

I'v asked for discount before on GoG, but they didn't answer :P
Comment 4 Ulrich Müller gentoo-dev 2014-09-07 09:16:40 UTC
I've removed emul-linux-x86-compat from RDEPEND, but left the other dependencies untouched.