Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 522128 - eutils.eclass: einstalldocs should handle HACKING and MAINTAINERS files too
Summary: eutils.eclass: einstalldocs should handle HACKING and MAINTAINERS files too
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-04 09:47 UTC by Pacho Ramos
Modified: 2016-02-03 14:15 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2014-09-04 09:47:02 UTC
We are currently needing to manually set DOCS variable only to include this two files for many gnome packages because seems that they are fairly common then. 

I think would be really useful for us to also handle this two files to allow us to drop lots of DOCS="AUTHORS HACKING MAINTAINERS NEWS README" from ebuilds that are only needed to append this two files :)

Thanks a lot
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2014-09-09 12:58:19 UTC
(In reply to Pacho Ramos from comment #0)
> We are currently needing to manually set DOCS variable only to include this
> two files for many gnome packages because seems that they are fairly common
> then. 
> 
> I think would be really useful for us to also handle this two files to allow
> us to drop lots of DOCS="AUTHORS HACKING MAINTAINERS NEWS README" from
> ebuilds that are only needed to append this two files :)

no!  if maintainer has taken the time to define proper DOCS, it should never be removed!  package directory might have semi-empty files that shouldn't be installed and maintainer has defined DOCS="AUTHORS README" to skip everything else.  i'd be pretty pissed after seeing people dropping _defined variables with varying content_ from the ebuilds.

> 
> Thanks a lot

i'd prefer to see whole default list of files in DOCS be removed, so defining proper DOCS per ebuild would be mandatory.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-12-10 09:00:50 UTC
einstalldocs must not diverge from EAPI 6 spec, and the eutils impl will be disabled starting with EAPI 6.

Also nice that somebody bothered CC-ing the one who committed the function.
Comment 3 Pacho Ramos gentoo-dev 2014-12-11 10:01:51 UTC
(In reply to Michał Górny from comment #2)
[...]
> Also nice that somebody bothered CC-ing the one who committed the function.

As you weren't listed in the function as maintainer I thought it was now handled by base-system :| because other functions like validate_desktop_entries have their own maintained specified while this not :/. Sorry for that