521800 – mythtv-plugins.eclass: suspicious use of einstall

Bug 521800 - mythtv-plugins.eclass: suspicious use of einstall

Summary: mythtv-plugins.eclass: suspicious use of einstall

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	MythTV Maintainers

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	suspicious-einstall
	Show dependency tree

Reported:	2014-08-31 10:46 UTC by Michał Górny
Modified:	2015-09-16 17:51 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2014-08-31 10:46:20 UTC

The eclass does:

  einstall INSTALL_ROOT="${D}"

which pretty much proves that it supports DESTDIR in form of INSTALL_ROOT. Therefore, einstall should not be used here.

Comment 1 Richard Freeman gentoo-dev

2014-08-31 11:12:59 UTC

As far as I can tell nothing should be even using this eclass now.  Is there any reason to keep it around?

If we have to hang onto it for the sake of uninstalling old versions of mythtv then I'd suggest ignoring this or just making the install phase a no-op.

Comment 2 Doug Goldstein (RETIRED) gentoo-dev

2015-09-05 03:52:36 UTC

@mgorny: Know the policy on removing old eclasses? Honestly I can't remember the last time that eclass was used. Probably 4 years ago?

Comment 3 Doug Goldstein (RETIRED) gentoo-dev

2015-09-16 17:51:08 UTC

Thanks for the report. Fixed in http://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e30816724e4daaf09e6404c5cad5701826c2a1bc