521660 – www-plugins/kaffeine-mozilla-plugin-0.2: suspicious use of einstall

Bug 521660 - www-plugins/kaffeine-mozilla-plugin-0.2: suspicious use of einstall

Summary: www-plugins/kaffeine-mozilla-plugin-0.2: suspicious use of einstall

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal QA (vote)
Assignee:	Gentoo Media-video project

URL:
Whiteboard:	suspicious-einstall
Keywords:

Depends on:
Blocks:	suspicious-einstall
	Show dependency tree

Reported:	2014-08-29 22:06 UTC by Michał Górny
Modified:	2014-09-04 15:20 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2014-08-29 22:06:57 UTC

Please check whether the use of 'einstall' in this ebuild is actually
needed. From a quick glance at the Makefile, it seems to have proper
support for DESTDIR.

Therefore, if possible please replace the call to 'einstall' with proper
'default' or 'emake DESTDIR="${D}" install'. Thanks.

Comment 1 Michael Palimaka (kensington) gentoo-dev

2014-09-04 15:20:44 UTC

Thanks, fixed in CVS. Old revision will be removed in due course (although I wonder if anyone actually uses it since it appears to have been completely broken for at least 6 years...).

+  04 Sep 2014; Michael Palimaka <kensington@gentoo.org>
+  +kaffeine-mozilla-plugin-0.2-r1.ebuild:
+  Migrate to EAPI 5. Add missing dependencies. Remove useless la files. Install
+  plugin to correct directory. Avoid unnecessary einstall usage wrt bug #521660.