521584 – net-dialup/sercd-3.0.0: suspicious use of einstall

Bug 521584 - net-dialup/sercd-3.0.0: suspicious use of einstall

Summary: net-dialup/sercd-3.0.0: suspicious use of einstall

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal QA (vote)
Assignee:	Gentoo Dialup Developers

URL:
Whiteboard:	suspicious-einstall
Keywords:

Depends on:
Blocks:	suspicious-einstall
	Show dependency tree

Reported:	2014-08-29 21:08 UTC by Michał Górny
Modified:	2014-12-04 07:15 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2014-08-29 21:08:23 UTC

Please check whether the use of 'einstall' in this ebuild is actually
needed. From a quick glance at the Makefile, it seems to have proper
support for DESTDIR.

Therefore, if possible please replace the call to 'einstall' with proper
'default' or 'emake DESTDIR="${D}" install'. Thanks.

Comment 1 Sergey Popov gentoo-dev

2014-12-04 07:15:01 UTC

+*sercd-3.0.0-r1 (04 Dec 2014)
+
+  04 Dec 2014; Sergey Popov <pinkbyte@gentoo.org> -sercd-3.0.0.ebuild,
+  +sercd-3.0.0-r1.ebuild, files/sercd.confd, files/sercd.initd,
+  files/sercd.xinetd:
+  Revision bump: EAPI 5, epatch_user, replace einstall with default src_install
+  phase function call wrt bug #521584, replace /var/lock with /run/lock,
+  replace /var/run with /run in default configuration. Drop old revision