521548 – dev-util/txt2regex-0.8-r1: suspicious use of einstall

Bug 521548 - dev-util/txt2regex-0.8-r1: suspicious use of einstall

Summary: dev-util/txt2regex-0.8-r1: suspicious use of einstall

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal QA (vote)
Assignee:	Gentoo Shell Tools project

URL:
Whiteboard:	suspicious-einstall
Keywords:

Depends on:
Blocks:	suspicious-einstall
	Show dependency tree

Reported:	2014-08-29 20:50 UTC by Michał Górny
Modified:	2015-09-25 03:53 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2014-08-29 20:50:28 UTC

Please check whether the use of 'einstall' in this ebuild is actually
needed. From a quick glance at the Makefile, it seems to have proper
support for DESTDIR.

Therefore, if possible please replace the call to 'einstall' with proper
'default' or 'emake DESTDIR="${D}" install'. Thanks.

Comment 1 Patrice Clement gentoo-dev

2015-09-25 03:53:38 UTC

commit a1946d1 (HEAD, master)
Author: Patrice Clement <monsieurp@gentoo.org>
Date:   Fri Sep 25 03:51:46 2015 +0000

    dev-util/txt2regex: EAPI 5 bump. Remove suspicious use of einstall. Fixes bug 521548.
    
    Package-Manager: portage-2.2.18
    RepoMan-Options: --force
    Signed-off-by: Patrice Clement <monsieurp@gentoo.org>

 delete mode 100644 dev-util/txt2regex/txt2regex-0.8-r1.ebuild
 create mode 100644 dev-util/txt2regex/txt2regex-0.8-r2.ebuild

Changes went straight to stable.